all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#50688] [PATCH] gnu: go-github-com-alcortesm-tgz: Don't reset gzip timestamps.
@ 2021-09-19 23:32 Sarah Morgensen
  2021-12-08 18:37 ` bug#50688: " Leo Famulari
  0 siblings, 1 reply; 2+ messages in thread
From: Sarah Morgensen @ 2021-09-19 23:32 UTC (permalink / raw)
  To: 50688

The tgz files are committed test fixtures, so don't reset their timestamps.

* gnu/packages/golang.scm (go-github-com-alcortesm-tgz)[arguments]:
Remove 'make-git-checkout-writable' phase.  Delete
'reset-gzip-timestamps' phase instead.
---
 gnu/packages/golang.scm | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index f02d0aa9df..b53a4e3686 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -7546,11 +7546,8 @@ (define-public go-github-com-alcortesm-tgz
        `(#:import-path "github.com/alcortesm/tgz"
          #:phases
          (modify-phases %standard-phases
-           (add-after 'unpack 'make-git-checkout-writable
-             (lambda* (#:key outputs #:allow-other-keys)
-               (for-each make-file-writable (find-files "."))
-               (for-each make-file-writable (find-files (assoc-ref outputs "out")))
-               #t)))))
+           ;; Files are test fixtures, not generated.
+           (delete 'reset-gzip-timestamps))))
       (home-page "https://github.com/alcortesm/tgz/")
       (synopsis "Go library to extract tgz files to temporal directories")
       (description "This package provides a Go library to extract tgz files to

base-commit: a640ee7da3311e4fa560c7163d2dd7d24a25585a
-- 
2.33.0





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#50688: [PATCH] gnu: go-github-com-alcortesm-tgz: Don't reset gzip timestamps.
  2021-09-19 23:32 [bug#50688] [PATCH] gnu: go-github-com-alcortesm-tgz: Don't reset gzip timestamps Sarah Morgensen
@ 2021-12-08 18:37 ` Leo Famulari
  0 siblings, 0 replies; 2+ messages in thread
From: Leo Famulari @ 2021-12-08 18:37 UTC (permalink / raw)
  To: Sarah Morgensen; +Cc: 50688-done

On Sun, Sep 19, 2021 at 04:32:13PM -0700, Sarah Morgensen wrote:
> The tgz files are committed test fixtures, so don't reset their timestamps.
> 
> * gnu/packages/golang.scm (go-github-com-alcortesm-tgz)[arguments]:
> Remove 'make-git-checkout-writable' phase.  Delete
> 'reset-gzip-timestamps' phase instead.

Thanks, pushed as 8ac2d303e4e01fb5a5b22e7fd78f174e0a931afd




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-08 18:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-19 23:32 [bug#50688] [PATCH] gnu: go-github-com-alcortesm-tgz: Don't reset gzip timestamps Sarah Morgensen
2021-12-08 18:37 ` bug#50688: " Leo Famulari

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.