From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maximilian Heisinger <mail@maxheisinger.at>
Cc: 57181@debbugs.gnu.org
Subject: [bug#57181] [PATCH] gnu: maths: Add newer SAT solvers cryptominisat5 and kissat
Date: Mon, 15 Aug 2022 00:07:42 +0200 [thread overview]
Message-ID: <4349f97ccc76a0ee579442c3a4f50b4ba2f4f34c.camel@gmail.com> (raw)
In-Reply-To: <1840023126.104586.1660505267957@ox93.mailbox.org>
Hi,
Don't forget to CC the mailing list.
Am Sonntag, dem 14.08.2022 um 21:27 +0200 schrieb Maximilian Heisinger:
> gnu: maths: Add modern SAT solver cryptominisat5
Should simply be "gnu: Add cryptominisat5.
> + (uri (git-reference
> + (url "https://github.com/msoos/cryptominisat")
> + (commit version)
> + (recursive? #t)))
Recursive checkout doesn't really sound "mini".
>
> + (description
> + "Incremental SAT solver with four interfaces: command-line, C++
> library,
> +C interface, and Python.
I forgot this, but the description should consist of full sentences.
Also, while I (jokingly) referred to the C interface as a separate
interface, you should probably phrase this a little differently.
> gnu: maths: Add modern SAT solver kissat
As above.
> + ;; One test fails in the guix build container: "main".
> The cause
> + ;; is not clear yet and this test is not enabled in the
> tissat
> + ;; test step. Kissat (called by tissat) just does not
> finish.
> + ;; Could be an issue with kissat.
This could probably be shortened to something like "XXX: main test
fails in build container".
> + ;; Kissat has no `make install` step, so files are
> installed
> + ;; manually. This installs the (static) library, the
> header and
> + ;; the executable.
Don't comment the obvious, but more importantly, could we try to make
this a shared library?
> Kissat is a bare-metal and clean SAT-solver written in C.
I wouldn't use "and" as a joiner here. Both "clean, bare-metal SAT
solver" and "bare-metal SAT solver" sound a little cleaner 🙂️
Cheers
next prev parent reply other threads:[~2022-08-14 22:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <db92dd9dd2a11a9c6dd576e898491a96ab43dba3.camel@maxheisinger.at>
2022-08-13 20:05 ` [bug#57181] [PATCH] gnu: maths: Add newer SAT solvers cryptominisat5 and kissat Liliana Marie Prikler
[not found] ` <1840023126.104586.1660505267957@ox93.mailbox.org>
2022-08-14 22:07 ` Liliana Marie Prikler [this message]
2022-08-15 10:50 ` Maximilian Heisinger
2022-08-15 13:27 ` Liliana Marie Prikler
2022-08-17 6:26 ` mail
2022-08-17 20:16 ` Liliana Marie Prikler
2022-08-13 15:34 Maximilian Heisinger
2022-10-15 14:45 ` [bug#57181] [PATCH v2 1/4] gnu: Add aiger Liliana Marie Prikler
2022-10-15 14:45 ` [bug#57181] [PATCH v2 2/4] gnu: Add lingeling Liliana Marie Prikler
2022-10-15 14:46 ` [bug#57181] [PATCH v2 3/4] gnu: Add louvain-community Liliana Marie Prikler
2022-10-15 14:47 ` [bug#57181] [PATCH v2 4/4] gnu: Add cryptominisat Liliana Marie Prikler
2022-11-26 13:15 ` bug#57181: " Liliana Marie Prikler
2022-11-27 17:48 ` [bug#57181] " Maximilian Heisinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4349f97ccc76a0ee579442c3a4f50b4ba2f4f34c.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=57181@debbugs.gnu.org \
--cc=mail@maxheisinger.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.