From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8HlZBU1y+WI0KwAAbAwnHQ (envelope-from ) for ; Mon, 15 Aug 2022 00:08:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id COdbBU1y+WIANQAA9RJhRA (envelope-from ) for ; Mon, 15 Aug 2022 00:08:13 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6F9AF912A for ; Mon, 15 Aug 2022 00:08:12 +0200 (CEST) Received: from localhost ([::1]:57370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNLmF-0004cr-Kk for larch@yhetil.org; Sun, 14 Aug 2022 18:08:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNLm6-0004cE-Qv for guix-patches@gnu.org; Sun, 14 Aug 2022 18:08:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50279) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNLm6-0007cj-IT for guix-patches@gnu.org; Sun, 14 Aug 2022 18:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oNLm6-0005mC-Dt for guix-patches@gnu.org; Sun, 14 Aug 2022 18:08:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57181] [PATCH] gnu: maths: Add newer SAT solvers cryptominisat5 and kissat Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 14 Aug 2022 22:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57181 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maximilian Heisinger Cc: 57181@debbugs.gnu.org Received: via spool by 57181-submit@debbugs.gnu.org id=B57181.166051487222180 (code B ref 57181); Sun, 14 Aug 2022 22:08:02 +0000 Received: (at 57181) by debbugs.gnu.org; 14 Aug 2022 22:07:52 +0000 Received: from localhost ([127.0.0.1]:40027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNLlw-0005lf-1W for submit@debbugs.gnu.org; Sun, 14 Aug 2022 18:07:52 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:44929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNLlt-0005lT-V8 for 57181@debbugs.gnu.org; Sun, 14 Aug 2022 18:07:51 -0400 Received: by mail-ed1-f65.google.com with SMTP id t5so7544830edc.11 for <57181@debbugs.gnu.org>; Sun, 14 Aug 2022 15:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc; bh=nAzUO8eY9MVBESB//nCEWGl4k5hAwnjv2UWwOZUpR4k=; b=hKYvIPlBa/Dw7L8I2Mg1lq4l2ECmuWWNWCyiGpPMEw04R1eH2HKczCR407w/0iyy7m k6AaAElXDArt51vxdcLBMGLNF3vd4XD+vIz+R8Nre8+kmipbYURqPaPRuGesj4Tmp1tu 9vXWZwEY3y6FtVPfNmPEkvRhveezeBM/bwxIAgxLcYk+DHMKDzhbnESjYN/+EdouwKd6 T8lB9ytJKUfBNOLGcZlFDA5XJHkcQs1PjiEsuU68iemnGq1egJi7MZ8h/3Ofz+TbPZ3/ Wkqjy4BAMEd/OyOncVCl+4N0r7pPH22wgnCyZeKYmCfPpOVwWtwIAgRXzoETMLYb+KM2 AFsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc; bh=nAzUO8eY9MVBESB//nCEWGl4k5hAwnjv2UWwOZUpR4k=; b=QQdZp0ZxwQ4vhNn/S9/m/YF8C5uFCQZbZOmQGEXSYskNNd+mxTT1K/ke4Os5T+qXGW JmmjMaQf12LCTF9A3QjLvUaEH2QFHs7BePLzipGy7NSS85nsX6wpWbOb7P1wyU602k56 WPEAnFEif+UO1XWOqBqcSYm0SjsJ/f+H+O3PCy0QYH4DlCQASbTq3DrAs0cIvISBXLHd PuBuBrT22SaPUrNR6Mw0oWcs6UQipRMhQOPHLi2U14w2bkNhNUGSeqRYMXy5KVdypMSr HmUp1tnGlLzKWYKMsmpw1464Q7KefMju/6LyVzlf2D39C8ZcrkTap+fSrUxwZlr/hTwL BIOg== X-Gm-Message-State: ACgBeo1zatjpC3/D6YgGbsRbDc2bAcsSoC+Z1IAknzsv2U14fpQuYMrH TsJ6BMLEe5oGM6afVKsc0c8= X-Google-Smtp-Source: AA6agR7doXE4Qy3zufpCrg80NLmGkypyUDnipBGQX1N4PVofVLKIs84usocoZdHaX6fHWnlyRsiGfg== X-Received: by 2002:a05:6402:26cb:b0:43e:6fab:11c6 with SMTP id x11-20020a05640226cb00b0043e6fab11c6mr11471576edd.272.1660514864202; Sun, 14 Aug 2022 15:07:44 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id n18-20020aa7c452000000b0043ba437fe04sm5472328edr.78.2022.08.14.15.07.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Aug 2022 15:07:43 -0700 (PDT) Message-ID: <4349f97ccc76a0ee579442c3a4f50b4ba2f4f34c.camel@gmail.com> From: Liliana Marie Prikler Date: Mon, 15 Aug 2022 00:07:42 +0200 In-Reply-To: <1840023126.104586.1660505267957@ox93.mailbox.org> References: <1dbd4bac9403ed4dd17de75dfc2d210daf2d2ea3.camel@gmail.com> <1840023126.104586.1660505267957@ox93.mailbox.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660514892; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=nAzUO8eY9MVBESB//nCEWGl4k5hAwnjv2UWwOZUpR4k=; b=BF41dwJaROaNwCJAaPD74vQvzd4e2yJrpUoDJZTtmKuVj19uF7XcCSFqK1nJFr1ezSbbup RqSd49GJ132qJvIXNwZ/QEzWL+tefdT2UMEDPH2SqOwyEgqe7PNqOWPYxpss3oA5XWkW96 m9QA5w929tozCAuC9cELxcsqe613X0OmDb8St5fU8b3M28XF6uewcyNPL10R3VvJ2S0APh W6c1xuTkixyGRM/Qq4hEEWPxRYjRDMWiK5NK9HyxMcByTbTiA81/XtKjLXp17192r7hzIg A1cu+11KYjqoRJ7x3pqtzh4/unmEadDkAd+TVvJxkUFL8Gn7Jz3PZqSN4ZvAMQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660514892; a=rsa-sha256; cv=none; b=QSQgEG4ZTE4RuC8QRlBDmEdZ9olHpUYZZSjvkc+6pwukqB2AVhOZBZGjlDOHZvZkPoHg32 RJQQRDLFtaCFZjKaGGx++RU8CaqGKDDlwbVnOUOs8ii+iAKd5YQ7LEAC3rc5+8yc7n/kvu +/MbUY+aOlNEuYrIe4wH7ES/qmIT716Jjaci8ATlYPo7WZacJHO5l2xpp6Ijkn517NS6j2 WSjSovExIYIdC8knozWpHpCOq5PNvXvK8BQdPw1UVCQLkuIrlMCLVnoogkC3919nM69Gmv cmU7MaC1VfQbEJ46hhjMvhPpNMSnnVIfDeiIYictQ9fwpvmXiDBussCfg3k1AQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=hKYvIPlB; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.14 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=hKYvIPlB; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6F9AF912A X-Spam-Score: 6.14 X-Migadu-Scanner: scn1.migadu.com X-TUID: I84brzrllUuj Hi, Don't forget to CC the mailing list. Am Sonntag, dem 14.08.2022 um 21:27 +0200 schrieb Maximilian Heisinger: > gnu: maths: Add modern SAT solver cryptominisat5 Should simply be "gnu: Add cryptominisat5. > + (uri (git-reference > + (url "https://github.com/msoos/cryptominisat") > + (commit version) > + (recursive? #t))) Recursive checkout doesn't really sound "mini". > > + (description > + "Incremental SAT solver with four interfaces: command-line, C++ > library, > +C interface, and Python. I forgot this, but the description should consist of full sentences. Also, while I (jokingly) referred to the C interface as a separate interface, you should probably phrase this a little differently. > gnu: maths: Add modern SAT solver kissat As above. > + ;; One test fails in the guix build container: "main". > The cause > + ;; is not clear yet and this test is not enabled in the > tissat > + ;; test step. Kissat (called by tissat) just does not > finish. > + ;; Could be an issue with kissat. This could probably be shortened to something like "XXX: main test fails in build container". > + ;; Kissat has no `make install` step, so files are > installed > + ;; manually. This installs the (static) library, the > header and > + ;; the executable. Don't comment the obvious, but more importantly, could we try to make this a shared library? > Kissat is a bare-metal and clean SAT-solver written in C. I wouldn't use "and" as a joiner here. Both "clean, bare-metal SAT solver" and "bare-metal SAT solver" sound a little cleaner 🙂️ Cheers