* [bug#40546] gnu: xfce.scm: Sort module imports.
@ 2020-04-10 19:57 Naga Malleswari
[not found] ` <handler.40546.B.15865486815503.ack@debbugs.gnu.org>
0 siblings, 1 reply; 3+ messages in thread
From: Naga Malleswari @ 2020-04-10 19:57 UTC (permalink / raw)
To: 40546, dannym; +Cc: Gábor Boskovits
[-- Attachment #1: Type: text/plain, Size: 245 bytes --]
Submitting patch for sorting module imports. While trying to experiment
on packages i found unordered module imports. I looked into various
modules which seems structured. Hence made the change and submitting for
review.
--
Regards
NagaMalli
[-- Attachment #2: 0001-gnu-xfce.scm-Sort-module-imports.patch --]
[-- Type: text/x-patch, Size: 2955 bytes --]
From 1a01e7b35d585443c1d16a6952c4d36846f9c352 Mon Sep 17 00:00:00 2001
From: Naga Malleswari <nagamalli@riseup.net>
Date: Sat, 11 Apr 2020 01:23:03 +0530
Subject: [PATCH] gnu: xfce.scm: Sort module imports.
* gnu/packages/xfce.scm: Sort module imports.
---
gnu/packages/xfce.scm | 44 +++++++++++++++++++++----------------------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index ae2f0f2dab..a8062a4ca3 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -30,43 +30,43 @@
;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>.
(define-module (gnu packages xfce)
- #:use-module ((guix licenses) #:hide (freetype))
- #:use-module (guix packages)
- #:use-module (guix download)
- #:use-module (guix gexp)
- #:use-module (guix utils)
- #:use-module (guix build-system cmake)
- #:use-module (guix build-system glib-or-gtk)
- #:use-module (guix build-system gnu)
- #:use-module (guix build-system trivial)
#:use-module (gnu artwork)
#:use-module (gnu packages)
#:use-module (gnu packages base)
#:use-module (gnu packages calendar)
#:use-module (gnu packages cdrom)
- #:use-module (gnu packages pkg-config)
- #:use-module (gnu packages glib)
- #:use-module (gnu packages gtk)
- #:use-module (gnu packages imagemagick)
- #:use-module (gnu packages inkscape)
- #:use-module (gnu packages xorg)
- #:use-module (gnu packages xdisorg)
- #:use-module (gnu packages web)
#:use-module (gnu packages fontutils)
#:use-module (gnu packages freedesktop)
- #:use-module (gnu packages image)
+ #:use-module (gnu packages glib)
#:use-module (gnu packages gnome)
- #:use-module (gnu packages pdf)
- #:use-module (gnu packages polkit)
#:use-module (gnu packages gstreamer)
+ #:use-module (gnu packages gtk)
+ #:use-module (gnu packages image)
+ #:use-module (gnu packages imagemagick)
+ #:use-module (gnu packages inkscape)
#:use-module (gnu packages libcanberra)
#:use-module (gnu packages linux)
- #:use-module (gnu packages photo)
#:use-module (gnu packages pcre)
+ #:use-module (gnu packages pdf)
+ #:use-module (gnu packages photo)
+ #:use-module (gnu packages pkg-config)
+ #:use-module (gnu packages polkit)
#:use-module (gnu packages popt)
#:use-module (gnu packages pulseaudio)
+ #:use-module (gnu packages web)
+ #:use-module (gnu packages wm)
#:use-module (gnu packages xml)
- #:use-module (gnu packages wm))
+ #:use-module (gnu packages xdisorg)
+ #:use-module (gnu packages xorg)
+ #:use-module (guix build-system cmake)
+ #:use-module (guix build-system glib-or-gtk)
+ #:use-module (guix build-system gnu)
+ #:use-module (guix build-system trivial)
+ #:use-module (guix download)
+ #:use-module (guix gexp)
+ #:use-module ((guix licenses) #:hide (freetype))
+ #:use-module (guix packages)
+ #:use-module (guix utils))
(define-public gtk-xfce-engine
(package
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#40546] Acknowledgement (gnu: xfce.scm: Sort module imports.)
[not found] ` <handler.40546.B.15865486815503.ack@debbugs.gnu.org>
@ 2020-04-19 18:50 ` Naga Malleswari
2020-04-20 19:33 ` bug#40546: " Danny Milosavljevic
0 siblings, 1 reply; 3+ messages in thread
From: Naga Malleswari @ 2020-04-19 18:50 UTC (permalink / raw)
To: 40546, Danny Milosavljevic
Can you please review this patch
On 11/04/20 1:28 am, GNU bug Tracking System wrote:
> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
> guix-patches@gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 40546@debbugs.gnu.org.
>
> Please do not send mail to help-debbugs@gnu.org unless you wish
> to report a problem with the Bug-tracking system.
>
--
Regards
NagaMalli
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#40546: Acknowledgement (gnu: xfce.scm: Sort module imports.)
2020-04-19 18:50 ` [bug#40546] Acknowledgement (gnu: xfce.scm: Sort module imports.) Naga Malleswari
@ 2020-04-20 19:33 ` Danny Milosavljevic
0 siblings, 0 replies; 3+ messages in thread
From: Danny Milosavljevic @ 2020-04-20 19:33 UTC (permalink / raw)
To: Naga Malleswari; +Cc: 40546-done
[-- Attachment #1: Type: text/plain, Size: 114 bytes --]
Hi Naga,
thanks for the patch!
Pushed to guix master as commit 2eac967ab7e56b53d936d6ac398de7e0a073dcf2.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-20 19:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-10 19:57 [bug#40546] gnu: xfce.scm: Sort module imports Naga Malleswari
[not found] ` <handler.40546.B.15865486815503.ack@debbugs.gnu.org>
2020-04-19 18:50 ` [bug#40546] Acknowledgement (gnu: xfce.scm: Sort module imports.) Naga Malleswari
2020-04-20 19:33 ` bug#40546: " Danny Milosavljevic
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.