[bug#38120] [PATCH] gnu: Add geonkick.

[bug#38120] [PATCH] gnu: Add geonkick.

[Alexandros Theodotou]

 From 09c3a68bfd70d80984a5956fad0596bb7c3e07ac Mon Sep 17 00:00:00 2001
 From: Alexandros Theodotou <alex@zrythm.org>
Date: Fri, 8 Nov 2019 10:11:50 +0000
Subject: [PATCH] gnu: Add geonkick.

* gnu/packages/music.scm: (geonkick): New variable.
---
  gnu/packages/music.scm | 40 ++++++++++++++++++++++++++++++++++++++++
  1 file changed, 40 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index a30765e87f..eae05499a1 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -24,6 +24,7 @@
  ;;; Copyright © 2019 Jakob L. Kreuze <zerodaysfordays@sdf.lonestar.org>
  ;;; Copyright © 2019 raingloom <raingloom@protonmail.com>
  ;;; Copyright © 2019 David Wilson <david@daviwil.com>
+;;; Copyright © 2019 Alexandros Theodotou <alex@zrythm.org>
  ;;;
  ;;; This file is part of GNU Guix.
  ;;;
@@ -4699,3 +4700,42 @@ You can also get metadata about the playing track 
such as the artist and title
  for integration into status line generators or other command-line 
tools.")
      (home-page "https://github.com/altdesktop/playerctl")
      (license license:lgpl3+)))
+
+(define-public geonkick
+  (package
+    (name "geonkick")
+    (version "1.9.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append 
"https://gitlab.com/iurie/geonkick/-/archive/v"
+                            version "/geonkick-v" version ".tar.gz"))
+        (sha256
+          (base32
+            "0wp8w5q69c1nrcc4qkcg0slakkpzp9ngw25iih8zhcl4hrjv42fd"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f ; no tests included
+       #:configure-flags
+       (list (string-append "-DGKICK_REDKITE_SDK_PATH="
+                            (assoc-ref %build-inputs "redkite"))
+             (string-append "-DCMAKE_INSTALL_PREFIX="
+                            (assoc-ref %outputs "out")))))
+    (inputs
+     `(("cairo" ,cairo)
+       ("hicolor-icon-theme" ,hicolor-icon-theme)
+       ("jack", jack-1) ; for the standalone
+       ("libsndfile", libsndfile)
+       ("libx11", libx11)))
+    (native-inputs
+     `(("lv2", lv2)
+       ("pkg-config", pkg-config)
+       ("sord", sord)
+       ("rapidjson", rapidjson)
+       ("redkite", redkite)))
+    (synopsis "Percussion synthesizer")
+    (description "Geonkick is a synthesizer that can synthesize 
elements of
+percussion such as kicks, snares, hit-hats, shakers, claps and sticks. 
It can
+also play and mix samples.")
+    (home-page "https://gitlab.com/iurie/geonkick")
+    (license license:gpl3+)))
-- 
2.24.0

[bug#38120] [PATCH] gnu: Add geonkick.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

Alexandros Theodotou <alex@zrythm.org> writes:

>  From 09c3a68bfd70d80984a5956fad0596bb7c3e07ac Mon Sep 17 00:00:00 2001
>  From: Alexandros Theodotou <alex@zrythm.org>
> Date: Fri, 8 Nov 2019 10:11:50 +0000
> Subject: [PATCH] gnu: Add geonkick.
>
> * gnu/packages/music.scm: (geonkick): New variable.

[...]

> +       ("jack", jack-1) ; for the standalone

Standalone what?  :-)

Otherwise LGTM modulo indentation issues.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[bug#38120] [PATCH] gnu: Add geonkick.

[Alexandros Theodotou]

[-- Attachment #1: Type: text/plain, Size: 9 bytes --]

Updated

[-- Attachment #2: 0001-gnu-Add-geonkick.patch --]
[-- Type: text/x-patch, Size: 2186 bytes --]

From 98c080f2f27d9f7a99dd635948dc062bde75ed1c Mon Sep 17 00:00:00 2001
From: Alexandros Theodotou <alex@zrythm.org>
Date: Fri, 8 Nov 2019 10:11:50 +0000
Subject: [PATCH] gnu: Add geonkick.

* gnu/packages/music.scm: (geonkick): New variable.
---
 gnu/packages/music.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 2f023685df..2c317db219 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -4737,3 +4737,42 @@ for integration into status line generators or other command-line tools.")
 effects.  It contains a bitcrusher, delay, distortion, equalizer, compressor,
 and reverb.")
     (license license:gpl2+)))
+
+(define-public geonkick
+  (package
+    (name "geonkick")
+    (version "1.9.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "https://gitlab.com/iurie/geonkick/-/archive/v"
+                            version "/geonkick-v" version ".tar.gz"))
+        (sha256
+          (base32
+            "0wp8w5q69c1nrcc4qkcg0slakkpzp9ngw25iih8zhcl4hrjv42fd"))))
+    (build-system cmake-build-system)
+    (arguments
+     `(#:tests? #f ; no tests included
+       #:configure-flags
+       (list (string-append "-DGKICK_REDKITE_SDK_PATH="
+                            (assoc-ref %build-inputs "redkite"))
+             (string-append "-DCMAKE_INSTALL_PREFIX="
+                            (assoc-ref %outputs "out")))))
+    (inputs
+     `(("cairo" ,cairo)
+       ("hicolor-icon-theme" ,hicolor-icon-theme)
+       ("jack" ,jack-1) ; for the standalone JACK application
+       ("libsndfile" ,libsndfile)
+       ("libx11" ,libx11)))
+    (native-inputs
+     `(("lv2" ,lv2)
+       ("pkg-config" ,pkg-config)
+       ("sord" ,sord)
+       ("rapidjson" ,rapidjson)
+       ("redkite" ,redkite)))
+    (synopsis "Percussion synthesizer")
+    (description "Geonkick is a synthesizer that can synthesize elements of
+percussion such as kicks, snares, hit-hats, shakers, claps and sticks. It can
+also play and mix samples.")
+    (home-page "https://gitlab.com/iurie/geonkick")
+    (license license:gpl3+)))
-- 
2.24.0

bug#38120: [PATCH] gnu: Add geonkick.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1738 bytes --]

Alexandros Theodotou <alex@zrythm.org> writes:

> From 98c080f2f27d9f7a99dd635948dc062bde75ed1c Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <alex@zrythm.org>
> Date: Fri, 8 Nov 2019 10:11:50 +0000
> Subject: [PATCH] gnu: Add geonkick.
>
> * gnu/packages/music.scm: (geonkick): New variable.

[...]

> +(define-public geonkick
> +  (package
> +    (name "geonkick")
> +    (version "1.9.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "https://gitlab.com/iurie/geonkick/-/archive/v"
> +                            version "/geonkick-v" version ".tar.gz"))
> +        (sha256
> +          (base32
> +            "0wp8w5q69c1nrcc4qkcg0slakkpzp9ngw25iih8zhcl4hrjv42fd"))))

As with redkite, I followed the redirect and changed to a git checkout.

> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:tests? #f ; no tests included
> +       #:configure-flags
> +       (list (string-append "-DGKICK_REDKITE_SDK_PATH="
> +                            (assoc-ref %build-inputs "redkite"))
> +             (string-append "-DCMAKE_INSTALL_PREFIX="
> +                            (assoc-ref %outputs "out")))))
> +    (inputs
> +     `(("cairo" ,cairo)
> +       ("hicolor-icon-theme" ,hicolor-icon-theme)
> +       ("jack" ,jack-1) ; for the standalone JACK application
> +       ("libsndfile" ,libsndfile)
> +       ("libx11" ,libx11)))
> +    (native-inputs
> +     `(("lv2" ,lv2)
> +       ("pkg-config" ,pkg-config)
> +       ("sord" ,sord)
> +       ("rapidjson" ,rapidjson)
> +       ("redkite" ,redkite)))

I moved rapidjson and redkite to inputs, because the package embeds
their static libraries, so the architecture has to match when
cross-compiling.

Applied!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]