all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Skyler Ferris via Guix-patches via <guix-patches@gnu.org>
To: "Paul A. Patience" <paul@apatience.com>, 69126@debbugs.gnu.org
Subject: [bug#69126] [PATCH 2/2] gnu: Add type-safe.
Date: Wed, 14 Feb 2024 21:30:57 +0000	[thread overview]
Message-ID: <3463adf6-964b-4b52-a554-4575e5d8d237@protonmail.com> (raw)
In-Reply-To: <b2d423449b6ce9964ea0ea8218528fd9fa12486e.1707924715.git.paul@apatience.com>

Things needing attention:

When I tried to compile a file which included `type_safe/integer.hpp` 
from a container (see below for exact commands & source), I got an error 
that the debug_assert header could not be found. I resolved this by 
changing the debug-assert package from a normal input into a propagated 
input, but there could be other ways to solve this.

main.cpp
```
#include <type_safe/integer.hpp>

int main(void) {
     type_safe::integer<int> tsi(1);
     return tsi.get();
}
```

```
$ ./pre-inst-env guix shell gcc-toolchain type-safe -C -- g++ -std=c++11 
main.cpp
<error indicating that debug_assert.hpp was not found>
```

More details:

This diff applies cleanly to commit 
ac470c516e19f194228edf9e348bdbc7fc10f97a, after applying the previous 
commit in this series.

As with the review on the previous patch, notes about confidence in 
source integrity are provided as an indication of attention and to 
provide transparency. The commit tagged v0.2.3 does not have a signature 
on it, but the commit 3 steps prior has a good signature. It uses the 
same signing key as debug-assert, so all of the notes from there apply 
here as well.

`./pre-inst-env guix build type-safe` succeeded on my machine, an x86_64 
Xen guest. Additionally, after fixing the issue noted in the "Things 
needing attention" section, the following test file produced an expected 
compiler error indicating that the type_safe::integer needs an initial 
value.

main.cpp
```
#include <type_safe/integer.hpp>

int main(void) {
     type_safe::integer<int> tsi;
     return tsi.get();
}
```

Once I added an initial value as shown in the "Things needing attention" 
section, the file built successfully and the executable returned the 
expected exit code.

```
$ ./pre-inst-env guix shell gcc-toolchain type-safe -C -- g++ -std=c++11 
main.cpp
$ ./a.out
$ echo $?
1
```

The license file in the project matches the contents I see at 
https://directory.fsf.org/wiki/License:Expat.






  reply	other threads:[~2024-02-14 21:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-14 15:33 [bug#69126] [PATCH 0/2] gnu: Add type-safe Paul A. Patience
2024-02-14 15:36 ` [bug#69126] [PATCH 1/2] gnu: Add debug-assert Paul A. Patience
2024-02-14 21:29   ` Skyler Ferris via Guix-patches via
2024-02-15 14:02     ` Paul A. Patience
2024-02-14 15:36 ` [bug#69126] [PATCH 2/2] gnu: Add type-safe Paul A. Patience
2024-02-14 21:30   ` Skyler Ferris via Guix-patches via [this message]
2024-02-15 14:23     ` Paul A. Patience
2024-02-14 21:27 ` [bug#69126] [PATCH 0/2] " Skyler Ferris via Guix-patches via
2024-02-15 14:25 ` [bug#69126] [PATCH v2] " Paul A. Patience
2024-02-17  8:43   ` Liliana Marie Prikler
2024-02-20 19:33 ` [bug#69126] [PATCH v3 0/2] " Paul A. Patience
2024-02-20 19:33   ` [bug#69126] [PATCH v3 1/2] gnu: Add debug-assert Paul A. Patience
2024-02-20 19:33   ` [bug#69126] [PATCH v3 2/2] gnu: Add type-safe Paul A. Patience

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3463adf6-964b-4b52-a554-4575e5d8d237@protonmail.com \
    --to=guix-patches@gnu.org \
    --cc=69126@debbugs.gnu.org \
    --cc=paul@apatience.com \
    --cc=skyvine@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.