From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id GN2sJkYxzWUEOAEA62LTzQ:P1 (envelope-from ) for ; Wed, 14 Feb 2024 22:31:50 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id GN2sJkYxzWUEOAEA62LTzQ (envelope-from ) for ; Wed, 14 Feb 2024 22:31:50 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=L+PSb1wA; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707946310; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=+kGYfODXV6slpFzdno6Y8Qn5zehKAlKxYuDwaVRG6SQ=; b=MFaLmEpDN7obCfcmPfRnMDR+LRLDKvkmLTJj76FqufNxMIyadr8+6V69Y2wLhUCectZP6l qLldzoHDP34fFCghw2LMCdSfl2Q1voM1nhw/fXjEL8/ZBUFUEGQa5e5MaeKWY8ud+a7z0E esLn9Ik1kFGZKfzAqSl7JlXwmEQWBo4aeZh2j5iPAt/zydZd3RNOss4+y2Oxt/Q4y4DzWN 7a5fKUHyWxwySlvRnUVdceiKaVBdxzIO5XRmr8YutGHiIP5JAwDu4RNnHvEj5BRGtTcazB yGQp0dzgKTAsBX6ksBFG3VZlng5CLJOQUw4cVM41FzbTUaC5pQ0WAinX7ZPTXA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=L+PSb1wA; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707946310; a=rsa-sha256; cv=none; b=uPU4rOOkYIdwab56L74+mdnGi1BlbijzAGIVsaCJrWxMyEkyT9oEpmNVJ7t13x7eDBtZcr 41iZB3CoVspCd0OSVKFRhD+WQcW74PTVAxf0C7VX+jjtLk+z4s9E6PHXVsVaj/ed+jvNb0 rc3d58x8L1b2MEgi6josRlKXnzfAwOS8Acw1oZWsH36h7kxVjQcQiGxWauIt/f+TW97JPC 5Yima+7SmfgJx/rsbOeyfs6HPNR5AS/Yp3Y/H+X17mFcVSY5fVLpw9ShC3mEl5o83pRTbU 8SlYNBTv2hNA5igkzUP4rxnlT8Szpew8r5bmPd69z7KE96Prulxjr7m5AS+aow== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8009A14D9D for ; Wed, 14 Feb 2024 22:31:50 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1raMr4-0006EK-7G; Wed, 14 Feb 2024 16:31:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raMr2-0006E7-CS for guix-patches@gnu.org; Wed, 14 Feb 2024 16:31:44 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1raMr2-0004L9-3v for guix-patches@gnu.org; Wed, 14 Feb 2024 16:31:44 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1raMrK-0004ev-Al for guix-patches@gnu.org; Wed, 14 Feb 2024 16:32:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69126] [PATCH 2/2] gnu: Add type-safe. Resent-From: Skyler Ferris Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Feb 2024 21:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69126 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Paul A. Patience" , 69126@debbugs.gnu.org Received: via spool by 69126-submit@debbugs.gnu.org id=B69126.170794629717880 (code B ref 69126); Wed, 14 Feb 2024 21:32:02 +0000 Received: (at 69126) by debbugs.gnu.org; 14 Feb 2024 21:31:37 +0000 Received: from localhost ([127.0.0.1]:53453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raMqu-0004eJ-MI for submit@debbugs.gnu.org; Wed, 14 Feb 2024 16:31:37 -0500 Received: from mail-4322.protonmail.ch ([185.70.43.22]:50719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raMqs-0004e4-Va for 69126@debbugs.gnu.org; Wed, 14 Feb 2024 16:31:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1707946270; x=1708205470; bh=+kGYfODXV6slpFzdno6Y8Qn5zehKAlKxYuDwaVRG6SQ=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=L+PSb1wANxH+ShecgF34CP081TC30aVhO5IK2SUdgOlFanEcGBpCEiw08JBX2uqf4 0a5QehWZ8+r2W8n3sMX5CssnbPuScLScgmSPVdnEePgdjMcRN3wT3qbXI6diloULkp rRN98tGtVDG5KLG5sCzzJjJdLNLo/8ZkPFumclUJAZg0wuCQ6rn9xAMHdu3hCsVHx6 DIL+xQmNP4xs4PIE1PI591hfvrJHWg18DTUFNla2B1OeXQ0wfkgKA/tStnJ3WhWYbI 6zMyDzXfM8qCMpxUopRdI4Vy503VQu+64JqwRk1PYPpM/G4uaA6YrcBRclGIM9kw86 aLrCsHCkJKxkA== Date: Wed, 14 Feb 2024 21:30:57 +0000 Message-ID: <3463adf6-964b-4b52-a554-4575e5d8d237@protonmail.com> In-Reply-To: References: Feedback-ID: 40635331:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Skyler Ferris X-ACL-Warn: , Skyler Ferris via Guix-patches From: Skyler Ferris via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.97 X-Spam-Score: -6.97 X-Migadu-Queue-Id: 8009A14D9D X-Migadu-Scanner: mx13.migadu.com X-TUID: 7siHspVF0qy+ Things needing attention: When I tried to compile a file which included `type_safe/integer.hpp`=20 from a container (see below for exact commands & source), I got an error=20 that the debug_assert header could not be found. I resolved this by=20 changing the debug-assert package from a normal input into a propagated=20 input, but there could be other ways to solve this. main.cpp ``` #include int main(void) { =C2=A0=C2=A0 =C2=A0type_safe::integer tsi(1); =C2=A0=C2=A0 =C2=A0return tsi.get(); } ``` ``` $ ./pre-inst-env guix shell gcc-toolchain type-safe -C -- g++ -std=3Dc++11= =20 main.cpp ``` More details: This diff applies cleanly to commit=20 ac470c516e19f194228edf9e348bdbc7fc10f97a, after applying the previous=20 commit in this series. As with the review on the previous patch, notes about confidence in=20 source integrity are provided as an indication of attention and to=20 provide transparency. The commit tagged v0.2.3 does not have a signature=20 on it, but the commit 3 steps prior has a good signature. It uses the=20 same signing key as debug-assert, so all of the notes from there apply=20 here as well. `./pre-inst-env guix build type-safe` succeeded on my machine, an x86_64=20 Xen guest. Additionally, after fixing the issue noted in the "Things=20 needing attention" section, the following test file produced an expected=20 compiler error indicating that the type_safe::integer needs an initial=20 value. main.cpp ``` #include int main(void) { =C2=A0=C2=A0 =C2=A0type_safe::integer tsi; =C2=A0=C2=A0 =C2=A0return tsi.get(); } ``` Once I added an initial value as shown in the "Things needing attention"=20 section, the file built successfully and the executable returned the=20 expected exit code. ``` $ ./pre-inst-env guix shell gcc-toolchain type-safe -C -- g++ -std=3Dc++11= =20 main.cpp $ ./a.out $ echo $? 1 ``` The license file in the project matches the contents I see at=20 https://directory.fsf.org/wiki/License:Expat.