* [bug#46832] [PATCH] import: hackage: Accept optional version paramter.
@ 2021-02-28 16:16 Xinglu Chen
2021-02-28 16:18 ` [bug#46833] [PATCH v2] import: hackage: Accept optional version parameter Xinglu Chen
0 siblings, 1 reply; 3+ messages in thread
From: Xinglu Chen @ 2021-02-28 16:16 UTC (permalink / raw)
To: 46832
* guix/import/hackage.scm (hackage-recursive-import): Add the VERSION key.
Make REPO a key.
---
Looks like Martin forgot to update the Hackage importer in commit
bea3b17739fc591b8cf6db1f8d28a6f6c9585577.
guix/import/hackage.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/guix/import/hackage.scm b/guix/import/hackage.scm
index 6ca4f65cb0..9f992ffe8e 100644
--- a/guix/import/hackage.scm
+++ b/guix/import/hackage.scm
@@ -344,8 +344,8 @@ respectively."
(memoize hackage->guix-package))
(define* (hackage-recursive-import package-name . args)
- (recursive-import package-name #f
- #:repo->guix-package (lambda (name repo)
+ (recursive-import package-name
+ #:repo->guix-package (lambda* (name #:key repo version)
(apply hackage->guix-package/m
(cons name args)))
#:guix-name hackage-name->package-name))
--
2.30.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#46833] [PATCH v2] import: hackage: Accept optional version parameter.
2021-02-28 16:16 [bug#46832] [PATCH] import: hackage: Accept optional version paramter Xinglu Chen
@ 2021-02-28 16:18 ` Xinglu Chen
2021-03-01 16:02 ` bug#46833: " Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Xinglu Chen @ 2021-02-28 16:18 UTC (permalink / raw)
To: 46833
* guix/import/hackage.scm (hackage-recursive-import): Add the VERSION key.
Make REPO a key.
---
Ugh, made a typo in the commit summary.
guix/import/hackage.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/guix/import/hackage.scm b/guix/import/hackage.scm
index 6ca4f65cb0..9f992ffe8e 100644
--- a/guix/import/hackage.scm
+++ b/guix/import/hackage.scm
@@ -344,8 +344,8 @@ respectively."
(memoize hackage->guix-package))
(define* (hackage-recursive-import package-name . args)
- (recursive-import package-name #f
- #:repo->guix-package (lambda (name repo)
+ (recursive-import package-name
+ #:repo->guix-package (lambda* (name #:key repo version)
(apply hackage->guix-package/m
(cons name args)))
#:guix-name hackage-name->package-name))
--
2.30.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#46833: [PATCH v2] import: hackage: Accept optional version parameter.
2021-02-28 16:18 ` [bug#46833] [PATCH v2] import: hackage: Accept optional version parameter Xinglu Chen
@ 2021-03-01 16:02 ` Ludovic Courtès
0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2021-03-01 16:02 UTC (permalink / raw)
To: Xinglu Chen; +Cc: 46833-done
Hi,
Xinglu Chen <public@yoctocell.xyz> skribis:
> * guix/import/hackage.scm (hackage-recursive-import): Add the VERSION key.
> Make REPO a key.
Applied, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-01 16:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-28 16:16 [bug#46832] [PATCH] import: hackage: Accept optional version paramter Xinglu Chen
2021-02-28 16:18 ` [bug#46833] [PATCH v2] import: hackage: Accept optional version parameter Xinglu Chen
2021-03-01 16:02 ` bug#46833: " Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.