* [bug#62653] [PATCH] gnu: emacs-eat: Patch ncurses tic executable.
@ 2023-04-03 19:49 jgart via Guix-patches via
2023-04-04 20:18 ` Nicolas Goaziou
2023-04-04 20:20 ` jgart via Guix-patches via
0 siblings, 2 replies; 3+ messages in thread
From: jgart via Guix-patches via @ 2023-04-03 19:49 UTC (permalink / raw)
To: 62653; +Cc: jgart, Nicolas Goaziou
* gnu/packages/emacs-xyz.scm (arguments): Patch tic executable.
---
Reading the code now I found that there's a function that makes a call
to tic from the ncurses package so I patched it.
all best,
jgart
gnu/packages/emacs-xyz.scm | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b4edc680ba..9db8a07331 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27981,7 +27981,14 @@ (define-public emacs-eat
(invoke "make" "info")))
(add-before 'install 'build-terminfo-database
(lambda _
- (invoke "make" "terminfo"))))))
+ (invoke "make" "terminfo")))
+ (add-before 'install 'patch-ncurses-tic-executable
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute*
+ "eat.el"
+ (("\"tic")
+ (string-append "\""
+ (search-input-file inputs "/bin/tic")))))))))
(native-inputs
(list ncurses texinfo))
(home-page "https://codeberg.org/akib/emacs-eat")
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#62653] [PATCH] gnu: emacs-eat: Patch ncurses tic executable.
2023-04-03 19:49 [bug#62653] [PATCH] gnu: emacs-eat: Patch ncurses tic executable jgart via Guix-patches via
@ 2023-04-04 20:18 ` Nicolas Goaziou
2023-04-04 20:20 ` jgart via Guix-patches via
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Goaziou @ 2023-04-04 20:18 UTC (permalink / raw)
To: 62653; +Cc: 62653-done, jgart
Hello,
jgart via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/emacs-xyz.scm (arguments): Patch tic executable.
> ---
>
> Reading the code now I found that there's a function that makes a call
> to tic from the ncurses package so I patched it.
Good catch!
I also moved ncurses into inputs, otherwise the executable could
be GC'ed at some point.
Applied. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 3+ messages in thread
* [bug#62653] [PATCH] gnu: emacs-eat: Patch ncurses tic executable.
2023-04-03 19:49 [bug#62653] [PATCH] gnu: emacs-eat: Patch ncurses tic executable jgart via Guix-patches via
2023-04-04 20:18 ` Nicolas Goaziou
@ 2023-04-04 20:20 ` jgart via Guix-patches via
1 sibling, 0 replies; 3+ messages in thread
From: jgart via Guix-patches via @ 2023-04-04 20:20 UTC (permalink / raw)
To: mail, 62653; +Cc: 62653-done
> Good catch!
Thanks! And thanks for reviewing this.
> otherwise the executable could be GC'ed at some point.
TIL
thank you,
jgart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-04 20:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-03 19:49 [bug#62653] [PATCH] gnu: emacs-eat: Patch ncurses tic executable jgart via Guix-patches via
2023-04-04 20:18 ` Nicolas Goaziou
2023-04-04 20:20 ` jgart via Guix-patches via
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.