* [bug#62629] [PATCH] gnu: guile-pipe: Remove unused install script.
@ 2023-04-02 20:03 jgart via Guix-patches via
2023-05-12 18:52 ` Josselin Poiret via Guix-patches via
2023-05-12 21:18 ` jgart via Guix-patches via
0 siblings, 2 replies; 4+ messages in thread
From: jgart via Guix-patches via @ 2023-04-02 20:03 UTC (permalink / raw)
To: 62629; +Cc: jgart
* gnu/packages/guile-xyz.scm (guile-pipe): Remove script.
---
gnu/packages/guile-xyz.scm | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index fd8fb25da1..691635e155 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -362,7 +362,10 @@ (define-public guile-pipe
(commit commit)))
(file-name (git-file-name name version))
(sha256
- (base32 "038gwrhfywgs8372q478wn4623lhcmkknfj4p8yaa93bykfc0fml"))))
+ (base32 "038gwrhfywgs8372q478wn4623lhcmkknfj4p8yaa93bykfc0fml"))
+ (modules '((guix build utils)))
+ ;; Remove unused install script.
+ (snippet '(begin (delete-file "install")))))
(build-system guile-build-system)
(native-inputs
(list guile-3.0))
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#62629] [PATCH] gnu: guile-pipe: Remove unused install script.
2023-04-02 20:03 [bug#62629] [PATCH] gnu: guile-pipe: Remove unused install script jgart via Guix-patches via
@ 2023-05-12 18:52 ` Josselin Poiret via Guix-patches via
2023-05-12 21:18 ` jgart via Guix-patches via
1 sibling, 0 replies; 4+ messages in thread
From: Josselin Poiret via Guix-patches via @ 2023-05-12 18:52 UTC (permalink / raw)
To: 62629; +Cc: jgart
[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]
Hi jgart,
jgart via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/guile-xyz.scm (guile-pipe): Remove script.
> ---
> gnu/packages/guile-xyz.scm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
> index fd8fb25da1..691635e155 100644
> --- a/gnu/packages/guile-xyz.scm
> +++ b/gnu/packages/guile-xyz.scm
> @@ -362,7 +362,10 @@ (define-public guile-pipe
> (commit commit)))
> (file-name (git-file-name name version))
> (sha256
> - (base32 "038gwrhfywgs8372q478wn4623lhcmkknfj4p8yaa93bykfc0fml"))))
> + (base32 "038gwrhfywgs8372q478wn4623lhcmkknfj4p8yaa93bykfc0fml"))
> + (modules '((guix build utils)))
> + ;; Remove unused install script.
> + (snippet '(begin (delete-file "install")))))
> (build-system guile-build-system)
> (native-inputs
> (list guile-3.0))
> --
> 2.39.2
Is this really necessary? guile-pipe builds fine without it and this
doesn't end up in the output, right?
Best,
--
Josselin Poiret
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#62629] [PATCH] gnu: guile-pipe: Remove unused install script.
2023-04-02 20:03 [bug#62629] [PATCH] gnu: guile-pipe: Remove unused install script jgart via Guix-patches via
2023-05-12 18:52 ` Josselin Poiret via Guix-patches via
@ 2023-05-12 21:18 ` jgart via Guix-patches via
2023-05-13 7:39 ` bug#62629: " Josselin Poiret via Guix-patches via
1 sibling, 1 reply; 4+ messages in thread
From: jgart via Guix-patches via @ 2023-05-12 21:18 UTC (permalink / raw)
To: dev, 62629
Hi Josselin,
I checked that it doesn't end up in the output. Yes, this is unnecessary.
I'll give a closer read to guile-build-system to remind myself of the glob patterns that it matches on for copying to the output.
Thanks for the review,
jgart
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#62629: [PATCH] gnu: guile-pipe: Remove unused install script.
2023-05-12 21:18 ` jgart via Guix-patches via
@ 2023-05-13 7:39 ` Josselin Poiret via Guix-patches via
0 siblings, 0 replies; 4+ messages in thread
From: Josselin Poiret via Guix-patches via @ 2023-05-13 7:39 UTC (permalink / raw)
To: jgart, 62629-done
[-- Attachment #1: Type: text/plain, Size: 331 bytes --]
Hi jgart,
"jgart" <jgart@dismail.de> writes:
> Hi Josselin,
>
> I checked that it doesn't end up in the output. Yes, this is unnecessary.
>
> I'll give a closer read to guile-build-system to remind myself of the glob patterns that it matches on for copying to the output.
Closing then!
Best
--
Josselin Poiret
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-13 7:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-02 20:03 [bug#62629] [PATCH] gnu: guile-pipe: Remove unused install script jgart via Guix-patches via
2023-05-12 18:52 ` Josselin Poiret via Guix-patches via
2023-05-12 21:18 ` jgart via Guix-patches via
2023-05-13 7:39 ` bug#62629: " Josselin Poiret via Guix-patches via
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.