all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#61360] [PATCH] gnu: gimp: Don't retain reference on GCC.
@ 2023-02-08  7:09 iyzsong--- via Guix-patches via
  2023-03-01  9:48 ` Christopher Baines
  0 siblings, 1 reply; 3+ messages in thread
From: iyzsong--- via Guix-patches via @ 2023-02-08  7:09 UTC (permalink / raw)
  To: 61360; +Cc: 宋文武

From: 宋文武 <iyzsong@member.fsf.org>

Partly fixes <https://issues.guix.gnu.org/57677>.

* gnu/packages/gimp.scm (gimp)[arguments]: Add #:modules and #:phases.
---
 gnu/packages/gimp.scm | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/gnu/packages/gimp.scm b/gnu/packages/gimp.scm
index beb43f0ae2..69281f98e9 100644
--- a/gnu/packages/gimp.scm
+++ b/gnu/packages/gimp.scm
@@ -302,6 +302,19 @@ (define-public gimp
                "doc"))                  ; 9 MiB of gtk-doc HTML
     (arguments
      (list
+      #:modules `((ice-9 popen)
+                  (ice-9 rdelim)
+                  ,@%gnu-build-system-modules)
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'remove-gcc-reference
+            ;; Avoid reference to GCC.
+            (lambda _
+              (let* ((port (open-input-pipe "gcc -v 2>&1 | tail -n 1"))
+                     (cc-version (read-line port)))
+                (close-pipe port)
+                (substitute* "app/gimp-version.c"
+                  (("CC_VERSION") (string-append "\"" cc-version "\"")))))))
       #:configure-flags
       #~(list (string-append "--with-html-dir=" #$output "/share/gtk-doc/html")
 
-- 
2.39.1





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#61360] [PATCH] gnu: gimp: Don't retain reference on GCC.
  2023-02-08  7:09 [bug#61360] [PATCH] gnu: gimp: Don't retain reference on GCC iyzsong--- via Guix-patches via
@ 2023-03-01  9:48 ` Christopher Baines
  2023-03-02  3:44   ` bug#61360: " 宋文武 via Guix-patches via
  0 siblings, 1 reply; 3+ messages in thread
From: Christopher Baines @ 2023-03-01  9:48 UTC (permalink / raw)
  To: iyzsong; +Cc: iyzsong, 61360

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]


iyzsong--- via Guix-patches via <guix-patches@gnu.org> writes:

> From: 宋文武 <iyzsong@member.fsf.org>
>
> Partly fixes <https://issues.guix.gnu.org/57677>.
>
> * gnu/packages/gimp.scm (gimp)[arguments]: Add #:modules and #:phases.
> ---
>  gnu/packages/gimp.scm | 13 +++++++++++++
>  1 file changed, 13 insertions(+)

I don't quite get what's going on here, but it seems good to push.

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#61360: [PATCH] gnu: gimp: Don't retain reference on GCC.
  2023-03-01  9:48 ` Christopher Baines
@ 2023-03-02  3:44   ` 宋文武 via Guix-patches via
  0 siblings, 0 replies; 3+ messages in thread
From: 宋文武 via Guix-patches via @ 2023-03-02  3:44 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 61360-done, iyzsong

Christopher Baines <mail@cbaines.net> writes:

> iyzsong--- via Guix-patches via <guix-patches@gnu.org> writes:
>
>> From: 宋文武 <iyzsong@member.fsf.org>
>>
>> Partly fixes <https://issues.guix.gnu.org/57677>.
>>
>> * gnu/packages/gimp.scm (gimp)[arguments]: Add #:modules and #:phases.
>> ---
>>  gnu/packages/gimp.scm | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>
> I don't quite get what's going on here, but it seems good to push.
>

Pushed, thank you!




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-02  3:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-08  7:09 [bug#61360] [PATCH] gnu: gimp: Don't retain reference on GCC iyzsong--- via Guix-patches via
2023-03-01  9:48 ` Christopher Baines
2023-03-02  3:44   ` bug#61360: " 宋文武 via Guix-patches via

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.