[bug#59354] [PATCH] gnu: Add texlive-mathdots.

[bug#59354] [PATCH] gnu: Add texlive-mathdots.

[Yarl Baudig]

* gnu/packages/tex.scm (texlive-mathdots): New variable.
---
 gnu/packages/tex.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm
index 81f74f17df..f901d80bf8 100644
--- a/gnu/packages/tex.scm
+++ b/gnu/packages/tex.scm
@@ -3993,6 +3993,25 @@ (define-public texlive-amsmath
 
 (define-deprecated-package texlive-latex-amsmath texlive-amsmath)
 
+(define-public texlive-mathdots
+  (package
+    (inherit (simple-texlive-package
+	      "texlive-mathdots"
+              (list "doc/generic/mathdots/"
+                    "source/generic/mathdots/"
+                    "tex/generic/mathdots/")
+              (base32
+               "1jaffj343p1chdxs2g7s6lpckvihk0jfw22nw0vmijyjxfiy9yg0")
+	      #:trivial? #t))
+   (home-page "https://ctan.org/macros/generic/mathdots")
+   (synopsis "Commands to produce dots in math that respect font size")
+   (description
+    "Redefines \\ddots and \\vdots, and defines \\iddots.  The dots produced by \\iddots
+slant in the opposite direction to \\ddots.  All the commands are designed to
+change size appropriately in scripts, as well as in response to LaTeX size
+changing commands.  The commands may also be used in plain TeX.")
+   (license license:lppl)))
+
 (define-public texlive-amscls
   (let ((template (simple-texlive-package
                    "texlive-amscls"

base-commit: 1bea5d38a26755b84437623c0f48915a77899b57
-- 
2.38.1

[bug#59354] [PATCH] gnu: Add texlive-mathdots.

[Nicolas Goaziou]

Hello,

Yarl Baudig <yarl-baudig@mailoo.org> writes:

> * gnu/packages/tex.scm (texlive-mathdots): New variable.

Thank you. Some comments follow.

> +  (package
> +    (inherit (simple-texlive-package
> +	      "texlive-mathdots"

Indentation looks wrong here.

> +              (list "doc/generic/mathdots/"
> +                    "source/generic/mathdots/"
> +                    "tex/generic/mathdots/")
> +              (base32
> +               "1jaffj343p1chdxs2g7s6lpckvihk0jfw22nw0vmijyjxfiy9yg0")
> +	      #:trivial? #t))

This doesn't look like a trivial package since it contains a ".ins"
file. You need to generate the ".tex" and ".sty" files from it.

> +   (home-page "https://ctan.org/macros/generic/mathdots")
> +   (synopsis "Commands to produce dots in math that respect font size")
> +   (description
> +    "Redefines \\ddots and \\vdots, and defines \\iddots.  The dots produced by \\iddots

The first sentence should contain a subject. Also \\ddots ->
@code{\\dots}

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

[bug#59354] [PATCH] gnu: Add texlive-mathdots.

[yarl baudig]

Hello,

> Thank you. Some comments follow.
> 
> > +  (package
> > +    (inherit (simple-texlive-package
> > +	      "texlive-mathdots"
> 
> Indentation looks wrong here.
I am not sure how it's wrong. Path will follow. Is it better?

> 
> > +              (list "doc/generic/mathdots/"
> > +                    "source/generic/mathdots/"
> > +                    "tex/generic/mathdots/")
> > +              (base32
> > +               "1jaffj343p1chdxs2g7s6lpckvihk0jfw22nw0vmijyjxfiy9yg0")
> > +	      #:trivial? #t))
> 
> This doesn't look like a trivial package since it contains a ".ins"
> file. You need to generate the ".tex" and ".sty" files from it.
> 
I think it is, "tex/generic/mathdots/" in tug repo contains ".tex" and ".sty" and if I compile, they are here.
First texlive package I package. I tried `guix import texlive mathdots` then amended by looking at other texlive packages. Please show me if I am wrong.

> > +   (home-page "https://ctan.org/macros/generic/mathdots")
> > +   (synopsis "Commands to produce dots in math that respect font size")
> > +   (description
> > +    "Redefines \\ddots and \\vdots, and defines \\iddots.  The dots 
> produced by \\iddots
> 
> The first sentence should contain a subject. Also \\ddots ->
> @code{\\dots}
> 
> Could you send an updated patch?
> 
> Regards,
> -- 
> Nicolas Goaziou
> 

Patch is coming, please tell me if it good.

[bug#59354] [PATCH] gnu: Add texlive-mathdots.

[Nicolas Goaziou]

Hello,

"yarl baudig" <yarl-baudig@mailoo.org> writes:

> I am not sure how it's wrong. Path will follow. Is it better?

It is. Thanks.

>> This doesn't look like a trivial package since it contains a ".ins"
>> file. You need to generate the ".tex" and ".sty" files from it.
>> 
> I think it is, "tex/generic/mathdots/" in tug repo contains ".tex" and ".sty" and if I compile, they are here.
> First texlive package I package. I tried `guix import texlive
> mathdots` then amended by looking at other texlive packages. Please
> show me if I am wrong.

"guix import texlive mathdots" output doesn't include "#:trivial? #t"
for a reason. You need to take a longer path and generate runfiles from
the ".ins" file ; see e.g., "texlive-capt-of".

Regards,
-- 
Nicolas Goaziou

[bug#59354] [PATCH] gnu: Add texlive-mathdots.

[yarl baudig]

> >> This doesn't look like a trivial package since it contains a ".ins"
> >> file. You need to generate the ".tex" and ".sty" files from it.
> >> 
> > I think it is, "tex/generic/mathdots/" in tug repo contains ".tex" and 
> ".sty" and if I compile, they are here.
> > First texlive package I package. I tried `guix import texlive
> > mathdots` then amended by looking at other texlive packages. Please
> > show me if I am wrong.
> 
> "guix import texlive mathdots" output doesn't include "#:trivial? #t"
> for a reason. You need to take a longer path and generate runfiles from
> the ".ins" file ; see e.g., "texlive-capt-of".
> 
> Regards,
> -- 
> Nicolas Goaziou
> 

Thank you.
I saw that "guix import texlive mathdots" doesn't include "#:trivial? #t" But I still don't see why it is not effectively a trivial package. As I told you, the ".tex" and ".sty" are already in the TUG repo. And with the package as I defined it (as trivial), when you build it, you get the "mathdots.sty" and "mathdots.tex". No need to compile because, whereas there is a ".ins" file,  ".sty" and ".tex" are already compiled and distributed, along the ".ins". Right?

[bug#59354] [PATCH] gnu: Add texlive-mathdots.

[Nicolas Goaziou]

"yarl baudig" <yarl-baudig@mailoo.org> writes:

> I saw that "guix import texlive mathdots" doesn't include "#:trivial?
> #t" But I still don't see why it is not effectively a trivial package.
> As I told you, the ".tex" and ".sty" are already in the TUG repo. And
> with the package as I defined it (as trivial), when you build it, you
> get the "mathdots.sty" and "mathdots.tex". No need to compile because,
> whereas there is a ".ins" file, ".sty" and ".tex" are already compiled
> and distributed, along the ".ins". Right?

Whenever possible, Guix builds packages from source, and avoids using
pre-compiled files. In this case, we can generate ".sty" and ".tex"
files, so let's do that. Does that make sense?

[bug#59354] [PATCH] gnu: Add texlive-mathdots.

[yarl baudig]

> Whenever possible, Guix builds packages from source, and avoids using
> pre-compiled files. In this case, we can generate ".sty" and ".tex"
> files, so let's do that. Does that make sense?
> 

Yes it does! Thank you. I will try :).

[bug#59354] [PATCH] gnu: Add texlive-mathdots.

[yarl baudig]

* gnu/packages/tex.scm (texlive-mathdots): New variable.
---
 gnu/packages/tex.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm
index 81f74f17df..e973b30ee0 100644
--- a/gnu/packages/tex.scm
+++ b/gnu/packages/tex.scm
@@ -3993,6 +3993,26 @@ (define-public texlive-amsmath
 
 (define-deprecated-package texlive-latex-amsmath texlive-amsmath)
 
+(define-public texlive-mathdots
+  (package
+    (inherit (simple-texlive-package
+              "texlive-mathdots"
+              (list "doc/generic/mathdots/"
+                    "source/generic/mathdots/"
+                    "tex/generic/mathdots/")
+              (base32
+               "1jaffj343p1chdxs2g7s6lpckvihk0jfw22nw0vmijyjxfiy9yg0")
+              #:trivial? #t))
+    (home-page "https://ctan.org/macros/generic/mathdots")
+    (synopsis "Commands to produce dots in math that respect font size")
+    (description
+     "Mathdots redefines @code{\\ddots} and @code{\\vdots}, and defines
+@code{\\iddots}.  The dots produced by @code{\\iddots} slant in the opposite
+direction to @code{\\ddots}.  All the commands are designed to change size
+appropriately in scripts, as well as in response to LaTeX size changing
+commands.  The commands may also be used in plain TeX.")
+    (license license:lppl)))
+
 (define-public texlive-amscls
   (let ((template (simple-texlive-package
                    "texlive-amscls"

base-commit: 1bea5d38a26755b84437623c0f48915a77899b57
-- 
2.38.1

[bug#59354] [PATCH] gnu: Add texlive-mathdots.

[Yarl Baudig]

* gnu/packages/tex.scm (texlive-mathdots): New variable.
---
 gnu/packages/tex.scm | 41 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/tex.scm b/gnu/packages/tex.scm
index 81f74f17df..a600bcae58 100644
--- a/gnu/packages/tex.scm
+++ b/gnu/packages/tex.scm
@@ -3993,6 +3993,47 @@ (define-public texlive-amsmath
 
 (define-deprecated-package texlive-latex-amsmath texlive-amsmath)
 
+(define-public texlive-mathdots
+  (let ((template
+         (simple-texlive-package
+          "texlive-mathdots"
+          (list "doc/generic/mathdots/"
+                "source/generic/mathdots/"
+                "tex/generic/mathdots/")
+          (base32"1jaffj343p1chdxs2g7s6lpckvihk0jfw22nw0vmijyjxfiy9yg0"))))
+    (package
+      (inherit template)
+      (outputs '("out" "doc"))
+      (arguments
+       (substitute-keyword-arguments (package-arguments template)
+         ((#:tex-directory _ '())
+          "generic/mathdots")
+         ((#:build-targets _ '())
+          '(list "mathdots.ins"))
+         ((#:phases phases)
+          #~(modify-phases #$phases
+              (add-after 'unpack 'chdir
+                (lambda _
+                  (chdir "source/generic/mathdots")))
+              (replace 'copy-files
+                (lambda* (#:key inputs outputs #:allow-other-keys)
+                  (let ((origin (assoc-ref inputs "source"))
+                        (source (string-append (assoc-ref outputs "out")
+                                               "/share/texmf-dist/source"))
+                        (doc (string-append (assoc-ref outputs "doc")
+                                            "/share/texmf-dist/doc")))
+                    (copy-recursively (string-append origin "/source") source)
+                    (copy-recursively (string-append origin "/doc") doc))))))))
+      (home-page "https://ctan.org/macros/generic/mathdots")
+      (synopsis "Commands to produce dots in math that respect font size")
+      (description
+       "Mathdots redefines @code{\\ddots} and @code{\\vdots}, and defines
+@code{\\iddots}.  The dots produced by @code{\\iddots} slant in the opposite
+direction to @code{\\ddots}.  All the commands are designed to change size
+appropriately in scripts, as well as in response to LaTeX size changing
+commands.  The commands may also be used in plain TeX.")
+      (license license:lppl))))
+
 (define-public texlive-amscls
   (let ((template (simple-texlive-package
                    "texlive-amscls"

base-commit: 1bea5d38a26755b84437623c0f48915a77899b57
-- 
2.38.1

bug#59354: [PATCH] gnu: Add texlive-mathdots.

[Nicolas Goaziou]

Hello,

Yarl Baudig <yarl-baudig@mailoo.org> writes:

> * gnu/packages/tex.scm (texlive-mathdots): New variable.

Perfect. Applied. Thank you.

Regards,
-- 
Nicolas Goaziou