what might be wrong with my nightly function?

what might be wrong with my nightly function?

[jgart]

hi, what might be wrong with this function?

;; let's tracking nightlies!
(define* (make-olive-nightly
           #:key (olive-commit "3302c3633c665fd32152217f254b53654945f2dd")
                 (olive-hash (base32 "0pp6dxn53aw6iiy9wnbkkmg8mcqpx8wy6nify8j4hrzvzrmks82c")))
    (package (inherit olive)
      (version (string-take olive-commit 7))
      (source (origin
		(method git-fetch)
		(uri (git-reference
		      (url "https://github.com/olive-editor/olive")
		      (commit olive-commit)))
		(file-name (git-file-name name version))
		(sha256
		 (base32 olive-hash))))
      (build-system cmake-build-system)
      (arguments
       `(,@(package-arguments olive)
         #:tests? #f))))

(define-public olive-3302c36
  (make-olive-nightly
    #:olive-commit "3302c3633c665fd32152217f254b53654945f2dd"
    #:olive-hash "0pp6dxn53aw6iiy9wnbkkmg8mcqpx8wy6nify8j4hrzvzrmks82c"))

;; olive package


(define-public olive
  (let ((revision "2")
	    (commit "efa74c72a80522fdd85a56e7dee13e341b73de99"))
    (package
      (name "olive")
      (version (git-version "0.2.0" revision commit))
      (source (origin
		(method git-fetch)
		(uri (git-reference
		      (url "https://github.com/olive-editor/olive")
		      (commit commit)))
		(file-name (git-file-name name version))
		(sha256
		 (base32
		  "00zv1h9acf3z76ivy04272r4f6rv0yip4bx1vs5znajffnyaj0jm"))))
      (build-system cmake-build-system)
      (arguments
       `(#:configure-flags '("-DCMAKE_CXX_FLAGS=-Wno-error=shadow")))
      (inputs
        (list qtbase-5
		      qtmultimedia
		      qttools
		      qtsvg
		      ffmpeg
		      opencolorio-2
		      openimageio
              portaudio
              zlib
              imath
		      openexr-3
              ilmbase))
      (native-inputs
        (list pkg-config))
      (home-page "https://olivevideoeditor.org")
      (synopsis "Free non-linear video editor")
      (description
"@code{olive} is a free and open source non-linear video editor.")
      (license license:gpl3+))))

Re: what might be wrong with my nightly function?

[Julien Lepiller]

Haven't tested and you didn't share what was the issue. The obvious thing I see is #:olive-hash is (base32 "…") by default, so the origin uses (sha256 (base32 (base32 "…"))) by default

Le 16 novembre 2022 02:37:10 GMT+01:00, jgart <jgart@dismail.de> a écrit :
>hi, what might be wrong with this function?
>
>;; let's tracking nightlies!
>(define* (make-olive-nightly
>           #:key (olive-commit "3302c3633c665fd32152217f254b53654945f2dd")
>                 (olive-hash (base32 "0pp6dxn53aw6iiy9wnbkkmg8mcqpx8wy6nify8j4hrzvzrmks82c")))
>    (package (inherit olive)
>      (version (string-take olive-commit 7))
>      (source (origin
>		(method git-fetch)
>		(uri (git-reference
>		      (url "https://github.com/olive-editor/olive")
>		      (commit olive-commit)))
>		(file-name (git-file-name name version))
>		(sha256
>		 (base32 olive-hash))))
>      (build-system cmake-build-system)
>      (arguments
>       `(,@(package-arguments olive)
>         #:tests? #f))))
>
>(define-public olive-3302c36
>  (make-olive-nightly
>    #:olive-commit "3302c3633c665fd32152217f254b53654945f2dd"
>    #:olive-hash "0pp6dxn53aw6iiy9wnbkkmg8mcqpx8wy6nify8j4hrzvzrmks82c"))
>
>;; olive package
>
>
>(define-public olive
>  (let ((revision "2")
>	    (commit "efa74c72a80522fdd85a56e7dee13e341b73de99"))
>    (package
>      (name "olive")
>      (version (git-version "0.2.0" revision commit))
>      (source (origin
>		(method git-fetch)
>		(uri (git-reference
>		      (url "https://github.com/olive-editor/olive")
>		      (commit commit)))
>		(file-name (git-file-name name version))
>		(sha256
>		 (base32
>		  "00zv1h9acf3z76ivy04272r4f6rv0yip4bx1vs5znajffnyaj0jm"))))
>      (build-system cmake-build-system)
>      (arguments
>       `(#:configure-flags '("-DCMAKE_CXX_FLAGS=-Wno-error=shadow")))
>      (inputs
>        (list qtbase-5
>		      qtmultimedia
>		      qttools
>		      qtsvg
>		      ffmpeg
>		      opencolorio-2
>		      openimageio
>              portaudio
>              zlib
>              imath
>		      openexr-3
>              ilmbase))
>      (native-inputs
>        (list pkg-config))
>      (home-page "https://olivevideoeditor.org")
>      (synopsis "Free non-linear video editor")
>      (description
>"@code{olive} is a free and open source non-linear video editor.")
>      (license license:gpl3+))))
>
>
>

Re: what might be wrong with my nightly function?

[jgart]

On Wed, 16 Nov 2022 07:08:10 +0100 Julien Lepiller <julien@lepiller.eu> wrote:
> Haven't tested and you didn't share what was the issue. The obvious thing I see is #:olive-hash is (base32 "…") by default, so the origin uses (sha256 (base32 (base32 "…"))) by default

Thanks for catching that one!

I think the other issue is the way I am constructing the version and
then calling it at the command line:

guix doesn't like this:

guix build -L . olive@3302c36


;; let's tracking nightlies!
(define* (make-olive-nightly #:key olive-commit olive-hash)
    (package (inherit olive)
      (name "olive")
      (version (string-take olive-commit 7))
      (source
        (origin
          (method git-fetch)
          (uri (git-reference
	         (url "https://github.com/olive-editor/olive")
	         (commit olive-commit)))
          (file-name (git-file-name name version))
          (sha256
            (base32 olive-hash))))
      (build-system cmake-build-system)
      (arguments `(,@(package-arguments olive)
                 #:tests? #f))))
  
(define-public olive-3302c36
  (make-olive-nightly
    #:olive-commit "3302c3633c665fd32152217f254b53654945f2dd"
    #:olive-hash "0pp6dxn53aw6iiy9wnbkkmg8mcqpx8wy6nify8j4hrzvzrmks82c"))