* [bug#57945] [PATCH] gnu: wpa-supplicant: enable OWE support
@ 2022-09-19 23:59 Andreas Rammhold
2022-09-22 19:14 ` Maxime Devos
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Rammhold @ 2022-09-19 23:59 UTC (permalink / raw)
To: 57945; +Cc: Andreas Rammhold
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 1743 bytes --]
With OWE support users are enable to connect to "Opportunistic Wireless
Encryption" networks. This means users are able to have an encrypted
data channel in an otherwise open wireless network.
* gnu/packages/admin.scm (wpa-supplicant): Enable OWE support.
Signed-off-by: Andreas Rammhold <andreas@rammhold.de>
---
gnu/packages/admin.scm | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 5fb621e027..84819992c4 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -51,6 +51,7 @@
;;; Copyright © 2021 Artyom V. Poptsov <poptsov.artyom@gmail.com>
;;; Copyright © 2022 Wamm K. D. <jaft.r@outlook.com>
;;; Copyright © 2022 Roman Riabenko <roman@riabenko.com>
+;;; Copyright © 2022 Andreas Rammhold <andreas@rammhold.de>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -2133,6 +2134,12 @@ (define-public wpa-supplicant
CONFIG_CTRL_IFACE_DBUS_INTRO=y\n" port)
(close-port port))
#t))
+ (add-after 'configure 'enable-owe
+ (lambda _
+ (let ((port (open-file ".config" "al")))
+ (display "CONFIG_OWE=y\n" port)
+ (close-port port))
+ #t))
(add-after 'install-documentation 'install-dbus-conf
(lambda* (#:key outputs #:allow-other-keys)
(let* ((out (assoc-ref outputs "out"))
base-commit: d845326b5cb33453a50b9c8fd8f21dfd8198a158
prerequisite-patch-id: b830a1b0573b55d8a8378338862dc5bfaac53117
prerequisite-patch-id: 59289da7b58eb3a1ea1f3b531261d0785b58dd36
prerequisite-patch-id: a761f12c1d69204330e6215a26ea110c281ea834
prerequisite-patch-id: fcc87d0b44e2c3597e9270e6d96c8f1e4beddcf6
--
2.37.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#57945] [PATCH] gnu: wpa-supplicant: enable OWE support
2022-09-19 23:59 [bug#57945] [PATCH] gnu: wpa-supplicant: enable OWE support Andreas Rammhold
@ 2022-09-22 19:14 ` Maxime Devos
2022-09-22 19:32 ` Maxime Devos
2022-09-28 20:41 ` bug#57945: " Ludovic Courtès
0 siblings, 2 replies; 4+ messages in thread
From: Maxime Devos @ 2022-09-22 19:14 UTC (permalink / raw)
To: Andreas Rammhold, 57945
[-- Attachment #1.1.1: Type: text/plain, Size: 1042 bytes --]
On 20-09-2022 01:59, Andreas Rammhold wrote:
> + (add-after 'configure 'enable-owe
> + (lambda _
> + (let ((port (open-file ".config" "al")))
> + (display "CONFIG_OWE=y\n" port)
> + (close-port port))
> + #t))
(1) Why not do this in the 'configure' phase instead?
(2) Trailing #t in phases aren't required anymore since a long time, you
can remove them.
(3) You are not a committer (and you are the author), so you can't 'push
the commit on behalf on somebody else'. From (guix)Commit Access:
When pushing a commit on behalf of somebody else, please add a
‘Signed-off-by’ line at the end of the commit log message—e.g., with
‘git am --signoff’. This improves tracking of who did what.
The other meaning of 'Signed-off-by' I'm aware of, is for 'Developer
Certificate of Origin', but we don't do DCO in Guix (and if we did, it
would be mentioned in the contributing guidelines somewhere).
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#57945] [PATCH] gnu: wpa-supplicant: enable OWE support
2022-09-22 19:14 ` Maxime Devos
@ 2022-09-22 19:32 ` Maxime Devos
2022-09-28 20:41 ` bug#57945: " Ludovic Courtès
1 sibling, 0 replies; 4+ messages in thread
From: Maxime Devos @ 2022-09-22 19:32 UTC (permalink / raw)
To: Andreas Rammhold, 57945
[-- Attachment #1.1.1: Type: text/plain, Size: 289 bytes --]
On 22-09-2022 21:14, Maxime Devos wrote:
> (3) You are not a committer (and you are the author), so you can't 'push
> the commit on behalf on somebody else'. From (guix)Commit Access:
(At least, AFAIK, .guix-authorizations doesn't mention names or e-mails
except for nicks)
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#57945: [PATCH] gnu: wpa-supplicant: enable OWE support
2022-09-22 19:14 ` Maxime Devos
2022-09-22 19:32 ` Maxime Devos
@ 2022-09-28 20:41 ` Ludovic Courtès
1 sibling, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2022-09-28 20:41 UTC (permalink / raw)
To: Maxime Devos; +Cc: 57945-done, Andreas Rammhold
Hi,
Maxime Devos <maximedevos@telenet.be> skribis:
> On 20-09-2022 01:59, Andreas Rammhold wrote:
>> + (add-after 'configure 'enable-owe
>> + (lambda _
>> + (let ((port (open-file ".config" "al")))
>> + (display "CONFIG_OWE=y\n" port)
>> + (close-port port))
>> + #t))
>
>
> (1) Why not do this in the 'configure' phase instead?
> (2) Trailing #t in phases aren't required anymore since a long time,
> you can remove them.
> (3) You are not a committer (and you are the author), so you can't
> 'push the commit on behalf on somebody else'. From (guix)Commit
Good points (perhaps somewhat intimidating for a newcomer).
Andreas, I applied a variant of the patch that accounts for the comments
Maxime made.
Thank you!
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-28 21:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 23:59 [bug#57945] [PATCH] gnu: wpa-supplicant: enable OWE support Andreas Rammhold
2022-09-22 19:14 ` Maxime Devos
2022-09-22 19:32 ` Maxime Devos
2022-09-28 20:41 ` bug#57945: " Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.