From: Timotej Lazar <timotej.lazar@araneo.si>
To: 56813@debbugs.gnu.org
Cc: Timotej Lazar <timotej.lazar@araneo.si>
Subject: [bug#56813] [PATCH 1/2] services: qemu-guest-agent: Fix arguments to qemu-ga.
Date: Thu, 28 Jul 2022 17:03:25 +0200 [thread overview]
Message-ID: <20220728150326.14182-1-timotej.lazar@araneo.si> (raw)
In-Reply-To: <87y1wdb7yk.fsf@araneo.si>
Fix the check for empty device path. Do not use --daemonize, since that is
handled by make-forkexec-constructor. Drop the --pidfile option which is
unused without --daemonize.
* gnu/services/virtualization.scm (qemu-guest-agent-shepherd-service): Modify
command arguments.
---
gnu/services/virtualization.scm | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualization.scm
index 41afe451c1..406752b35c 100644
--- a/gnu/services/virtualization.scm
+++ b/gnu/services/virtualization.scm
@@ -879,13 +879,11 @@ (define (qemu-guest-agent-shepherd-service config)
(provision '(qemu-guest-agent))
(documentation "Run the QEMU guest agent.")
(start #~(make-forkexec-constructor
- `(,(string-append #$qemu "/bin/qemu-ga") "--daemon"
- "--pidfile=/var/run/qemu-ga.pid"
- "--statedir=/var/run"
- ,@(if #$device
- (list (string-append "--path=" #$device))
- '()))
- #:pid-file "/var/run/qemu-ga.pid"
+ `(,(string-append #$qemu "/bin/qemu-ga")
+ "--statedir" "/var/run"
+ ,@(if (string-null? #$device)
+ '()
+ (list "--path" #$device)))
#:log-file "/var/log/qemu-ga.log"))
(stop #~(make-kill-destructor))))))
--
2.36.1
next prev parent reply other threads:[~2022-07-28 15:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 14:57 [bug#56813] [PATCH 0/2] Add a test for qemu-guest-agent service Timotej Lazar
2022-07-28 15:03 ` Timotej Lazar [this message]
2022-07-28 15:03 ` [bug#56813] [PATCH 2/2] tests: Add qemu-guest-agent system test Timotej Lazar
2022-08-09 15:23 ` bug#56813: [PATCH 0/2] Add a test for qemu-guest-agent service Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220728150326.14182-1-timotej.lazar@araneo.si \
--to=timotej.lazar@araneo.si \
--cc=56813@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.