From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iP1sJrCl4mI8ogAAbAwnHQ (envelope-from ) for ; Thu, 28 Jul 2022 17:05:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mGdNJrCl4mKQfwAAauVa8A (envelope-from ) for ; Thu, 28 Jul 2022 17:05:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 62A113FF27 for ; Thu, 28 Jul 2022 17:05:20 +0200 (CEST) Received: from localhost ([::1]:59408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oH54g-0003Xs-GL for larch@yhetil.org; Thu, 28 Jul 2022 11:05:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oH53W-0003Vt-FY for guix-patches@gnu.org; Thu, 28 Jul 2022 11:04:11 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41284) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oH53S-0003Yt-5I for guix-patches@gnu.org; Thu, 28 Jul 2022 11:04:06 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oH53R-0000Xj-Py for guix-patches@gnu.org; Thu, 28 Jul 2022 11:04:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56813] [PATCH 1/2] services: qemu-guest-agent: Fix arguments to qemu-ga. Resent-From: Timotej Lazar Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 28 Jul 2022 15:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56813 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56813@debbugs.gnu.org Cc: Timotej Lazar Received: via spool by 56813-submit@debbugs.gnu.org id=B56813.16590206262046 (code B ref 56813); Thu, 28 Jul 2022 15:04:01 +0000 Received: (at 56813) by debbugs.gnu.org; 28 Jul 2022 15:03:46 +0000 Received: from localhost ([127.0.0.1]:59262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oH53B-0000Ww-W4 for submit@debbugs.gnu.org; Thu, 28 Jul 2022 11:03:46 -0400 Received: from araneo.si ([90.157.193.204]:53554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oH539-0000Wk-0f for 56813@debbugs.gnu.org; Thu, 28 Jul 2022 11:03:45 -0400 Received: from araneo.si (localhost.lan [127.0.0.1]) by araneo.si (OpenSMTPD) with ESMTP id eba549bc for <56813@debbugs.gnu.org>; Thu, 28 Jul 2022 15:03:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=araneo.si; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=20180623; bh=f6UJHSAe+ZRty9GlWclPM aONNgU=; b=ot4JtNiAFHkAHw+rLArNppHHtbro2OL5e7byfSr+KSH1pMqrcnSRM IVN3TzjJyQ15v9uxqrUNRuILmltCKBkz7ijjNxgr8KivExlTaJXVgGyOjkv8TJ92 8P1JUBvRkYFB/ge980LJi4WGZSoWuXZ0XIHm7fKf+519O/tmWOGfhm4EbauKx6+g oEb+bNjz7ssTq8FIwqSexqTehrNnstw4ZH2nk8Y9za7CxQJ9QKKJGEVtRLct9AXH QclQCqIUXuWE52elEDDOHZ6VQAQ9mVnkdhoNbo3wp1m6GkZ2xih3Ms5VVaUTEOaY 2+HV385Uqx5DyUHt38gvI7whL6GRf8eBA== Received: by araneo.si (OpenSMTPD) with ESMTPSA id 519c11cb (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 28 Jul 2022 15:03:41 +0000 (UTC) From: Timotej Lazar Date: Thu, 28 Jul 2022 17:03:25 +0200 Message-Id: <20220728150326.14182-1-timotej.lazar@araneo.si> X-Mailer: git-send-email 2.36.1 In-Reply-To: <87y1wdb7yk.fsf@araneo.si> References: <87y1wdb7yk.fsf@araneo.si> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659020720; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yquGXxV32sHmvNZ+/C8gtt+iVgCcV/km4aXiQyjlLOA=; b=BcPKQnWNJAqN/VVNqgVmW5QZBNru19ka3o3B6QERVCzOZW2p4pdp4MbfPNCAOr/iyAvUGZ 7KcWE9Hv/O+F403KgWNCTqTexKW31oJ/vpncR1ouuczb0wua4UIJSZyzCVK42/z10aoBzT UbquYl219220DB8+yzGzfxSlXmnxixsz5Ca3MzVNVJNpJx37CMU6zQpTxv4y6AtgfoSHT9 8S9LYorZzj6TJX/WNyLnHn8VWhiKoj9zBKp3nWykJj9lGXSh5kixXl/D+/JOW/YXDQ/QQa 5dKipQfwV6FhQWO0+Eblk4hFAPCUuJYl7cGLowHq9AyeQIQZIar732Uc/2mEqw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659020720; a=rsa-sha256; cv=none; b=lvSSWKccJz5brfVWGZ6j9S8FFD/Gaw0siwAwmmIXk6TLctl+EAYKD+bQk0o69Y4KyVIIJB g6rgUntCgQRJ+b7xb9zuBMmccWDL6c2NrVdVrlHmE9RQoF97wxkQdB91mi22rSmHmmj4KC gSA2lDZrSyracxZT/ggrcSX6WoelmBKRVmCJkuKLzwYJ6CZqskIaORIJKJ7AtVDj3bD4AP DkTInZCSEF2igfYlw+hpurGQCdnM/YVM7yim5p8XlWPOJ6Lbifad64z8Mp0cCzAQ35tw+r 0kEPc3rHKTGlN0ORaO1yZRC3dkiynUKZxXwY80+qtpjgSj/93+ltgplYG1eGKw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=araneo.si header.s=20180623 header.b=ot4JtNiA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=araneo.si (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.07 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=araneo.si header.s=20180623 header.b=ot4JtNiA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=araneo.si (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 62A113FF27 X-Spam-Score: 7.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: QstPCbV5H67Y Fix the check for empty device path. Do not use --daemonize, since that is handled by make-forkexec-constructor. Drop the --pidfile option which is unused without --daemonize. * gnu/services/virtualization.scm (qemu-guest-agent-shepherd-service): Modify command arguments. --- gnu/services/virtualization.scm | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualization.scm index 41afe451c1..406752b35c 100644 --- a/gnu/services/virtualization.scm +++ b/gnu/services/virtualization.scm @@ -879,13 +879,11 @@ (define (qemu-guest-agent-shepherd-service config) (provision '(qemu-guest-agent)) (documentation "Run the QEMU guest agent.") (start #~(make-forkexec-constructor - `(,(string-append #$qemu "/bin/qemu-ga") "--daemon" - "--pidfile=/var/run/qemu-ga.pid" - "--statedir=/var/run" - ,@(if #$device - (list (string-append "--path=" #$device)) - '())) - #:pid-file "/var/run/qemu-ga.pid" + `(,(string-append #$qemu "/bin/qemu-ga") + "--statedir" "/var/run" + ,@(if (string-null? #$device) + '() + (list "--path" #$device))) #:log-file "/var/log/qemu-ga.log")) (stop #~(make-kill-destructor)))))) -- 2.36.1