* [bug#55922] [PATCH] gnu: Add guile-termios.
@ 2022-06-12 10:04 Antero Mejr via Guix-patches via
2022-06-12 15:47 ` Maxime Devos
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Antero Mejr via Guix-patches via @ 2022-06-12 10:04 UTC (permalink / raw)
To: 55922
* gnu/packages/guile-xyz.scm (guile-termios): New variable.
---
gnu/packages/guile-xyz.scm | 50 ++++++++++++++++++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index c6f73a38e9..373a5b13f1 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -41,6 +41,7 @@
;;; Copyright © 2021, 2022 Artyom V. Poptsov <poptsov.artyom@gmail.com>
;;; Copyright © 2022 Maxime Devos <maximedevos@telenet.be>
;;; Copyright © 2022 Zhu Zihao <all_but_last@163.com>
+;;; Copyright © 2022 Antero Mejr <antero@mailbox.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -5019,3 +5020,52 @@ (define-public lokke
in two different guises.")
;; Dual license: LGPLv2.1+ or EPLv1.0+ at the user's option.
(license (list license:lgpl2.1+ license:epl1.0)))))
+
+(define-public guile-termios
+ (package
+ (name "guile-termios")
+ (version "0.6.4")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ft/guile-termios")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "020p3c84z09wyyb6gfzj2x6q2rfmvas7c92fcm2hhg8z1q60sqkg"))))
+ (build-system gnu-build-system)
+ (arguments
+ (list #:tests?
+ #f
+ #:make-flags
+ #~(list (string-append "CC="
+ #$(cc-for-target))
+ (string-append "PREFIX="
+ #$output))
+ #:phases
+ #~(modify-phases %standard-phases
+ (replace 'build
+ (lambda _
+ (invoke "make")
+ (invoke "make" "compile"))))))
+ (native-inputs (list guile-3.0))
+ (home-page "https://github.com/ft/guile-termios")
+ (synopsis "POSIX termios interface for GNU Guile")
+ (description
+ "To query and change settings of serial devices on POSIX systems, the
+termios API is used. GNU Guile doesn't have an interface for that built in.
+This module implements this interface by use of Guile's dynamic FFI.")
+ (license license:bsd-2)))
+
+(define-public guile2.0-termios
+ (package
+ (inherit guile-termios)
+ (name "guile2.0-termios")
+ (native-inputs (list guile-2.0))))
+
+(define-public guile2.2-termios
+ (package
+ (inherit guile-termios)
+ (name "guile2.2-termios")
+ (native-inputs (list guile-2.2))))
--
2.36.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#55922] [PATCH] gnu: Add guile-termios.
2022-06-12 10:04 [bug#55922] [PATCH] gnu: Add guile-termios Antero Mejr via Guix-patches via
@ 2022-06-12 15:47 ` Maxime Devos
2022-06-12 22:21 ` Antero Mejr via Guix-patches via
2022-06-16 21:53 ` [bug#55922] [PATCH 1/2] " Antero Mejr via Guix-patches via
2 siblings, 0 replies; 7+ messages in thread
From: Maxime Devos @ 2022-06-12 15:47 UTC (permalink / raw)
To: Antero Mejr, 55922
[-- Attachment #1: Type: text/plain, Size: 276 bytes --]
Antero Mejr via Guix-patches via schreef op zo 12-06-2022 om 10:04
[+0000]:
> + (list #:tests?
> + #f
When disabling tests, always document the reason.
Also, no need for a separate line. Likewise for #:make-flags.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#55922] [PATCH] gnu: Add guile-termios.
2022-06-12 10:04 [bug#55922] [PATCH] gnu: Add guile-termios Antero Mejr via Guix-patches via
2022-06-12 15:47 ` Maxime Devos
@ 2022-06-12 22:21 ` Antero Mejr via Guix-patches via
2022-06-16 21:15 ` Ludovic Courtès
2022-06-16 21:53 ` [bug#55922] [PATCH 1/2] " Antero Mejr via Guix-patches via
2 siblings, 1 reply; 7+ messages in thread
From: Antero Mejr via Guix-patches via @ 2022-06-12 22:21 UTC (permalink / raw)
To: 55922
Thanks for the review. This improved patch has tests, a new guile test library,
and man pages.
About the line breaks on the original patch - it was styled with guix style.
This patch is written differently but still had guix style applied.
* gnu/packages/guile-xyz.scm (guile-termios): New variable.
---
gnu/packages/guile-xyz.scm | 108 +++++++++++++++++++++++++++++++++++++
1 file changed, 108 insertions(+)
diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index c6f73a38e9..e1bb18056e 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -41,6 +41,7 @@
;;; Copyright © 2021, 2022 Artyom V. Poptsov <poptsov.artyom@gmail.com>
;;; Copyright © 2022 Maxime Devos <maximedevos@telenet.be>
;;; Copyright © 2022 Zhu Zihao <all_but_last@163.com>
+;;; Copyright © 2022 Antero Mejr <antero@mailbox.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -83,6 +84,7 @@ (define-module (gnu packages guile-xyz)
#:use-module (gnu packages gstreamer)
#:use-module (gnu packages gtk)
#:use-module (gnu packages guile)
+ #:use-module (gnu packages haskell-xyz)
#:use-module (gnu packages hurd)
#:use-module (gnu packages image)
#:use-module (gnu packages imagemagick)
@@ -5019,3 +5021,109 @@ (define-public lokke
in two different guises.")
;; Dual license: LGPLv2.1+ or EPLv1.0+ at the user's option.
(license (list license:lgpl2.1+ license:epl1.0)))))
+
+(define-public guile-termios
+ (package
+ (name "guile-termios")
+ (version "0.6.4")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ft/guile-termios")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "020p3c84z09wyyb6gfzj2x6q2rfmvas7c92fcm2hhg8z1q60sqkg"))))
+ (build-system gnu-build-system)
+ (arguments
+ (list #:phases
+ #~(modify-phases %standard-phases
+ (replace 'configure
+ (lambda _
+ (substitute* "Makefile"
+ (("CC = cc") (string-append "CC="
+ #$(cc-for-target)))
+ (("PREFIX = /usr/local") (string-append "PREFIX="
+ #$output)))))
+ (replace 'build
+ (lambda _
+ (invoke "make")
+ (invoke "make" "-C" "doc" "man")
+ (invoke "make" "install")))
+ (replace 'check
+ (lambda* (#:key tests? #:allow-other-keys)
+ (when tests?
+ (invoke "make" "test")))))))
+ (native-inputs (list guile-3.0 guile-tap pandoc perl perl-io-tty))
+ (home-page "https://github.com/ft/guile-termios")
+ (synopsis "POSIX termios interface for GNU Guile")
+ (description
+ "To query and change settings of serial devices on POSIX systems, the
+termios API is used. GNU Guile doesn't have an interface for that built in.
+This module implements this interface by use of Guile's dynamic FFI.")
+ (license license:bsd-2)))
+
+(define-public guile2.0-termios
+ (package
+ (inherit guile-termios)
+ (name "guile2.0-termios")
+ (native-inputs (list guile-2.0))))
+
+(define-public guile2.2-termios
+ (package
+ (inherit guile-termios)
+ (name "guile2.2-termios")
+ (native-inputs (list guile-2.2))))
+
+(define-public guile-tap
+ (package
+ (name "guile-tap")
+ (version "0.4.6")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ft/guile-tap")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "04ip5cbvsjjcicsri813f4711yh7db6fvc2px4788rl8p1iqvi6x"))))
+ (build-system gnu-build-system)
+ (arguments
+ (list #:phases
+ #~(modify-phases %standard-phases
+ (replace 'configure
+ (lambda _
+ (substitute* "Makefile"
+ (("PREFIX = /usr/local") (string-append "PREFIX="
+ #$output)))))
+ (replace 'build
+ (lambda _
+ (invoke "make")
+ (invoke "make" "-C" "doc" "man")
+ (invoke "make" "install")))
+ (replace 'check
+ (lambda* (#:key tests? #:allow-other-keys)
+ (when tests?
+ (invoke "make" "test")))))))
+ (native-inputs (list guile-3.0 pandoc))
+ (home-page "https://github.com/ft/guile-tap")
+ (synopsis "Guile test framework that emits TAP output")
+ (description
+ "guile-tap is a library for GNU Guile that implements a framework for
+specifying test cases that emit output that adheres to the Test Anything
+Protocol (TAP). It comes with an experimental harness (tap-harness).")
+ (license license:bsd-2)))
+
+(define-public guile2.0-tap
+ (package
+ (inherit guile-tap)
+ (name "guile2.0-tap")
+ (native-inputs (list guile-2.0))))
+
+(define-public guile2.2-tap
+ (package
+ (inherit guile-tap)
+ (name "guile2.2-tap")
+ (native-inputs (list guile-2.2))))
--
2.36.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#55922] [PATCH] gnu: Add guile-termios.
2022-06-12 22:21 ` Antero Mejr via Guix-patches via
@ 2022-06-16 21:15 ` Ludovic Courtès
0 siblings, 0 replies; 7+ messages in thread
From: Ludovic Courtès @ 2022-06-16 21:15 UTC (permalink / raw)
To: Antero Mejr; +Cc: 55922
Hi Antero,
Looks like we’re almost done; some comments inline below.
Antero Mejr <antero@mailbox.org> skribis:
> * gnu/packages/guile-xyz.scm (guile-termios): New variable.
Note that all the relevant variables should be listed here.
> +(define-public guile2.0-termios
> + (package
> + (inherit guile-termios)
> + (name "guile2.0-termios")
> + (native-inputs (list guile-2.0))))
> +
> +(define-public guile2.2-termios
> + (package
Unless there really is a need for them, you can drop them. It’s
reasonable to assume 3.0 as the default for new code.
> +(define-public guile-tap
> + (package
> + (name "guile-tap")
> + (version "0.4.6")
Could you make it a separate patch, and also remove the 2.0/2.2
variants?
By convention we usually add one package per patch:
https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html
Thanks in advance!
Ludo’.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#55922] [PATCH 1/2] gnu: Add guile-termios.
2022-06-12 10:04 [bug#55922] [PATCH] gnu: Add guile-termios Antero Mejr via Guix-patches via
2022-06-12 15:47 ` Maxime Devos
2022-06-12 22:21 ` Antero Mejr via Guix-patches via
@ 2022-06-16 21:53 ` Antero Mejr via Guix-patches via
2022-06-16 21:53 ` [bug#55922] [PATCH 2/2] gnu: Add guile-tap Antero Mejr via Guix-patches via
2022-06-17 20:53 ` bug#55922: [PATCH] gnu: Add guile-termios Ludovic Courtès
2 siblings, 2 replies; 7+ messages in thread
From: Antero Mejr via Guix-patches via @ 2022-06-16 21:53 UTC (permalink / raw)
To: 55922
* gnu/packages/guile-xyz.scm (guile-termios): New variable.
---
gnu/packages/guile-xyz.scm | 44 ++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index c6f73a38e9..10065ff1da 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -41,6 +41,7 @@
;;; Copyright © 2021, 2022 Artyom V. Poptsov <poptsov.artyom@gmail.com>
;;; Copyright © 2022 Maxime Devos <maximedevos@telenet.be>
;;; Copyright © 2022 Zhu Zihao <all_but_last@163.com>
+;;; Copyright © 2022 Antero Mejr <antero@mailbox.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -83,6 +84,7 @@ (define-module (gnu packages guile-xyz)
#:use-module (gnu packages gstreamer)
#:use-module (gnu packages gtk)
#:use-module (gnu packages guile)
+ #:use-module (gnu packages haskell-xyz)
#:use-module (gnu packages hurd)
#:use-module (gnu packages image)
#:use-module (gnu packages imagemagick)
@@ -5019,3 +5021,45 @@ (define-public lokke
in two different guises.")
;; Dual license: LGPLv2.1+ or EPLv1.0+ at the user's option.
(license (list license:lgpl2.1+ license:epl1.0)))))
+
+(define-public guile-termios
+ (package
+ (name "guile-termios")
+ (version "0.6.4")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ft/guile-termios")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "020p3c84z09wyyb6gfzj2x6q2rfmvas7c92fcm2hhg8z1q60sqkg"))))
+ (build-system gnu-build-system)
+ (arguments
+ (list #:phases
+ #~(modify-phases %standard-phases
+ (replace 'configure
+ (lambda _
+ (substitute* "Makefile"
+ (("CC = cc") (string-append "CC="
+ #$(cc-for-target)))
+ (("PREFIX = /usr/local") (string-append "PREFIX="
+ #$output)))))
+ (replace 'build
+ (lambda _
+ (invoke "make")
+ (invoke "make" "-C" "doc" "man")
+ (invoke "make" "install")))
+ (replace 'check
+ (lambda* (#:key tests? #:allow-other-keys)
+ (when tests?
+ (invoke "make" "test")))))))
+ (native-inputs (list guile-3.0 guile-tap pandoc perl perl-io-tty))
+ (home-page "https://github.com/ft/guile-termios")
+ (synopsis "POSIX termios interface for GNU Guile")
+ (description
+ "To query and change settings of serial devices on POSIX systems, the
+termios API is used. GNU Guile doesn't have an interface for that built in.
+This module implements this interface by use of Guile's dynamic FFI.")
+ (license license:bsd-2)))
--
2.36.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#55922] [PATCH 2/2] gnu: Add guile-tap.
2022-06-16 21:53 ` [bug#55922] [PATCH 1/2] " Antero Mejr via Guix-patches via
@ 2022-06-16 21:53 ` Antero Mejr via Guix-patches via
2022-06-17 20:53 ` bug#55922: [PATCH] gnu: Add guile-termios Ludovic Courtès
1 sibling, 0 replies; 7+ messages in thread
From: Antero Mejr via Guix-patches via @ 2022-06-16 21:53 UTC (permalink / raw)
To: 55922
* gnu/packages/guile-xyz.scm (guile-tap): New variable.
---
gnu/packages/guile-xyz.scm | 40 ++++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 10065ff1da..7afc429d00 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -5063,3 +5063,43 @@ (define-public guile-termios
termios API is used. GNU Guile doesn't have an interface for that built in.
This module implements this interface by use of Guile's dynamic FFI.")
(license license:bsd-2)))
+
+(define-public guile-tap
+ (package
+ (name "guile-tap")
+ (version "0.4.6")
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/ft/guile-tap")
+ (commit (string-append "v" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "04ip5cbvsjjcicsri813f4711yh7db6fvc2px4788rl8p1iqvi6x"))))
+ (build-system gnu-build-system)
+ (arguments
+ (list #:phases
+ #~(modify-phases %standard-phases
+ (replace 'configure
+ (lambda _
+ (substitute* "Makefile"
+ (("PREFIX = /usr/local") (string-append "PREFIX="
+ #$output)))))
+ (replace 'build
+ (lambda _
+ (invoke "make")
+ (invoke "make" "-C" "doc" "man")
+ (invoke "make" "install")))
+ (replace 'check
+ (lambda* (#:key tests? #:allow-other-keys)
+ (when tests?
+ (invoke "make" "test")))))))
+ (native-inputs (list guile-3.0 pandoc))
+ (home-page "https://github.com/ft/guile-tap")
+ (synopsis "Guile test framework that emits TAP output")
+ (description
+ "guile-tap is a library for GNU Guile that implements a framework for
+specifying test cases that emit output that adheres to the Test Anything
+Protocol (TAP). It comes with an experimental harness (tap-harness).")
+ (license license:bsd-2)))
--
2.36.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* bug#55922: [PATCH] gnu: Add guile-termios.
2022-06-16 21:53 ` [bug#55922] [PATCH 1/2] " Antero Mejr via Guix-patches via
2022-06-16 21:53 ` [bug#55922] [PATCH 2/2] gnu: Add guile-tap Antero Mejr via Guix-patches via
@ 2022-06-17 20:53 ` Ludovic Courtès
1 sibling, 0 replies; 7+ messages in thread
From: Ludovic Courtès @ 2022-06-17 20:53 UTC (permalink / raw)
To: Antero Mejr; +Cc: 55922-done
Hi,
Antero Mejr <antero@mailbox.org> skribis:
> * gnu/packages/guile-xyz.scm (guile-termios): New variable.
[...]
> * gnu/packages/guile-xyz.scm (guile-tap): New variable.
Applied both, but in reverse order (guile-tap first, since guile-termios
depends on it.)
Thanks!
Ludo’.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-06-17 20:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-12 10:04 [bug#55922] [PATCH] gnu: Add guile-termios Antero Mejr via Guix-patches via
2022-06-12 15:47 ` Maxime Devos
2022-06-12 22:21 ` Antero Mejr via Guix-patches via
2022-06-16 21:15 ` Ludovic Courtès
2022-06-16 21:53 ` [bug#55922] [PATCH 1/2] " Antero Mejr via Guix-patches via
2022-06-16 21:53 ` [bug#55922] [PATCH 2/2] gnu: Add guile-tap Antero Mejr via Guix-patches via
2022-06-17 20:53 ` bug#55922: [PATCH] gnu: Add guile-termios Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.