all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#53868] [PATCH] gnu: clojure-data-xml: Fix test suite
@ 2022-02-08  5:28 Ryan Sundberg via Guix-patches via
  2022-02-08  5:48 ` [bug#53868] Duplicate of bug 53860 Ryan Sundberg via Guix-patches via
  2022-02-08 10:53 ` bug#53868: [PATCH] gnu: clojure-data-xml: Fix test suite Julien Lepiller
  0 siblings, 2 replies; 3+ messages in thread
From: Ryan Sundberg via Guix-patches via @ 2022-02-08  5:28 UTC (permalink / raw)
  To: 53868; +Cc: Ryan Sundberg

Removes clojurescript related tests that interfere with the JDK clojure
test suite, causing it to fail.

* gnu/packages/clojure.scm (clojure-data-xml)[arguments]: Add
'delete-cljs-tests phase
---
 gnu/packages/clojure.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
index 2a9ad90740..3ee4941ddb 100644
--- a/gnu/packages/clojure.scm
+++ b/gnu/packages/clojure.scm
@@ -441,8 +441,14 @@ (define-public clojure-data-xml
     (build-system clojure-build-system)
     (arguments
      '(#:source-dirs '("src/main/clojure")
-       #:test-dirs '("src/test/clojure")
-       #:doc-dirs '()))
+       #:test-dirs '("src/test/clojure" "src/test/resources")
+       #:doc-dirs '()
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'delete-cljs-tests
+                     (lambda _
+                       (delete-file "src/test/resources/clojure/data/xml/cljs_testsuite.clj")
+                       (delete-file "src/test/clojure/clojure/data/xml/test_cljs.clj"))))))
     (propagated-inputs (list clojure-data-codec))
     (synopsis "Clojure library for reading and writing XML data")
     (description "@code{data.xml} is a Clojure library for reading and writing
-- 
2.34.0





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#53868] Duplicate of bug 53860
  2022-02-08  5:28 [bug#53868] [PATCH] gnu: clojure-data-xml: Fix test suite Ryan Sundberg via Guix-patches via
@ 2022-02-08  5:48 ` Ryan Sundberg via Guix-patches via
  2022-02-08 10:53 ` bug#53868: [PATCH] gnu: clojure-data-xml: Fix test suite Julien Lepiller
  1 sibling, 0 replies; 3+ messages in thread
From: Ryan Sundberg via Guix-patches via @ 2022-02-08  5:48 UTC (permalink / raw)
  To: 53868

This patch is a duplicate of 
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=53860
with a different approach that only disables the specific failing tests.




^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#53868: [PATCH] gnu: clojure-data-xml: Fix test suite
  2022-02-08  5:28 [bug#53868] [PATCH] gnu: clojure-data-xml: Fix test suite Ryan Sundberg via Guix-patches via
  2022-02-08  5:48 ` [bug#53868] Duplicate of bug 53860 Ryan Sundberg via Guix-patches via
@ 2022-02-08 10:53 ` Julien Lepiller
  1 sibling, 0 replies; 3+ messages in thread
From: Julien Lepiller @ 2022-02-08 10:53 UTC (permalink / raw)
  Cc: Ryan Sundberg, 53868-done

Le Mon,  7 Feb 2022 21:28:13 -0800,
Ryan Sundberg via Guix-patches via <guix-patches@gnu.org> a écrit :

> Removes clojurescript related tests that interfere with the JDK
> clojure test suite, causing it to fail.
> 
> * gnu/packages/clojure.scm (clojure-data-xml)[arguments]: Add
> 'delete-cljs-tests phase
> ---
>  gnu/packages/clojure.scm | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
> index 2a9ad90740..3ee4941ddb 100644
> --- a/gnu/packages/clojure.scm
> +++ b/gnu/packages/clojure.scm
> @@ -441,8 +441,14 @@ (define-public clojure-data-xml
>      (build-system clojure-build-system)
>      (arguments
>       '(#:source-dirs '("src/main/clojure")
> -       #:test-dirs '("src/test/clojure")
> -       #:doc-dirs '()))
> +       #:test-dirs '("src/test/clojure" "src/test/resources")
> +       #:doc-dirs '()
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'delete-cljs-tests
> +                     (lambda _
> +                       (delete-file
> "src/test/resources/clojure/data/xml/cljs_testsuite.clj")
> +                       (delete-file
> "src/test/clojure/clojure/data/xml/test_cljs.clj"))))))
> (propagated-inputs (list clojure-data-codec)) (synopsis "Clojure
> library for reading and writing XML data") (description
> "@code{data.xml} is a Clojure library for reading and writing

Thanks for the patch, pushed to master as
6d357541021578914eba7bb33d2529a6744de36d.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-02-08 11:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-08  5:28 [bug#53868] [PATCH] gnu: clojure-data-xml: Fix test suite Ryan Sundberg via Guix-patches via
2022-02-08  5:48 ` [bug#53868] Duplicate of bug 53860 Ryan Sundberg via Guix-patches via
2022-02-08 10:53 ` bug#53868: [PATCH] gnu: clojure-data-xml: Fix test suite Julien Lepiller

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.