[bug#48484] Removed unused PostgreSQL packages

[bug#48484] Removed unused PostgreSQL packages

[Leo Famulari]

Currently we have packages for PostgreSQL 9.6, 10, 11, and 13.

Versions 9.6 and 11 are not used in Guix. So I propose that we remove
them.

[bug#48484] [PATCH 1/2] gnu: Remove PostgreSQL 9.

[Leo Famulari]

* gnu/packages/databases.scm (postgresql-9.6): Remove variable.
---
 gnu/packages/databases.scm | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 1a6d6f13d5..5b6504b5c1 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -1123,18 +1123,6 @@ pictures, sounds, or video.")
                (base32
                 "0v5jahkqm6gkq67s4bac3h7297bscn2ab6y128idi73cc1qq1wjs"))))))
 
-(define-public postgresql-9.6
-  (package
-    (inherit postgresql-10)
-    (version "9.6.22")
-    (source (origin
-              (inherit (package-source postgresql-10))
-              (uri (string-append "https://ftp.postgresql.org/pub/source/v"
-                                  version "/postgresql-" version ".tar.bz2"))
-              (sha256
-               (base32
-                "0c19kzrj5ib5ygmavf5d6qvxdwrxzzz6jz1r2dl5b815208cscix"))))))
-
 (define-public postgresql postgresql-13)
 
 (define-public pgloader
-- 
2.31.1

[bug#48484] [PATCH 2/2] gnu: Remove PostgreSQL 11.

[Leo Famulari]

* gnu/packages/databases.scm (postgresql-11): Remove variable.
(postgresql-10): Inherit from postgresql-13.
---
 gnu/packages/databases.scm | 17 ++---------------
 1 file changed, 2 insertions(+), 15 deletions(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 5b6504b5c1..96033bc020 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -1098,25 +1098,12 @@ pictures, sounds, or video.")
                 "18dliq7h2l8irffhyyhdmfwx3si515q6gds3cxdjb9n7m17lbn9w"))
               (patches (search-patches "postgresql-disable-resolve_symlinks.patch"))))))
 
-(define-public postgresql-11
-  (package
-    (inherit postgresql-13)
-    (name "postgresql")
-    (version "11.12")
-    (source (origin
-              (inherit (package-source postgresql-13))
-              (uri (string-append "https://ftp.postgresql.org/pub/source/v"
-                                  version "/postgresql-" version ".tar.bz2"))
-              (sha256
-               (base32
-                "016bacpmqxc676ipzc1l8zv1jj44mjz7dv7jhqazg3ibdfqxiyc7"))))))
-
 (define-public postgresql-10
   (package
-    (inherit postgresql-11)
+    (inherit postgresql-13)
     (version "10.17")
     (source (origin
-              (inherit (package-source postgresql-11))
+              (inherit (package-source postgresql-13))
               (uri (string-append "https://ftp.postgresql.org/pub/source/v"
                                   version "/postgresql-" version ".tar.bz2"))
               (sha256
-- 
2.31.1

[bug#48484] Removed unused PostgreSQL packages

[Björn Höfling]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

On Mon, 17 May 2021 15:22:47 -0400
Leo Famulari <leo@famulari.name> wrote:

> Currently we have packages for PostgreSQL 9.6, 10, 11, and 13.
> 
> Versions 9.6 and 11 are not used in Guix. So I propose that we remove
> them.

These versions are still supported [0], 9.6 until 2021-11-11. Although
they have no dependencies, people could still use them. I would keep
them until EOL.

Björn


[0] https://en.wikipedia.org/wiki/PostgreSQL#Release_history

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[bug#48484] Removed unused PostgreSQL packages

[Christopher Baines]

Leo Famulari <leo@famulari.name> writes:

> Currently we have packages for PostgreSQL 9.6, 10, 11, and 13.
>
> Versions 9.6 and 11 are not used in Guix. So I propose that we remove
> them.

In terms of reasons to keep them, the PostgreSQL service configuration
for Guix pushes users to specify a specific postgresql package, so
removing particular versions could break users configuration.

While it is possible to upgrade, I'm not aware of any guidance about the
particulars with doing this for Guix, so I'd be hesitant to remove old
supported versions, until there's something to point at which users can
follow to upgrade.

[bug#48484] Removed unused PostgreSQL packages

[Mathieu Othacehe]

Hello,

> While it is possible to upgrade, I'm not aware of any guidance about the
> particulars with doing this for Guix, so I'd be hesitant to remove old
> supported versions, until there's something to point at which users can
> follow to upgrade.

I agree with Chris and Björn and think that we can close this one for
now if it's OK for you Leo.

Thanks,

Mathieu

[bug#48484] Removed unused PostgreSQL packages

[Maxim Cournoyer]

Hello Leo,

Mathieu Othacehe <othacehe@gnu.org> writes:

> Hello,
>
>> While it is possible to upgrade, I'm not aware of any guidance about the
>> particulars with doing this for Guix, so I'd be hesitant to remove old
>> supported versions, until there's something to point at which users can
>> follow to upgrade.
>
> I agree with Chris and Björn and think that we can close this one for
> now if it's OK for you Leo.

It's been 50 weeks; perhaps the old postgresql are now EOL?  In which
case I'd say go ahead with the pruning.

Thanks,

Maxim