all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#44049] [PATCH] build-system/haskell: Disable parallel builds.
@ 2020-10-17 22:10 zimoun
  2020-10-18 22:11 ` bug#43843: " Marius Bakke
  0 siblings, 1 reply; 2+ messages in thread
From: zimoun @ 2020-10-17 22:10 UTC (permalink / raw)
  To: 44049; +Cc: zimoun, marius

Fixes <https://bugs.gnu.org/43843>.

PARALLEL-BUILD? introduced by commit 67cb9fa2357026ee42ec5bb0923ec4dc4a43abe2
leads to unreproducibility.  Instead of reverting, default is set to #false
which allows user to locally build with parallelism.

* guix/build-system/haskell.scm (haskell-build): Turn off PARALLEL-BUILD? by
default.
---
 guix/build-system/haskell.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/guix/build-system/haskell.scm b/guix/build-system/haskell.scm
index 8304e3b222..87085a50b0 100644
--- a/guix/build-system/haskell.scm
+++ b/guix/build-system/haskell.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2015 Federico Beffa <beffa@fbengineering.ch>
 ;;; Copyright © 2020 Timothy Sample <samplet@ngyro.com>
+;;; Copyright © 2020 Simon Tournier <zimon.toutoune@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -115,13 +116,17 @@ version REVISION."
                                (cons name propagated-names))))))
                        extra-directories))))))))
 
+;;; PARALLEL-BUILD? introduced by commit
+;;; 67cb9fa2357026ee42ec5bb0923ec4dc4a43abe2 leads to unreproducibility.
+;;; Instead of reverting, default is set to #false which allows user to
+;;; locally build with parallelism. See <http://issues.guix.gnu.org/43843#3>.
 (define* (haskell-build store name inputs
                         #:key source
                         (haddock? #t)
                         (haddock-flags ''())
                         (tests? #t)
                         (test-target "test")
-                        (parallel-build? #t)
+                        (parallel-build? #f)
                         (configure-flags ''())
                         (extra-directories ''())
                         (phases '(@ (guix build haskell-build-system)

base-commit: d14221bf65cfbe7f8f5b7cac44132087cab70bf5
-- 
2.28.0





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#43843: [PATCH] build-system/haskell: Disable parallel builds.
  2020-10-17 22:10 [bug#44049] [PATCH] build-system/haskell: Disable parallel builds zimoun
@ 2020-10-18 22:11 ` Marius Bakke
  0 siblings, 0 replies; 2+ messages in thread
From: Marius Bakke @ 2020-10-18 22:11 UTC (permalink / raw)
  To: zimoun, 44049-done; +Cc: 43843-done

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

zimoun <zimon.toutoune@gmail.com> writes:

> Fixes <https://bugs.gnu.org/43843>.
>
> PARALLEL-BUILD? introduced by commit 67cb9fa2357026ee42ec5bb0923ec4dc4a43abe2
> leads to unreproducibility.  Instead of reverting, default is set to #false
> which allows user to locally build with parallelism.
>
> * guix/build-system/haskell.scm (haskell-build): Turn off PARALLEL-BUILD? by
> default.

Thanks!  I shortened the comment a little and pushed to staging in
19d42e0e23a7f90ac2dcc1c279bd23a967ff0314.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-18 22:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-17 22:10 [bug#44049] [PATCH] build-system/haskell: Disable parallel builds zimoun
2020-10-18 22:11 ` bug#43843: " Marius Bakke

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.