[bug#43765] [PATCH] gnu: Add go-github-com-errata-ai-vale.

[bug#43765] [PATCH] gnu: Add go-github-com-errata-ai-vale.

[Gabriel Arazas]

One of my favorite writing tools and also my first dive into Go thru
packaging this program.
I do have a couple of questions/feedback regarding packaging Go packages:

* When do I add the missing dependencies? Is it required or just a
preference? Are indirect dependencies included to be listed?
I noticed that some of the Go packages have incomplete
depedencies on the package definition and you can still build the
Go packages even if you remove it (or at least my package does that).

* I feel like there's a missing section in the documentation
regarding naming Go packages since I noticed there are some
inconsistencies. For example, there are packages that starts with 'go-github.com'
and 'go-github-com'. (To be fair, I only found like 2 packages that has
different naming so far.)

[bug#43766] [PATCH] gnu: Add go-github-com-errata-ai-vale.

[Gabriel Arazas]

* gnu/packages/textutils.scm (go-github-com-errata-ai-vale): New variable.
---
 gnu/packages/textutils.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
index 6653d01a31..f84fbc52ba 100644
--- a/gnu/packages/textutils.scm
+++ b/gnu/packages/textutils.scm
@@ -52,6 +52,7 @@
   #:use-module (gnu packages base)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages gcc)
+  #:use-module (gnu packages golang)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages java)
   #:use-module (gnu packages ncurses)
@@ -1173,3 +1174,35 @@ This package provides Python bindings.")
     (description "@command{aha} (Ansi Html Adapter) converts ANSI escape sequences
 of a Unix terminal to HTML code.")
     (license (list license:lgpl2.0+ license:mpl1.1))))
+
+(define-public go-github-com-errata-ai-vale
+  (package
+    (name "go-github-com-errata-ai-vale")
+    (version "2.4.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/errata-ai/vale")
+             (commit (string-append "v" version))))
+       (sha256
+        (base32 "0d07fwha2220m8j24h527xl0gnl3svvyaywflgk5292d6g49ach2"))
+       (file-name (git-file-name name version))))
+    (build-system go-build-system)
+    (native-inputs
+     `(("github.com/sp13/afero" ,go-github-com-spf13-afero)
+       ("github.com/urfave/cli" ,go-github-com-urfave-cli)
+       ("github.com/olekukonko/tablewriter" ,go-github-com-olekukonko-tablewriter)
+       ("github.com/mitchellh/mapstructure" ,go-github-com-mitchellh-mapstructure)))
+    (arguments
+     `(#:import-path "github.com/errata-ai/vale"
+       #:install-source? #f))
+    (home-page "https://github.com/errata-ai/vale")
+    (synopsis "Fully customizable syntax-aware linter that focuses on your style")
+    (description
+     "Vale is a fully extensible linter that focuses on your own writing style
+by making use of rules in individual YAML files.  It is syntax-aware on markup
+languages such as HTML, Markdown, Asciidoc, and reStructuredText.  The community
+around it also has a list of style guides implemented with Vale in
+@url{https://github.com/errata-ai/styles, their styles repo}.")
+    (license license:expat)))
-- 
2.28.0

bug#43766: [PATCH] gnu: Add go-github-com-errata-ai-vale.

[Ludovic Courtès]

Hi,

Gabriel Arazas <foo.dogsquared@gmail.com> skribis:

> * gnu/packages/textutils.scm (go-github-com-errata-ai-vale): New variable.

Applied, thanks!

Ludo’.

bug#43766: closed (Re: [bug#43766] [PATCH] gnu: Add go-github-com-errata-ai-vale.)

[GNU bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Your bug report

#43766: [PATCH] gnu: Add go-github-com-errata-ai-vale.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 43766@debbugs.gnu.org.

-- 
43766: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43766
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

[-- Attachment #2: Type: message/rfc822, Size: 2652 bytes --]

From: "Ludovic Courtès" <ludo@gnu.org>
To: Gabriel Arazas <foo.dogsquared@gmail.com>
Cc: 43766-done@debbugs.gnu.org
Subject: Re: [bug#43766] [PATCH] gnu: Add go-github-com-errata-ai-vale.
Date: Mon, 02 Nov 2020 14:53:13 +0100
Message-ID: <87r1pblvau.fsf@gnu.org>

Hi,

Gabriel Arazas <foo.dogsquared@gmail.com> skribis:

> * gnu/packages/textutils.scm (go-github-com-errata-ai-vale): New variable.

Applied, thanks!

Ludo’.


[-- Attachment #3: Type: message/rfc822, Size: 7312 bytes --]

From: Gabriel Arazas <foo.dogsquared@gmail.com>
To: guix-patches@gnu.org
Cc: Gabriel Arazas <foo.dogsquared@gmail.com>
Subject: [PATCH] gnu: Add go-github-com-errata-ai-vale.
Date: Sat,  3 Oct 2020 01:13:17 +0800
Message-ID: <20201002171317.1680-2-foo.dogsquared@gmail.com>

* gnu/packages/textutils.scm (go-github-com-errata-ai-vale): New variable.
---
 gnu/packages/textutils.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
index 6653d01a31..f84fbc52ba 100644
--- a/gnu/packages/textutils.scm
+++ b/gnu/packages/textutils.scm
@@ -52,6 +52,7 @@
   #:use-module (gnu packages base)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages gcc)
+  #:use-module (gnu packages golang)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages java)
   #:use-module (gnu packages ncurses)
@@ -1173,3 +1174,35 @@ This package provides Python bindings.")
     (description "@command{aha} (Ansi Html Adapter) converts ANSI escape sequences
 of a Unix terminal to HTML code.")
     (license (list license:lgpl2.0+ license:mpl1.1))))
+
+(define-public go-github-com-errata-ai-vale
+  (package
+    (name "go-github-com-errata-ai-vale")
+    (version "2.4.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/errata-ai/vale")
+             (commit (string-append "v" version))))
+       (sha256
+        (base32 "0d07fwha2220m8j24h527xl0gnl3svvyaywflgk5292d6g49ach2"))
+       (file-name (git-file-name name version))))
+    (build-system go-build-system)
+    (native-inputs
+     `(("github.com/sp13/afero" ,go-github-com-spf13-afero)
+       ("github.com/urfave/cli" ,go-github-com-urfave-cli)
+       ("github.com/olekukonko/tablewriter" ,go-github-com-olekukonko-tablewriter)
+       ("github.com/mitchellh/mapstructure" ,go-github-com-mitchellh-mapstructure)))
+    (arguments
+     `(#:import-path "github.com/errata-ai/vale"
+       #:install-source? #f))
+    (home-page "https://github.com/errata-ai/vale")
+    (synopsis "Fully customizable syntax-aware linter that focuses on your style")
+    (description
+     "Vale is a fully extensible linter that focuses on your own writing style
+by making use of rules in individual YAML files.  It is syntax-aware on markup
+languages such as HTML, Markdown, Asciidoc, and reStructuredText.  The community
+around it also has a list of style guides implemented with Vale in
+@url{https://github.com/errata-ai/styles, their styles repo}.")
+    (license license:expat)))
-- 
2.28.0

bug#43765: closed (Re: [bug#43766] [PATCH] gnu: Add go-github-com-errata-ai-vale.)

[GNU bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

Your bug report

#43766: [PATCH] gnu: Add go-github-com-errata-ai-vale.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 43765@debbugs.gnu.org.

-- 
43766: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43766
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

[-- Attachment #2: Type: message/rfc822, Size: 2652 bytes --]

From: "Ludovic Courtès" <ludo@gnu.org>
To: Gabriel Arazas <foo.dogsquared@gmail.com>
Cc: 43766-done@debbugs.gnu.org
Subject: Re: [bug#43766] [PATCH] gnu: Add go-github-com-errata-ai-vale.
Date: Mon, 02 Nov 2020 14:53:13 +0100
Message-ID: <87r1pblvau.fsf@gnu.org>

Hi,

Gabriel Arazas <foo.dogsquared@gmail.com> skribis:

> * gnu/packages/textutils.scm (go-github-com-errata-ai-vale): New variable.

Applied, thanks!

Ludo’.


[-- Attachment #3: Type: message/rfc822, Size: 5558 bytes --]

From: Gabriel Arazas <foo.dogsquared@gmail.com>
To: guix-patches@gnu.org
Subject: [PATCH] gnu: Add go-github-com-errata-ai-vale.
Date: Sat,  3 Oct 2020 01:13:16 +0800
Message-ID: <20201002171317.1680-1-foo.dogsquared@gmail.com>

One of my favorite writing tools and also my first dive into Go thru
packaging this program.
I do have a couple of questions/feedback regarding packaging Go packages:

* When do I add the missing dependencies? Is it required or just a
preference? Are indirect dependencies included to be listed?
I noticed that some of the Go packages have incomplete
depedencies on the package definition and you can still build the
Go packages even if you remove it (or at least my package does that).

* I feel like there's a missing section in the documentation
regarding naming Go packages since I noticed there are some
inconsistencies. For example, there are packages that starts with 'go-github.com'
and 'go-github-com'. (To be fair, I only found like 2 packages that has
different naming so far.)