all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#43108] [PATCH] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1.
@ 2020-08-30  7:50 Michael Rohleder
  2020-09-01 19:27 ` bug#43108: " Mathieu Othacehe
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Rohleder @ 2020-08-30  7:50 UTC (permalink / raw)
  To: 43108; +Cc: Michael Rohleder

* gnu/packages/emacs-xyz.scm (emacs-elisp-refs)[arguments]:
Add phase to disable failing test "elisp-refs-next-match" on emacs27.
---
My ert-runner fu is not good enough for a better hack. I tried
'("ert-runner" "-p" "!elisp-refs-next-match") as a test-command, but it
skipped all tests then.

 gnu/packages/emacs-xyz.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index c6d95d9b83..cfc728b53e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -14825,7 +14825,17 @@ continue.")
        ("emacs-undercover" ,emacs-undercover)))
     (arguments
      `(#:tests? #t
-       #:test-command '("ert-runner")))
+       #:test-command '("ert-runner")
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'disable-refs-next-match-test
+           ;; Hack to disable the failing test for emacs27
+           ;; https://github.com/Wilfred/elisp-refs/issues/29
+           (lambda _
+             (substitute* "test/unit-test.el"
+               (("ert-deftest elisp-refs-next-match")
+                "defun elisp-refs-next-match"))
+             #t)))))
     (home-page "https://github.com/Wilfred/elisp-refs")
     (synopsis "Find callers of elisp functions or macros")
     (description "Find references to functions, macros or variables.  Unlike a
-- 
2.28.0





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#43108: [PATCH] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1.
  2020-08-30  7:50 [bug#43108] [PATCH] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1 Michael Rohleder
@ 2020-09-01 19:27 ` Mathieu Othacehe
  0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Othacehe @ 2020-09-01 19:27 UTC (permalink / raw)
  To: Michael Rohleder; +Cc: 43108-done


Hello Michael,

> My ert-runner fu is not good enough for a better hack. I tried
> '("ert-runner" "-p" "!elisp-refs-next-match") as a test-command, but it
> skipped all tests then.

Well your hack seems to work fine :) Pushed as
a73ccefe315cd16e9d0b31a00bbd61e6cc3042f5.

Thanks,

Mathieu




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-01 19:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-30  7:50 [bug#43108] [PATCH] gnu: emacs-elisp-refs: Disable test failing on Emacs 27.1 Michael Rohleder
2020-09-01 19:27 ` bug#43108: " Mathieu Othacehe

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.