* [bug#40879] [PATCH] gnu: linux-boot: Allow to mount the root file system via nfs
@ 2020-04-26 19:21 Stefan
2020-05-02 14:22 ` bug#40879: " Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Stefan @ 2020-04-26 19:21 UTC (permalink / raw)
To: 40879
* gnu/build/linux-boot.scm (boot-system) Treat a root option with ":/" as an nfs source
and avoid to call 'canonicalize-device-spec' for it.
---
gnu/build/linux-boot.scm | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/gnu/build/linux-boot.scm b/gnu/build/linux-boot.scm
index 4fb711b8f2..05e833c0c6 100644
--- a/gnu/build/linux-boot.scm
+++ b/gnu/build/linux-boot.scm
@@ -534,10 +534,13 @@ upon error."
;; The "--root=SPEC" kernel command-line option always provides a
;; string, but the string can represent a device, a UUID, or a
;; label. So check for all three.
- (let ((root (cond ((string-prefix? "/" root) root)
- ((uuid root) => identity)
- (else (file-system-label root)))))
- (mount-root-file-system (canonicalize-device-spec root)
+ (let ((device-spec (cond ((string-prefix? "/" root) root)
+ ((uuid root) => identity)
+ ((string-contains root ":/") #f) ; nfs
+ (else (file-system-label root)))))
+ (mount-root-file-system (if device-spec
+ (canonicalize-device-spec device-spec)
+ root)
root-fs-type
#:volatile-root? volatile-root?
#:flags root-fs-flags
--
2.26.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#40879: [PATCH] gnu: linux-boot: Allow to mount the root file system via nfs
2020-04-26 19:21 [bug#40879] [PATCH] gnu: linux-boot: Allow to mount the root file system via nfs Stefan
@ 2020-05-02 14:22 ` Ludovic Courtès
2020-05-02 22:19 ` [bug#40879] " Danny Milosavljevic
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2020-05-02 14:22 UTC (permalink / raw)
To: Stefan; +Cc: 40879-done
Hi Stefan,
Stefan <stefan-guix@vodafonemail.de> skribis:
> * gnu/build/linux-boot.scm (boot-system) Treat a root option with ":/" as an nfs source
> and avoid to call 'canonicalize-device-spec' for it.
I slightly tweaked the subject line and applied, thank you!
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#40879] [PATCH] gnu: linux-boot: Allow to mount the root file system via nfs
2020-05-02 14:22 ` bug#40879: " Ludovic Courtès
@ 2020-05-02 22:19 ` Danny Milosavljevic
2020-05-04 14:11 ` Marius Bakke
0 siblings, 1 reply; 4+ messages in thread
From: Danny Milosavljevic @ 2020-05-02 22:19 UTC (permalink / raw)
To: Ludovic Courtès, Stefan; +Cc: 40879-done
[-- Attachment #1: Type: text/plain, Size: 354 bytes --]
--- a/gnu/build/linux-boot.scm
+++ b/gnu/build/linux-boot.scm
@@ -534,10 +534,13 @@ upon error."
;; The "--root=SPEC" kernel command-line option always provides a
;; string, but the string can represent a device, a UUID, or a
;; label. So check for all three.
Nitpick: Comment above it is now outdated ;)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#40879] [PATCH] gnu: linux-boot: Allow to mount the root file system via nfs
2020-05-02 22:19 ` [bug#40879] " Danny Milosavljevic
@ 2020-05-04 14:11 ` Marius Bakke
0 siblings, 0 replies; 4+ messages in thread
From: Marius Bakke @ 2020-05-04 14:11 UTC (permalink / raw)
To: Danny Milosavljevic, Ludovic Courtès, Stefan; +Cc: 40879-done
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
Danny Milosavljevic <dannym@scratchpost.org> writes:
> --- a/gnu/build/linux-boot.scm
> +++ b/gnu/build/linux-boot.scm
> @@ -534,10 +534,13 @@ upon error."
> ;; The "--root=SPEC" kernel command-line option always provides a
> ;; string, but the string can represent a device, a UUID, or a
> ;; label. So check for all three.
>
> Nitpick: Comment above it is now outdated ;)
Can you update it? :-)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-04 17:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-26 19:21 [bug#40879] [PATCH] gnu: linux-boot: Allow to mount the root file system via nfs Stefan
2020-05-02 14:22 ` bug#40879: " Ludovic Courtès
2020-05-02 22:19 ` [bug#40879] " Danny Milosavljevic
2020-05-04 14:11 ` Marius Bakke
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.