* [bug#40350] [PATCH] ui: Mention that changes to package definitions can cause "upgrades".
@ 2020-03-31 15:15 Leo Famulari
2020-04-01 21:03 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Leo Famulari @ 2020-03-31 15:15 UTC (permalink / raw)
To: 40350
* guix/ui.scm (show-manifest-transaction)[upgrade-string]: Use the
package name in UI message.
---
guix/ui.scm | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/guix/ui.scm b/guix/ui.scm
index 1e24fe5dca..20b1e79ca9 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -14,6 +14,7 @@
;;; Copyright © 2019 Chris Marusich <cmmarusich@gmail.com>
;;; Copyright © 2019 Tobias Geerinckx-Rice <me@tobias.gr>
;;; Copyright © 2019 Simon Tournier <zimon.toutoune@gmail.com>
+;;; Copyright © 2020 Leo Famulari <leo@famulari.name>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -1162,11 +1163,13 @@ separator between subsequent columns."
name
(string-append name ":" output)))
names outputs)
- (map (lambda (old new)
+ (map (lambda (old new name)
(if (string=? old new)
- (G_ "(dependencies changed)")
+ (format
+ (G_ "(dependencies or ~a package recipe changed)")
+ name)
(string-append old " " → " " new)))
- old-version new-version))
+ old-version new-version names))
#:initial-indent 3))
(let-values (((remove install upgrade downgrade)
--
2.26.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#40350] [PATCH] ui: Mention that changes to package definitions can cause "upgrades".
2020-03-31 15:15 [bug#40350] [PATCH] ui: Mention that changes to package definitions can cause "upgrades" Leo Famulari
@ 2020-04-01 21:03 ` Ludovic Courtès
2020-04-01 21:13 ` Leo Famulari
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2020-04-01 21:03 UTC (permalink / raw)
To: Leo Famulari; +Cc: 40350
Hi,
Leo Famulari <leo@famulari.name> skribis:
> * guix/ui.scm (show-manifest-transaction)[upgrade-string]: Use the
> package name in UI message.
[...]
> (if (string=? old new)
> - (G_ "(dependencies changed)")
> + (format
> + (G_ "(dependencies or ~a package recipe changed)")
Is that not implied in a way?
If it is, how about something shorter like:
(dependencies or package changed)
?
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#40350] [PATCH] ui: Mention that changes to package definitions can cause "upgrades".
2020-04-01 21:03 ` Ludovic Courtès
@ 2020-04-01 21:13 ` Leo Famulari
2020-04-02 8:05 ` bug#40350: " Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Leo Famulari @ 2020-04-01 21:13 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 40350
On Wed, Apr 01, 2020 at 11:03:22PM +0200, Ludovic Courtès wrote:
> Is that not implied in a way?
It is, but I think we will still get some confused users asking about
it.
> If it is, how about something shorter like:
>
> (dependencies or package changed)
Yeah, I think that's okay.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#40350: [PATCH] ui: Mention that changes to package definitions can cause "upgrades".
2020-04-01 21:13 ` Leo Famulari
@ 2020-04-02 8:05 ` Ludovic Courtès
0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2020-04-02 8:05 UTC (permalink / raw)
To: Leo Famulari; +Cc: 40350-done
Hi,
Leo Famulari <leo@famulari.name> skribis:
> On Wed, Apr 01, 2020 at 11:03:22PM +0200, Ludovic Courtès wrote:
>> Is that not implied in a way?
>
> It is, but I think we will still get some confused users asking about
> it.
>
>> If it is, how about something shorter like:
>>
>> (dependencies or package changed)
>
> Yeah, I think that's okay.
OK, done!
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-02 8:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-31 15:15 [bug#40350] [PATCH] ui: Mention that changes to package definitions can cause "upgrades" Leo Famulari
2020-04-01 21:03 ` Ludovic Courtès
2020-04-01 21:13 ` Leo Famulari
2020-04-02 8:05 ` bug#40350: " Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.