all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Jakub Kądziołka" <kuba@kadziolka.net>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 39579@debbugs.gnu.org
Subject: [bug#39579] [PATCH 2/3] gnu: osinfo-db: Add osinfo-db.
Date: Sun, 16 Feb 2020 20:13:04 +0100	[thread overview]
Message-ID: <20200216191304.coce5czm3ayji3dc@gravity> (raw)
In-Reply-To: <20200212163711.17468-2-brice@waegenei.re>

[-- Attachment #1: Type: text/plain, Size: 1809 bytes --]

On Wed, Feb 12, 2020 at 05:37:10PM +0100, Brice Waegeneire wrote:
> +(define-public osinfo-db
> +  (package
> +    (name "osinfo-db")
> +    (version "20200203")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://releases.pagure.org/libosinfo/osinfo-db-"
> +                                  version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "1zjq1dhlci00j17dij7s3l30hybzmaykpk5b6bd5xbllp745njn5"))))
> +    (build-system trivial-build-system)
> +    (arguments
> +     `(#:modules ((guix build utils))
> +       #:builder
> +       (begin
> +         (use-modules (guix build utils))
> +         (let* ((out (assoc-ref %outputs "out"))
> +                (osinfo-dir (string-append out "/share/osinfo"))
> +                (source (assoc-ref %build-inputs "source")))
> +           (set-path-environment-variable
> +            "PATH" '("bin")
> +            (list (assoc-ref %build-inputs "osinfo-db-tools")))
> +           (mkdir-p osinfo-dir)
> +           (invoke "osinfo-db-import" "--dir" osinfo-dir source)
Wouldn't it be simpler to invoke osinfo-db-import with a full path to
the binary instead of adding to $PATH?

> +           #t))))
> +    (native-inputs
> +     `(("intltool" ,intltool)
> +       ("osinfo-db-tools" ,osinfo-db-tools)))
> +    (home-page "https://gitlab.com/libosinfo/osinfo-db")
> +    (synopsis "Database of information about operating systems")
> +    (description "Osinfo-db provides the database files for use with the
> +libosinfo library. It provides information about guest operating systems for
                    ^^
Use two spaces after a sentence. (please run guix lint on your packages)

> +use with virtualization provisioning tools")
> +    (license license:lgpl2.0+)))

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-02-16 19:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-12 16:30 [bug#39579] [PATCH 0/3] Include operating systems list in virt-manager Brice Waegeneire
2020-02-12 16:37 ` [bug#39579] [PATCH 1/3] gnu: osinfo-db-tools: Add osinfo-db-tools Brice Waegeneire
2020-02-16 19:10   ` Jakub Kądziołka
2020-02-16 19:56     ` Jakub Kądziołka
2020-02-12 16:37 ` [bug#39579] [PATCH 2/3] gnu: osinfo-db: Add osinfo-db Brice Waegeneire
2020-02-16 19:13   ` Jakub Kądziołka [this message]
2020-02-12 16:37 ` [bug#39579] [PATCH 3/3] gnu: virt-manager: Include operating systems list Brice Waegeneire
2020-02-16 19:27   ` Jakub Kądziołka
2020-02-16 20:47 ` [bug#39579] [PATCH v2 0/3] Include operating systems list in virt-manager Brice Waegeneire
2020-02-16 20:47 ` [bug#39579] [PATCH v2 1/3] gnu: osinfo-db-tools: Add osinfo-db-tools Brice Waegeneire
2020-02-16 20:47 ` [bug#39579] [PATCH v2 2/3] gnu: osinfo-db: Add osinfo-db Brice Waegeneire
2020-02-16 20:47 ` [bug#39579] [PATCH v2 3/3] gnu: libosinfo: Include operating systems list Brice Waegeneire
2020-02-19 22:06 ` bug#39579: Done: Include operating systems list in virt-manager Jakub Kądziołka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200216191304.coce5czm3ayji3dc@gravity \
    --to=kuba@kadziolka.net \
    --cc=39579@debbugs.gnu.org \
    --cc=brice@waegenei.re \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.