From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:59580) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3PLj-0002U2-6D for guix-patches@gnu.org; Sun, 16 Feb 2020 14:13:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3PLi-0008Ke-4f for guix-patches@gnu.org; Sun, 16 Feb 2020 14:13:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59953) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j3PLh-0008KJ-WA for guix-patches@gnu.org; Sun, 16 Feb 2020 14:13:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j3PLh-0004sl-Sc for guix-patches@gnu.org; Sun, 16 Feb 2020 14:13:01 -0500 Subject: [bug#39579] [PATCH 2/3] gnu: osinfo-db: Add osinfo-db. Resent-Message-ID: Date: Sun, 16 Feb 2020 20:13:04 +0100 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Message-ID: <20200216191304.coce5czm3ayji3dc@gravity> References: <20200212163046.15761-1-brice@waegenei.re> <20200212163711.17468-2-brice@waegenei.re> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ej3s3hkwbnuz3vcf" Content-Disposition: inline In-Reply-To: <20200212163711.17468-2-brice@waegenei.re> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Brice Waegeneire Cc: 39579@debbugs.gnu.org --ej3s3hkwbnuz3vcf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 12, 2020 at 05:37:10PM +0100, Brice Waegeneire wrote: > +(define-public osinfo-db > + (package > + (name "osinfo-db") > + (version "20200203") > + (source (origin > + (method url-fetch) > + (uri (string-append "https://releases.pagure.org/libosinfo/osinfo-db-" > + version ".tar.xz")) > + (sha256 > + (base32 > + "1zjq1dhlci00j17dij7s3l30hybzmaykpk5b6bd5xbllp745njn5")))) > + (build-system trivial-build-system) > + (arguments > + `(#:modules ((guix build utils)) > + #:builder > + (begin > + (use-modules (guix build utils)) > + (let* ((out (assoc-ref %outputs "out")) > + (osinfo-dir (string-append out "/share/osinfo")) > + (source (assoc-ref %build-inputs "source"))) > + (set-path-environment-variable > + "PATH" '("bin") > + (list (assoc-ref %build-inputs "osinfo-db-tools"))) > + (mkdir-p osinfo-dir) > + (invoke "osinfo-db-import" "--dir" osinfo-dir source) Wouldn't it be simpler to invoke osinfo-db-import with a full path to the binary instead of adding to $PATH? > + #t)))) > + (native-inputs > + `(("intltool" ,intltool) > + ("osinfo-db-tools" ,osinfo-db-tools))) > + (home-page "https://gitlab.com/libosinfo/osinfo-db") > + (synopsis "Database of information about operating systems") > + (description "Osinfo-db provides the database files for use with the > +libosinfo library. It provides information about guest operating systems for ^^ Use two spaces after a sentence. (please run guix lint on your packages) > +use with virtualization provisioning tools") > + (license license:lgpl2.0+))) --ej3s3hkwbnuz3vcf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl5JlEAACgkQ4xWnWEYT FWTPYRAAzBwlhC+5cJwj3Z5oKp7SZtFV5VY+PhasWqgzNz8Jn7tJb/U/rgrMT9Ez UvbUlBKnXixzTp/kcCMJ9nYXFiNMGKiV3A3UAXRB/zsB0E9OB5tHD6X+r3ibLn1o kCaLNJjMR/0xG+D84qSMWSWqCLWxVRsk8YhG4j4PDesFVMDTJiav5t6bnPI4Fnx7 qvpXSrlBZ1HPYdeXupT0nb6Uht7htNmC/WjjcJXOYXGlOhKwjA1CDrvkYtWC5E8v +MFJlObWf6rV+ha4Ibgk43t2qdLclrv/dE9l/45y2BKwirPZtKyq5uAkncgGvKmg mowbSgKJrAZkYGWrhPaOo2bLiJtBGJHHfYdcm9MjYUqwLQGlm5Z8uZk0meDCsJ3f bMB8Ki0x8sY5koAFQqeZHUjL1iWSI4AZ1QgkZU3rziqXNvoZ2XUWTspc5kfDElMC NZ/XAL4gzl0ZRry695NFhUYyIB/hTN6DPz0KfIoSPYuUWBprzh4oEpk09U1pxgHv zQA8dKUVigZUR/XGVIaOzeiXpC/LGmkcVR1KDMzMBAyqQxfXGDOdsUcNkzcdjmSl npbYTdF8jlJuWTo9ubpD5ybN7fWa8YesLqHCTVoBaOvflSEPgavxTFfcyc0toDIA 3C4ML12ReqNaiyAFmIuRFTxwSeYQ++B2wzLw3h7QfO9KHKigPW0= =Zo6E -----END PGP SIGNATURE----- --ej3s3hkwbnuz3vcf--