Re: 01/02: build: gnu-build-system: Don't run configure during bootstrap.

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]

On Sun, Feb 16, 2020 at 03:27:36PM +0100, Marius Bakke wrote:
> guix-commits@gnu.org writes:
> 
> > commit 481a0f1a7ceac666a011b28324220584ead07698
> > Author: Efraim Flashner <efraim@flashner.co.il>
> > AuthorDate: Thu Feb 13 10:54:29 2020 +0200
> >
> >     build: gnu-build-system: Don't run configure during bootstrap.
> >     
> >     * guix/build/gnu-build-system.scm (bootstrap): Add NOCONFIGURE
> >     environment variable before running bootstrap scripts.
> 
> [...]
> 
> > @@ -190,6 +190,7 @@ working directory."
> >                (if (executable-file? script)
> >                    (begin
> >                      (patch-shebang script)
> > +                    (setenv "NOCONFIGURE" "true")
> >                      (invoke script))
> >                    (invoke "sh" script)))
> >              (if (or (file-exists? "configure.ac")
> 
> Should we unset NOCONFIGURE afterwards?  Probably at least one package
> uses this variable for something completely different...

It probably wouldn't hurt to unset it. I've never come across a package
where that's been a problem but best not invite trouble.

Also, looking at the snippet, I should move it higher up. If it's not
executable then NOCONFIGURE doesn't get set.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]