From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: 01/02: build: gnu-build-system: Don't run configure during bootstrap. Date: Sun, 16 Feb 2020 16:55:17 +0200 Message-ID: <20200216145517.GE1968@E5400> References: <20200216072616.4957.58376@vcs0.savannah.gnu.org> <20200216072618.88AB021120@vcs0.savannah.gnu.org> <877e0m7gkn.fsf@devup.no> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="d8Lz2Tf5e5STOWUP" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:36280) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3LLO-0001mM-1i for guix-devel@gnu.org; Sun, 16 Feb 2020 09:56:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3LLJ-0003L2-1u for guix-devel@gnu.org; Sun, 16 Feb 2020 09:56:25 -0500 Received: from flashner.co.il ([178.62.234.194]:42584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j3LLI-0002hf-Rj for guix-devel@gnu.org; Sun, 16 Feb 2020 09:56:21 -0500 Content-Disposition: inline In-Reply-To: <877e0m7gkn.fsf@devup.no> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane-mx.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org --d8Lz2Tf5e5STOWUP Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 16, 2020 at 03:27:36PM +0100, Marius Bakke wrote: > guix-commits@gnu.org writes: >=20 > > commit 481a0f1a7ceac666a011b28324220584ead07698 > > Author: Efraim Flashner > > AuthorDate: Thu Feb 13 10:54:29 2020 +0200 > > > > build: gnu-build-system: Don't run configure during bootstrap. > > =20 > > * guix/build/gnu-build-system.scm (bootstrap): Add NOCONFIGURE > > environment variable before running bootstrap scripts. >=20 > [...] >=20 > > @@ -190,6 +190,7 @@ working directory." > > (if (executable-file? script) > > (begin > > (patch-shebang script) > > + (setenv "NOCONFIGURE" "true") > > (invoke script)) > > (invoke "sh" script))) > > (if (or (file-exists? "configure.ac") >=20 > Should we unset NOCONFIGURE afterwards? Probably at least one package > uses this variable for something completely different... It probably wouldn't hurt to unset it. I've never come across a package where that's been a problem but best not invite trouble. Also, looking at the snippet, I should move it higher up. If it's not executable then NOCONFIGURE doesn't get set. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --d8Lz2Tf5e5STOWUP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl5JV9IACgkQQarn3Mo9 g1Hy6Q//RkngjlJ/O78HR0lPBRlq+nf4DXN2Tzx90aDYQ48lMBvdsOsceOHyKYrL T0w6jWcJP82CKnUDMJ1cNA580xwWmRMV7rZLZOoDSptJmz1lFyHICc7XkowXgQCj kam3zhLVaEzl01qYO975/hlKSjbj4QHl8E7R9XRCZgMGv1RN9Ed8kp0EU0hsgtgN BwdUApx4N7FKb7F7QKtCzqRsPSQsztKwxpWTae2EzwpklKx3reyUP7NbOf7Hd65p 3Qn4idmW04/qDKnXN7kwD4oj1AGfz43RNbF3Ocj/9iPcHOnCnLHkDSgL+qNAA7Vb f1TR/+Is9PzWfBZPZJkPoz6wHOuouNWnu4VDXBn22QvKYrtACQVK0HAVvq2COI+r B7vAjKSlZGs43O4lAW7C/Uj2TDb59XJm/jKvHngbR0bQx3Ik82If0Q7IP/w3mx9J 6pMLCpnp1CeFWhbin/RKWXolTuDV3PTWTZ4rx4evkhbQN3at6NTHx+gIT2VH+YQ3 Du3VtE5HMtnS1cdPIRrhIUb/bzSg15c5gkkiNrkNW1onpXrvCFBaLr6ZmhclqgBo uEvR8geTC5Lyd81U40ZSgJm/Z3zk4hH3Nu7P9KjXbCLR2rMEtQVdlCwHxDVIzbFJ x1LNdzWnuMBDa6lIRKeH5EMCGcK9b8qkYSBPnf/CfkuTUzLSgiI= =JgeP -----END PGP SIGNATURE----- --d8Lz2Tf5e5STOWUP--