[bug#38107] [PATCH 0/1] Warn about etc/indent-code.el when Emacs is absent.

[bug#38107] [PATCH 0/1] Warn about etc/indent-code.el when Emacs is absent.

[zimoun]

Dear,

Currently, if Emacs is absent of PATH then ./configure defaults to
/usr/bin/emacs, therefore the script etc/indent-code.el fails when the user
runs it.

With the patch, the file etc/indent-code.el will not be outputed if Emacs is
absent and ./configure warns the user.

From my point of view, it avoids trivial mistake of non-Emacs-er newcomers and
ease their experience when contributing.


All the best,
simon


zimoun (1):
  configure.ac: Warn about etc/indent-code.el when Emacs is absent.

 configure.ac | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

-- 
2.23.0

[bug#38107] [PATCH 1/1] configure.ac: Warn about etc/indent-code.el when Emacs is absent.

[zimoun]

---
 configure.ac | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/configure.ac b/configure.ac
index 689b28d984..599addfe59 100644
--- a/configure.ac
+++ b/configure.ac
@@ -280,9 +280,14 @@ dnl Documentation translation.
 AM_MISSING_PROG([PO4A_TRANSLATE], [po4a-translate])
 AM_MISSING_PROG([PO4A_UPDATEPO], [po4a-updatepo])
 
-dnl Emacs (optional), for 'etc/indent-package.el'.
-AC_PATH_PROG([EMACS], [emacs], [/usr/bin/emacs])
-AC_SUBST([EMACS])
+dnl Emacs (optional), for 'etc/indent-code.el'.
+AC_PATH_PROG([EMACS], [emacs])
+if test "x$EMACS" = x; then
+    AC_MSG_WARN([Install GNU Emacs to use etc/indent-code.el])
+else
+    AC_SUBST([EMACS])
+    AC_CONFIG_FILES([etc/indent-code.el], [chmod +x etc/indent-code.el])
+fi
 
 case "$storedir" in
   /gnu/store)
-- 
2.23.0

bug#38107: [PATCH 1/1] configure.ac: Warn about etc/indent-code.el when Emacs is absent.

[Ludovic Courtès]

zimoun <zimon.toutoune@gmail.com> skribis:

> ---
>  configure.ac | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 689b28d984..599addfe59 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -280,9 +280,14 @@ dnl Documentation translation.
>  AM_MISSING_PROG([PO4A_TRANSLATE], [po4a-translate])
>  AM_MISSING_PROG([PO4A_UPDATEPO], [po4a-updatepo])
>  
> -dnl Emacs (optional), for 'etc/indent-package.el'.
> -AC_PATH_PROG([EMACS], [emacs], [/usr/bin/emacs])
> -AC_SUBST([EMACS])
> +dnl Emacs (optional), for 'etc/indent-code.el'.
> +AC_PATH_PROG([EMACS], [emacs])
> +if test "x$EMACS" = x; then
> +    AC_MSG_WARN([Install GNU Emacs to use etc/indent-code.el])
> +else
> +    AC_SUBST([EMACS])
> +    AC_CONFIG_FILES([etc/indent-code.el], [chmod +x etc/indent-code.el])
> +fi

I removed the redundant ‘AC_CONFIG_FILES’ from the bottom, adjusted the
commit log, and applied.

Thanks!

Ludo’.