all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#36913] [PATCH] Make gzip timestamps writable for some packages.
@ 2019-08-03 20:40 Brian Leung
  2019-08-05  7:28 ` bug#36913: " Efraim Flashner
  0 siblings, 1 reply; 2+ messages in thread
From: Brian Leung @ 2019-08-03 20:40 UTC (permalink / raw)
  To: 36913


[-- Attachment #1.1: Type: text/plain, Size: 14 bytes --]

See attached.

[-- Attachment #1.2: Type: text/html, Size: 35 bytes --]

[-- Attachment #2: 0001-gnu-khmer-Make-gzip-timestamps-writable.patch --]
[-- Type: text/x-patch, Size: 1443 bytes --]

From 8dfc2dd952edc1e19372d83bc1bedee67b0cddac Mon Sep 17 00:00:00 2001
From: Brian Leung <bkleung89@gmail.com>
Date: Tue, 25 Jun 2019 20:48:54 +0200
Subject: [PATCH 1/2] gnu: khmer: Make gzip timestamps writable.

* gnu/packages/bioinformatics.scm (khmer): Make gzip timestamps writable.
---
 gnu/packages/bioinformatics.scm | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 89f1ac36ea..81da765be9 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -4206,8 +4206,15 @@ command, or queried for specific k-mers with @code{jellyfish query}.")
        (modify-phases %standard-phases
          (add-after 'unpack 'set-cc
            (lambda _ (setenv "CC" "gcc") #t))
-         ;; FIXME: This fails with "permission denied".
-         (delete 'reset-gzip-timestamps))))
+
+         (add-before 'reset-gzip-timestamps 'make-files-writable
+           (lambda* (#:key outputs #:allow-other-keys)
+             ;; Make sure .gz files are writable so that the
+             ;; 'reset-gzip-timestamps' phase can do its work.
+             (let ((out (assoc-ref outputs "out")))
+               (for-each make-file-writable
+                         (find-files out "\\.gz$"))
+               #t))))))
     (native-inputs
      `(("python-cython" ,python-cython)
        ("python-pytest" ,python-pytest)
-- 
2.22.0


[-- Attachment #3: 0002-gnu-python-scikit-learn-Make-gzip-timestamps-writabl.patch --]
[-- Type: text/x-patch, Size: 1372 bytes --]

From 5f4bf9c5aa67096b8b1211959db61d9ca87c3fac Mon Sep 17 00:00:00 2001
From: Brian Leung <bkleung89@gmail.com>
Date: Tue, 25 Jun 2019 20:50:54 +0200
Subject: [PATCH 2/2] gnu: python-scikit-learn: Make gzip timestamps writable.

* gnu/packages/machine-learning.scm (python-scikit-learn): Make gzip timestamps writable.
---
 gnu/packages/machine-learning.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index 2dc7dc81ef..dd5ee1e9ee 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -821,8 +821,14 @@ computing environments.")
              (setenv "HOME" "/tmp")
 
              (invoke "pytest" "sklearn" "-m" "not network")))
-         ;; FIXME: This fails with permission denied
-         (delete 'reset-gzip-timestamps))))
+         (add-before 'reset-gzip-timestamps 'make-files-writable
+           (lambda* (#:key outputs #:allow-other-keys)
+             ;; Make sure .gz files are writable so that the
+             ;; 'reset-gzip-timestamps' phase can do its work.
+             (let ((out (assoc-ref outputs "out")))
+               (for-each make-file-writable
+                         (find-files out "\\.gz$"))
+               #t))))))
     (inputs
      `(("openblas" ,openblas)))
     (native-inputs
-- 
2.22.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#36913: [PATCH] Make gzip timestamps writable for some packages.
  2019-08-03 20:40 [bug#36913] [PATCH] Make gzip timestamps writable for some packages Brian Leung
@ 2019-08-05  7:28 ` Efraim Flashner
  0 siblings, 0 replies; 2+ messages in thread
From: Efraim Flashner @ 2019-08-05  7:28 UTC (permalink / raw)
  To: Brian Leung; +Cc: 36913-done

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

Add a copyright line for you and patch pushed.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-08-05  7:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-03 20:40 [bug#36913] [PATCH] Make gzip timestamps writable for some packages Brian Leung
2019-08-05  7:28 ` bug#36913: " Efraim Flashner

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.