* [bug#35845] [PATCH 1/2] services: sddm: fix root login failure issue.
@ 2019-05-21 13:21 Reza Alizadeh Majd
2019-05-21 13:21 ` [bug#35844] [PATCH 2/2] doc: update minimum-uid document for sddm-configuration Reza Alizadeh Majd
2019-05-21 13:24 ` [bug#35845] " Reza Alizadeh Majd
0 siblings, 2 replies; 7+ messages in thread
From: Reza Alizadeh Majd @ 2019-05-21 13:21 UTC (permalink / raw)
To: 35845; +Cc: Reza Alizadeh Majd
* gnu/services/sddm.scm
(sdm-pam-service): set uid from config.
(sdm-autologin-pam-service): set uid from config.
(sdm-pam-services): pass sddm-configuration to sddm-pam-service and
sddm-autologin-pam-service
---
gnu/services/sddm.scm | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/gnu/services/sddm.scm b/gnu/services/sddm.scm
index b433c59e12..b0e6d40260 100644
--- a/gnu/services/sddm.scm
+++ b/gnu/services/sddm.scm
@@ -175,7 +175,7 @@ Relogin=" (if (sddm-configuration-relogin? config)
(define (sddm-etc-service config)
(list `("sddm.conf" ,(sddm-configuration-file config))))
-(define (sddm-pam-service)
+(define (sddm-pam-service config)
"Return a PAM service for @command{sddm}."
(pam-service
(name "sddm")
@@ -190,7 +190,9 @@ Relogin=" (if (sddm-configuration-relogin? config)
(pam-entry
(control "required")
(module "pam_succeed_if.so")
- (arguments (list "uid >= 1000" "quiet")))
+ (arguments (list (string-append "uid >= "
+ (number->string (sddm-configuration-minimum-uid config)))
+ "quiet")))
;; should be factored out into system-auth
(pam-entry
(control "required")
@@ -249,7 +251,7 @@ Relogin=" (if (sddm-configuration-relogin? config)
(control "required")
(module "pam_unix.so"))))))
-(define (sddm-autologin-pam-service)
+(define (sddm-autologin-pam-service config)
"Return a PAM service for @command{sddm-autologin}"
(pam-service
(name "sddm-autologin")
@@ -261,7 +263,9 @@ Relogin=" (if (sddm-configuration-relogin? config)
(pam-entry
(control "required")
(module "pam_succeed_if.so")
- (arguments (list "uid >= 1000" "quiet")))
+ (arguments (list (string-append "uid >= "
+ (number->string (sddm-configuration-minimum-uid config)))
+ "quiet")))
(pam-entry
(control "required")
(module "pam_permit.so"))))
@@ -282,9 +286,9 @@ Relogin=" (if (sddm-configuration-relogin? config)
(module "sddm"))))))
(define (sddm-pam-services config)
- (list (sddm-pam-service)
+ (list (sddm-pam-service config)
(sddm-greeter-pam-service)
- (sddm-autologin-pam-service)))
+ (sddm-autologin-pam-service config)))
(define %sddm-accounts
(list (user-group (name "sddm") (system? #t))
--
2.19.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#35844] [PATCH 2/2] doc: update minimum-uid document for sddm-configuration.
2019-05-21 13:21 [bug#35845] [PATCH 1/2] services: sddm: fix root login failure issue Reza Alizadeh Majd
@ 2019-05-21 13:21 ` Reza Alizadeh Majd
2019-05-21 13:24 ` [bug#35845] " Reza Alizadeh Majd
1 sibling, 0 replies; 7+ messages in thread
From: Reza Alizadeh Majd @ 2019-05-21 13:21 UTC (permalink / raw)
To: 35844; +Cc: Reza Alizadeh Majd
---
doc/guix.texi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 27e0f72ccb..6bce474859 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -13609,7 +13609,8 @@ Directory to look for faces.
Default PATH to use.
@item @code{minimum-uid} (default 1000)
-Minimum UID to display in SDDM.
+Minimum UID to display in SDDM. This option also used in @code{sddm-pam-service} and
+@code{sddm-autologin-pam-service} in order to set minimum UID which allows to login.
@item @code{maximum-uid} (default 2000)
Maximum UID to display in SDDM
--
2.19.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#35845] [PATCH 2/2] doc: update minimum-uid document for sddm-configuration.
2019-05-21 13:21 [bug#35845] [PATCH 1/2] services: sddm: fix root login failure issue Reza Alizadeh Majd
2019-05-21 13:21 ` [bug#35844] [PATCH 2/2] doc: update minimum-uid document for sddm-configuration Reza Alizadeh Majd
@ 2019-05-21 13:24 ` Reza Alizadeh Majd
2019-05-22 5:53 ` Reza Alizadeh Majd
1 sibling, 1 reply; 7+ messages in thread
From: Reza Alizadeh Majd @ 2019-05-21 13:24 UTC (permalink / raw)
To: 35845; +Cc: Reza Alizadeh Majd
---
doc/guix.texi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 27e0f72ccb..6bce474859 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -13609,7 +13609,8 @@ Directory to look for faces.
Default PATH to use.
@item @code{minimum-uid} (default 1000)
-Minimum UID to display in SDDM.
+Minimum UID to display in SDDM. This option also used in @code{sddm-pam-service} and
+@code{sddm-autologin-pam-service} in order to set minimum UID which allows to login.
@item @code{maximum-uid} (default 2000)
Maximum UID to display in SDDM
--
2.19.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-05-25 18:04 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-21 13:21 [bug#35845] [PATCH 1/2] services: sddm: fix root login failure issue Reza Alizadeh Majd
2019-05-21 13:21 ` [bug#35844] [PATCH 2/2] doc: update minimum-uid document for sddm-configuration Reza Alizadeh Majd
2019-05-21 13:24 ` [bug#35845] " Reza Alizadeh Majd
2019-05-22 5:53 ` Reza Alizadeh Majd
2019-05-24 15:46 ` Ludovic Courtès
2019-05-25 9:49 ` Reza Alizadeh Majd
2019-05-25 18:03 ` bug#35845: " Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.