all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Reza Alizadeh Majd <r.majd@pantherx.org>
Cc: 34795@debbugs.gnu.org
Subject: [bug#34795] LXQT update to version 0.14.1
Date: Fri, 15 Mar 2019 13:19:29 -0400	[thread overview]
Message-ID: <20190315171929.GD32161@jasmine.lan> (raw)
In-Reply-To: <BF648D4E-2325-4BD1-B0BD-90A7953AAF7F@pantherx.org>

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

On Sat, Mar 09, 2019 at 06:29:23PM +0330, Reza Alizadeh Majd wrote:
> diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm
> index a5720ce97..f6bfcfa64 100644
> --- a/gnu/packages/lxde.scm
> +++ b/gnu/packages/lxde.scm
> @@ -190,7 +190,7 @@ performance, all instances of the terminal are sharing a single process.")
>  (define-public menu-cache
>    (package
>      (name "menu-cache")
> -    (version "1.0.2")
> +    (version "1.1.0")

Thank you for this patch!

I request two changes:

First, can you split up the patch into several patches? In general, each
package should be updated in its own patch, unless this will cause the
other packages to break.

Second, can you write a complete commit message? For the first package
update, for example, you'd write it this way:

------
gnu: menu-cache: Update to 1.1.0.

* gnu/packages/lxde.scm (menu-cache): Update to 1.1.0.
------

If there are other changes, they should be described as well.

I recommend looking at our Git history for examples, or asking here on
or IRC if you need help. Can you send an updated patch series?

By the way, this style of commit logs is called the 'GNU Change Log'
style and is documented here:

https://www.gnu.org/prep/standards/html_node/Change-Logs.html

But looking at `git log` is probably the clearest way to learn it.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-03-15 17:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-09 14:59 [bug#34795] LXQT update to version 0.14.1 Reza Alizadeh Majd
2019-03-15 17:19 ` Leo Famulari [this message]
2019-03-16  8:14   ` Reza Alizadeh Majd
2019-03-17 20:51     ` Leo Famulari
2019-03-19  9:58     ` Jonathan Brielmaier
2019-03-19 20:35       ` Reza Alizadeh Majd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190315171929.GD32161@jasmine.lan \
    --to=leo@famulari.name \
    --cc=34795@debbugs.gnu.org \
    --cc=r.majd@pantherx.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.