From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:49087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4qV1-0004mp-Sa for guix-patches@gnu.org; Fri, 15 Mar 2019 13:20:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4qV1-0005Qz-0Z for guix-patches@gnu.org; Fri, 15 Mar 2019 13:20:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60153) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4qV0-0005Qo-Mm for guix-patches@gnu.org; Fri, 15 Mar 2019 13:20:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h4qV0-0000aG-Ey for guix-patches@gnu.org; Fri, 15 Mar 2019 13:20:02 -0400 Subject: [bug#34795] LXQT update to version 0.14.1 Resent-Message-ID: Date: Fri, 15 Mar 2019 13:19:29 -0400 From: Leo Famulari Message-ID: <20190315171929.GD32161@jasmine.lan> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LTeJQqWS0MN7I/qa" Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Reza Alizadeh Majd Cc: 34795@debbugs.gnu.org --LTeJQqWS0MN7I/qa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Mar 09, 2019 at 06:29:23PM +0330, Reza Alizadeh Majd wrote: > diff --git a/gnu/packages/lxde.scm b/gnu/packages/lxde.scm > index a5720ce97..f6bfcfa64 100644 > --- a/gnu/packages/lxde.scm > +++ b/gnu/packages/lxde.scm > @@ -190,7 +190,7 @@ performance, all instances of the terminal are sharing a single process.") > (define-public menu-cache > (package > (name "menu-cache") > - (version "1.0.2") > + (version "1.1.0") Thank you for this patch! I request two changes: First, can you split up the patch into several patches? In general, each package should be updated in its own patch, unless this will cause the other packages to break. Second, can you write a complete commit message? For the first package update, for example, you'd write it this way: ------ gnu: menu-cache: Update to 1.1.0. * gnu/packages/lxde.scm (menu-cache): Update to 1.1.0. ------ If there are other changes, they should be described as well. I recommend looking at our Git history for examples, or asking here on or IRC if you need help. Can you send an updated patch series? By the way, this style of commit logs is called the 'GNU Change Log' style and is documented here: https://www.gnu.org/prep/standards/html_node/Change-Logs.html But looking at `git log` is probably the clearest way to learn it. --LTeJQqWS0MN7I/qa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlyL3qEACgkQJkb6MLrK fwj0LA/8DpveGuyG3JN2B0fFjECMmIV/Ya4qjxtlv5+UaNR8WpJk68Ni/SHYIIrJ d4ftxuIj8JsuQWH2d3BbaruqQWgwCUcen0sBkTTYfnJ+1/KjIlF//0WF3R+D1sK4 ddHTX4EE1n2f/UvwIMKZXrY6+P6A6dBaLxHr5RBTZ31qfH5QEYTE3eEGh+C/kiIT W9mC2QT7Dh1XS+9NeJ3CXDXNkP+SBKd9wey11qbz4cuhwi6sKAGVlIMKZyn9rGUk OAmS7umbPtHibiAmHTxmXzWXuNM37/3vcWPDLk92Xk54HvPmw9ODUJ9qSmVR+bO/ AuNOVz5t6IbxElodnMBv/tqq9nxBJ6zz7PknJWTvB7KhwHSNWyfD4rtPi2nHvcL3 EZHtgv6hrHba4LXjnCPWFzQWQzXMdUZbuTlz6VK0jtqKiVa3kCH+H66DXz0F3fh+ JKEJjc1E6jfUc/5MNL4bu3N7EOkQp1nzvP1SPeMf9RHaNKxHIRM1iMtrUmfEv861 +XOm0+sz7A+cKwsY00RywDWX8n5RBr+JmjjwR2L7w71dB2AEWJqEgGUmd3WNjWd7 kmJqLbimy1lITMzkNq4i6HxW4Kn0C8iqnxHHXR4M6lw0i8V3b9WjgpIQ1NvbcRSn bN7dwb5sUqb7t9//aMBhLhkIc3AX8gVrTy66vUa3qUIvgqI45TI= =/SV3 -----END PGP SIGNATURE----- --LTeJQqWS0MN7I/qa--