From: Eric Bavier <ericbavier@centurylink.net>
To: Christopher Baines <mail@cbaines.net>
Cc: 34056-done@debbugs.gnu.org
Subject: bug#34056: [PATCH] core-updates -- gnu: python2: Fix test flags.
Date: Tue, 22 Jan 2019 22:05:34 -0600 [thread overview]
Message-ID: <20190122220534.50f0bf69@centurylink.net> (raw)
In-Reply-To: <20190121191622.428b0932@centurylink.net>
[-- Attachment #1: Type: text/plain, Size: 2511 bytes --]
On Mon, 21 Jan 2019 19:16:22 -0600
Eric Bavier <ericbavier@centurylink.net> wrote:
> On Mon, 21 Jan 2019 19:10:06 +0000
> Christopher Baines <mail@cbaines.net> wrote:
>
> > Eric Bavier <ericbavier@centurylink.net> writes:
> >
> > > On Sun, 13 Jan 2019 22:56:27 +0000
> > > Christopher Baines <mail@cbaines.net> wrote:
> > >
> > >> ericbavier@centurylink.net writes:
> > >>
> > >> > From: Eric Bavier <bavier@member.fsf.org>
> > >> >
> > >> > * gnu/packages/python.scm (python-2.7)[arguments]: 'EXTRATESTOPTS' ->
> > >> > 'TESTOPTS'. This overrides the default '-l' argument for memory leak checks
> > >> > which is not compatible with the -j for parallelism.
> > >> > ---
> > >> > gnu/packages/python.scm | 2 +-
> > >> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >> >
> > >> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> > >> > index 9b43f465cc..dffded738d 100644
> > >> > --- a/gnu/packages/python.scm
> > >> > +++ b/gnu/packages/python.scm
> > >> > @@ -194,7 +194,7 @@
> > >> > (assoc-ref %outputs "out") "/lib"))
> > >> > ;; With no -j argument tests use all available cpus, so provide one.
> > >> > #:make-flags
> > >> > - (list (format #f "EXTRATESTOPTS=-j~d" (parallel-job-count)))
> > >> > + (list (format #f "TESTOPTS=-j~d" (parallel-job-count)))
> > >> >
> > >> > #:modules ((ice-9 ftw) (ice-9 match)
> > >> > (guix build utils) (guix build gnu-build-system))
> > >>
> > >> Hey Eric,
> > >>
> > >> I've also been looking at some Python 2 things on core-updates today,
> > >> trying to get the linkchecker package building again.
> > >>
> > >> I've just pushed a slightly different patch, but to this effect to
> > >> core-updates, and only just seen this message, sorry about that.
> > >
> > > Not a problem.
> > >
> > >> Thanks for looking at it though, this approach is probably neater, as I
> > >> used substitute* instead.
> > >
> > > Would you like to keep your patch, or apply this one instead?
> >
> > I'm quite happy to switch to this approach. I don't know whether the
> > best way to do that is to switch out the patches by force-pushing to
> > core-updates, or to just apply your patch on top though...
>
> I can just adjust my patch.
An adjusted patch, which reverts Christopher's patch was pushed to
core-updates in commit 32922190977f701694880254a71feb2752222f94
`~Eric
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-01-23 4:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-13 7:18 [bug#34056] [PATCH] core-updates -- gnu: python2: Fix test flags ericbavier
2019-01-13 7:18 ` [bug#34057] [PATCH] core-updates -- gnu: groff: Fix doc installation ericbavier
2019-01-14 21:36 ` bug#34057: " Eric Bavier
2019-01-13 7:48 ` [bug#34056] [PATCH] core-updates -- gnu: python2: Fix test flags Efraim Flashner
2019-01-13 16:23 ` Eric Bavier
2019-01-13 17:16 ` Efraim Flashner
2019-01-13 22:56 ` Christopher Baines
2019-01-14 2:42 ` Eric Bavier
2019-01-21 19:10 ` Christopher Baines
2019-01-22 1:16 ` Eric Bavier
2019-01-23 4:05 ` Eric Bavier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122220534.50f0bf69@centurylink.net \
--to=ericbavier@centurylink.net \
--cc=34056-done@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.