From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:35174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmA1F-0002jE-U8 for guix-patches@gnu.org; Tue, 22 Jan 2019 23:20:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm9ng-000569-CC for guix-patches@gnu.org; Tue, 22 Jan 2019 23:06:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42590) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm9nf-00055a-0U for guix-patches@gnu.org; Tue, 22 Jan 2019 23:06:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gm9ne-0006v1-Qx for guix-patches@gnu.org; Tue, 22 Jan 2019 23:06:02 -0500 Subject: bug#34056: [PATCH] core-updates -- gnu: python2: Fix test flags. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Tue, 22 Jan 2019 22:05:34 -0600 From: Eric Bavier Message-ID: <20190122220534.50f0bf69@centurylink.net> In-Reply-To: <20190121191622.428b0932@centurylink.net> References: <20190113071850.14337-1-ericbavier@centurylink.net> <8736pwjhes.fsf@cbaines.net> <20190113204242.55461ef2@centurylink.net> <87imyhj08h.fsf@cbaines.net> <20190121191622.428b0932@centurylink.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/y4r3paCSngiiTPU7XNDQCH9"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 34056-done@debbugs.gnu.org --Sig_/y4r3paCSngiiTPU7XNDQCH9 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 21 Jan 2019 19:16:22 -0600 Eric Bavier wrote: > On Mon, 21 Jan 2019 19:10:06 +0000 > Christopher Baines wrote: >=20 > > Eric Bavier writes: > > =20 > > > On Sun, 13 Jan 2019 22:56:27 +0000 > > > Christopher Baines wrote: > > > =20 > > >> ericbavier@centurylink.net writes: > > >> =20 > > >> > From: Eric Bavier > > >> > > > >> > * gnu/packages/python.scm (python-2.7)[arguments]: 'EXTRATESTOPTS'= -> > > >> > 'TESTOPTS'. This overrides the default '-l' argument for memory l= eak checks > > >> > which is not compatible with the -j for parallelism. > > >> > --- > > >> > gnu/packages/python.scm | 2 +- > > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > > >> > > > >> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm > > >> > index 9b43f465cc..dffded738d 100644 > > >> > --- a/gnu/packages/python.scm > > >> > +++ b/gnu/packages/python.scm > > >> > @@ -194,7 +194,7 @@ > > >> > (assoc-ref %outputs "out") "/lib")) > > >> > ;; With no -j argument tests use all available cpus, so pr= ovide one. > > >> > #:make-flags > > >> > - (list (format #f "EXTRATESTOPTS=3D-j~d" (parallel-job-coun= t))) > > >> > + (list (format #f "TESTOPTS=3D-j~d" (parallel-job-count))) > > >> > > > >> > #:modules ((ice-9 ftw) (ice-9 match) > > >> > (guix build utils) (guix build gnu-build-syste= m)) =20 > > >> > > >> Hey Eric, > > >> > > >> I've also been looking at some Python 2 things on core-updates today, > > >> trying to get the linkchecker package building again. > > >> > > >> I've just pushed a slightly different patch, but to this effect to > > >> core-updates, and only just seen this message, sorry about that. = =20 > > > > > > Not a problem. > > > =20 > > >> Thanks for looking at it though, this approach is probably neater, a= s I > > >> used substitute* instead. =20 > > > > > > Would you like to keep your patch, or apply this one instead? =20 > >=20 > > I'm quite happy to switch to this approach. I don't know whether the > > best way to do that is to switch out the patches by force-pushing to > > core-updates, or to just apply your patch on top though... =20 >=20 > I can just adjust my patch. An adjusted patch, which reverts Christopher's patch was pushed to core-updates in commit 32922190977f701694880254a71feb2752222f94 `~Eric --Sig_/y4r3paCSngiiTPU7XNDQCH9 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlxH6A4ACgkQ/XPKxxnT JWb+kQ//ZuZhwED4cADSgCXYr6VcntsWXrqrDFJpjsOgzuAUAA1efjD4ehXJDWs7 44K4QMRIEtPnp9JSOcv+3ZgV6Z9JWf1sUg6wv4rQ4KkM5RZNux3lfOfSXnaSdDTQ p2cDInqWYQRNFAbLFi0aJ23e7JyHnrrpZnR7okgaHbgScq59bd3LgwM6YTAwQcE6 U/8gtgHTlcLwySGgfTjhhr7FIvQIMWVrhcsL9vyKFy7NC756RQ63y/dyDxL/pK1L X0Fr0Wnr4v4OqpuawB3GaSshN5Qa4tb1ew2TCsVBXtBIitvE24C+0wYpPv26yNYp xd0KeOo0Vmc78QKnA+Y2uHHmdlO1KvmH7j9hrBwKpLb+OM4LK9Gt50kzOtvCdkTH WQddCChOSSqqINljrDDe7MOYirYSWe+vkPMw14n1FfAyejLzUiqw62Q0EFlPq8pt 3S0kqbrqQpAENZPd+QaGo/fp/PBYOvcg165ofRrnsyk1yKLQQAkmY9RRYZ8AeMgl VpXMmVYDbIf1wSrnm7H6Ok06FjggeKTk8C9aBh0CGEmUS0exVkaz2eA/ybUdjrQD z7JufvJc/n1g0pp+u/3FdeK1Co/IuGXiZFzRJT079RnXE1PWPbdZ6bleNJFXYb6o ucGMerr1KX0wkfmnDn+lfiB6dRzOOwzSDHIv4+vsEWDppkLRfP8= =xzra -----END PGP SIGNATURE----- --Sig_/y4r3paCSngiiTPU7XNDQCH9--