all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#33812] [PATCH 1/2] gnu: extra-cmake-modules: Fix install-path for plugins.
@ 2018-12-20 14:17 Hartmut Goebel
  2018-12-20 14:20 ` [bug#33812] [PATCH 2/2] gnu: krunner: Blacklist another test failing with 5.49.0 Hartmut Goebel
       [not found] ` <handler.33812.B.15453150359848.ack@debbugs.gnu.org>
  0 siblings, 2 replies; 3+ messages in thread
From: Hartmut Goebel @ 2018-12-20 14:17 UTC (permalink / raw)
  To: 33812

The respective entry changed for kde-frameworks 5.46.

* gnu/packages/kde-frameworks.scm(krunner)[#phases]<fix-lib-path>:
  Change substitute for QTPLUGINDIR.
---
 gnu/packages/kde-frameworks.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 49c986483..8997f0522 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -98,8 +98,10 @@
                (("\"lib64\"") "\"lib\"")
                ;; TODO: Base the following on values taken from Qt
                ;; Install plugins into lib/qt5/plugins
-               (("_define_relative\\(QTPLUGINDIR LIBDIR \"plugins\"")
-                "_define_relative(QTPLUGINDIR LIBDIR \"qt5/plugins\"")
+               ;; TODO: Check if this is okay for Android, too
+               ;; (see comment in KDEInstallDirs.cmake)
+               (("_define_relative\\(QTPLUGINDIR \"\\$\\{_pluginsDirParent}\" \"plugins\"")
+                "_define_relative(QTPLUGINDIR \"${_pluginsDirParent}\" \"qt5/plugins\"")
                ;; Install imports into lib/qt5/imports
                (("_define_relative\\(QTQUICKIMPORTSDIR QTPLUGINDIR \"imports\"")
                 "_define_relative(QTQUICKIMPORTSDIR LIBDIR \"qt5/imports\"")
-- 
2.13.7

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#33812] [PATCH 2/2] gnu: krunner: Blacklist another test failing with 5.49.0.
  2018-12-20 14:17 [bug#33812] [PATCH 1/2] gnu: extra-cmake-modules: Fix install-path for plugins Hartmut Goebel
@ 2018-12-20 14:20 ` Hartmut Goebel
       [not found] ` <handler.33812.B.15453150359848.ack@debbugs.gnu.org>
  1 sibling, 0 replies; 3+ messages in thread
From: Hartmut Goebel @ 2018-12-20 14:20 UTC (permalink / raw)
  To: 33812

* gnu/packages/kde-frameworks.scm(krunner)[#phases]<check-setup>:
  Blacklist 'testMulti'.
---
 gnu/packages/kde-frameworks.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 8997f0522..0e32d8881 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2956,10 +2956,10 @@ to easily extend the contacts collection.")
              (setenv "HOME" (getcwd))
              ;; make Qt render "offscreen", required for tests
              (setenv "QT_QPA_PLATFORM" "offscreen")
-             ;; Blacklist a failing test-function. FIXME: Make it pass.
+             ;; Blacklist some failing test-functions. FIXME: Make it pass.
              (with-output-to-file "bin/BLACKLIST"
                (lambda _
-                 (display "[testMatch]\n*\n")))
+                 (display "[testMatch]\n*\n[testMulti]\n*\n")))
              #t)))))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "Framework for Plasma runners")
-- 
2.13.7

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#33812: Acknowledgement ([PATCH 1/2] gnu: extra-cmake-modules: Fix install-path for plugins.)
       [not found] ` <handler.33812.B.15453150359848.ack@debbugs.gnu.org>
@ 2019-01-04  9:27   ` Hartmut Goebel
  0 siblings, 0 replies; 3+ messages in thread
From: Hartmut Goebel @ 2019-01-04  9:27 UTC (permalink / raw)
  To: 33812-done

Applied as b824dbec5d331e79a50734fb543bbe064eb7fc17

with trivial changes to the second patch.


-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-01-04  9:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-20 14:17 [bug#33812] [PATCH 1/2] gnu: extra-cmake-modules: Fix install-path for plugins Hartmut Goebel
2018-12-20 14:20 ` [bug#33812] [PATCH 2/2] gnu: krunner: Blacklist another test failing with 5.49.0 Hartmut Goebel
     [not found] ` <handler.33812.B.15453150359848.ack@debbugs.gnu.org>
2019-01-04  9:27   ` bug#33812: Acknowledgement ([PATCH 1/2] gnu: extra-cmake-modules: Fix install-path for plugins.) Hartmut Goebel

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.