From: Efraim Flashner <efraim@flashner.co.il>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Amin Bandali <bandali@gnu.org>, 33764@debbugs.gnu.org
Subject: [bug#33764] [PATCH] gnu: z3: Update to 4.8.3 and add python{, 2}-z3 bindings.
Date: Mon, 17 Dec 2018 09:29:21 +0200 [thread overview]
Message-ID: <20181217072921.GG3468@macbook41> (raw)
In-Reply-To: <87bm5lv6tj.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2593 bytes --]
On Sun, Dec 16, 2018 at 04:18:16PM +0100, Ludovic Courtès wrote:
> Hello Amin,
>
> Amin Bandali <bandali@gnu.org> skribis:
>
> > * gnu/packages/maths.scm (z3): Update to 4.8.3.
> > [build-system]: Switch from cmake to make, and use the current
> > scripts/mk_make.py build script instead of the now-deprecated
> > contrib/cmake/bootstrap.py.
> >
> > * gnu/packages/python.scm (python-z3, python2-z3): New public
> > variables.
>
> Overall LGTM. Some comments:
>
> > (native-inputs
> > - `(("python" ,python-2)))
> > + `(("which" ,(@ (gnu packages base) which))
> > + ("python" ,python-wrapper)))
>
> Please add #:use-module (gnu packages which) so you don’t have to resort
> to the @ notation.
>
> > --- a/gnu/packages/python.scm
> > +++ b/gnu/packages/python.scm
> > @@ -56,6 +56,7 @@
> > ;;; Copyright © 2018 Clément Lassieur <clement@lassieur.org>
> > ;;; Copyright © 2018 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> > ;;; Copyright © 2018 Luther Thompson <lutheroto@gmail.com>
> > +;;; Copyright © 2018 Amin Bandali <bandali@gnu.org>
> > ;;;
> > ;;; This file is part of GNU Guix.
> > ;;;
> > @@ -14989,3 +14990,12 @@ RFC 8265 and RFC 8266.")
> > (description "Simple decorator to set attributes of target function or
> > class in a @acronym{DRY, Don't Repeat Yourself} way.")
> > (license license:expat)))
> > +
> > +(define-public python-z3 z3)
>
> Is this variable necessary? Note that this does not create a
> “python-z3” package.
>
> > +(define-public python2-z3
> > + (package (inherit python-z3)
>
> This definition cannot be in python.scm; it must be in the same file as
> ‘z3’ or we can get “unbound variable” errors while loading either of
> these two modules.
>
> Also, as we’re approaching end-of-life upstream for Python 2.x, we now
> avoid creating “python2-” packages, unless we cannot avoid it for some
> reason. Do you think we could do without this “python2-z3” package?
>
Currently our z3 package builds python2 bindings
> Could you send an updated patch? If you think we really need
> “python2-z3”, please make it a separate patch.
>
> Thank you!
>
> Ludo’.
>
We should also check that the other packages that use z3 aren't
expecting the python2 bindings when built with the python3 bindings.
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-12-17 7:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 4:05 [bug#33764] [PATCH] gnu: z3: Update to 4.8.3 and add python{, 2}-z3 bindings Amin Bandali
2018-12-16 15:18 ` Ludovic Courtès
2018-12-17 7:29 ` Efraim Flashner [this message]
2018-12-17 14:34 ` Amin Bandali
2018-12-21 17:02 ` Ludovic Courtès
2018-12-21 20:40 ` Marius Bakke
2018-12-21 23:41 ` Amin Bandali
2018-12-22 15:20 ` Amin Bandali
2018-12-23 17:33 ` bug#33764: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217072921.GG3468@macbook41 \
--to=efraim@flashner.co.il \
--cc=33764@debbugs.gnu.org \
--cc=bandali@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.