From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gYnQC-0004Ej-Lj for guix-patches@gnu.org; Mon, 17 Dec 2018 02:34:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gYnLm-0001Hq-DB for guix-patches@gnu.org; Mon, 17 Dec 2018 02:30:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:46525) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gYnLm-0001HD-8Z for guix-patches@gnu.org; Mon, 17 Dec 2018 02:30:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gYnLm-0000wy-43 for guix-patches@gnu.org; Mon, 17 Dec 2018 02:30:02 -0500 Subject: [bug#33764] [PATCH] gnu: z3: Update to 4.8.3 and add python{, 2}-z3 bindings. Resent-Message-ID: Date: Mon, 17 Dec 2018 09:29:21 +0200 From: Efraim Flashner Message-ID: <20181217072921.GG3468@macbook41> References: <20181216040528.29880-1-bandali@gnu.org> <87bm5lv6tj.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LZFKeWUZP29EKQNE" Content-Disposition: inline In-Reply-To: <87bm5lv6tj.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Amin Bandali , 33764@debbugs.gnu.org --LZFKeWUZP29EKQNE Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 16, 2018 at 04:18:16PM +0100, Ludovic Court=C3=A8s wrote: > Hello Amin, >=20 > Amin Bandali skribis: >=20 > > * gnu/packages/maths.scm (z3): Update to 4.8.3. > > [build-system]: Switch from cmake to make, and use the current > > scripts/mk_make.py build script instead of the now-deprecated > > contrib/cmake/bootstrap.py. > > > > * gnu/packages/python.scm (python-z3, python2-z3): New public > > variables. >=20 > Overall LGTM. Some comments: >=20 > > (native-inputs > > - `(("python" ,python-2))) > > + `(("which" ,(@ (gnu packages base) which)) > > + ("python" ,python-wrapper))) >=20 > Please add #:use-module (gnu packages which) so you don=E2=80=99t have to= resort > to the @ notation. >=20 > > --- a/gnu/packages/python.scm > > +++ b/gnu/packages/python.scm > > @@ -56,6 +56,7 @@ > > ;;; Copyright =C2=A9 2018 Cl=C3=A9ment Lassieur > > ;;; Copyright =C2=A9 2018 Maxim Cournoyer > > ;;; Copyright =C2=A9 2018 Luther Thompson > > +;;; Copyright =C2=A9 2018 Amin Bandali > > ;;; > > ;;; This file is part of GNU Guix. > > ;;; > > @@ -14989,3 +14990,12 @@ RFC 8265 and RFC 8266.") > > (description "Simple decorator to set attributes of target functio= n or > > class in a @acronym{DRY, Don't Repeat Yourself} way.") > > (license license:expat))) > > + > > +(define-public python-z3 z3) >=20 > Is this variable necessary? Note that this does not create a > =E2=80=9Cpython-z3=E2=80=9D package. >=20 > > +(define-public python2-z3 > > + (package (inherit python-z3) >=20 > This definition cannot be in python.scm; it must be in the same file as > =E2=80=98z3=E2=80=99 or we can get =E2=80=9Cunbound variable=E2=80=9D err= ors while loading either of > these two modules. >=20 > Also, as we=E2=80=99re approaching end-of-life upstream for Python 2.x, w= e now > avoid creating =E2=80=9Cpython2-=E2=80=9D packages, unless we cannot avoi= d it for some > reason. Do you think we could do without this =E2=80=9Cpython2-z3=E2=80= =9D package? >=20 Currently our z3 package builds python2 bindings > Could you send an updated patch? If you think we really need > =E2=80=9Cpython2-z3=E2=80=9D, please make it a separate patch. >=20 > Thank you! >=20 > Ludo=E2=80=99. >=20 We should also check that the other packages that use z3 aren't expecting the python2 bindings when built with the python3 bindings. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --LZFKeWUZP29EKQNE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAlwXUE4ACgkQQarn3Mo9 g1Epmg/+OY6XPruJUoAszNT7g6kHTUA5Cl4RCLnRMnw1fR+rR7ZRZV1GL8sd+Z20 xjN1vbbQjSnKYBgiRQeHZmRok5fkbjpT7b2WjUtm9AC50Ci4nKYWeyrJQWhdOM3P Nvck5I0c/nI4sV9go3Okcf0+uge+nMBu67Gnq805SnC6zgQXXjT1luErafvSe0cw D91YJxAZZJXj2m7J3F5WIZTe6gwgRd8E63N31uP+9iGfAav6ObWoQfofdXKja/2E 7R/izZG8MpRW0amj1kJNbZNUK7jleZ8iP34QaRPPzzSAYwDWHE3JeXqcwlC2VVdO 2RtAAK7r5FeHoQWLohxl6CAyWzrb+7xHqwHY1NRdtTizJU1Oc137OXtlayrDdBUe AaXsFHG6qfQNvIwoyOGm6f4UC7m8ePrU2dtsp3KqZU8ZPxmyJ2H95B3CKf0JAbMp CPqCmRdeqoFaB86qSq7rf8SJUrRVVnXauJVcvGt8I7XPdjIk/L2lEhqrA8734W9I mB5hS+Lh9oJJ2EXJii+R7U5mrqQGJNn7jR0CprDmqrF2btwVN/iEGdp4nhEj8yxD aPbpr4OSqyR4fRqQbNJwZXO9Qqro5NWFObhphcTIEyPmiJVaTJURysbXE06xBD+7 LIuT71YV8sbTsJiVI3YnLn0nixHogsfltwYV8FTt4KpiSyZ18Ng= =F9/1 -----END PGP SIGNATURE----- --LZFKeWUZP29EKQNE--