From: Eric Bavier <ericbavier@centurylink.net>
Cc: 33390-done@debbugs.gnu.org
Subject: bug#33390: [PATCH 1/4] qtwebkit: Fix pri install directory.
Date: Mon, 26 Nov 2018 20:04:11 -0600 [thread overview]
Message-ID: <20181126200411.2d5c176e@centurylink.net> (raw)
In-Reply-To: <20181119222244.26c47f9e@centurylink.net>
[-- Attachment #1: Type: text/plain, Size: 2936 bytes --]
On Mon, 19 Nov 2018 22:22:44 -0600
Eric Bavier <ericbavier@centurylink.net> wrote:
> Hi Christopher,
>
> On Mon, 19 Nov 2018 22:22:58 +0000
> Christopher Baines <mail@cbaines.net> wrote:
>
> > ericbavier@centurylink.net writes:
> >
> > > From: Eric Bavier <bavier@member.fsf.org>
> > >
> > > This lets qmake find qtwebkit components, allowing packages like python-pyqt
> > > to find qtwebkit and enable support.
> > >
> > > * gnu/packages/qt.scm (qtwebkit)[arguments]: Add "ECM_MKSPECS_INSTALL_DIR"
> > > to #:configure-flags. Link with "--no-keep-memory".
> > > ---
> > > gnu/packages/qt.scm | 11 ++++++++++-
> > > 1 file changed, 10 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> > > index d48769982..36f8aef69 100644
> > > --- a/gnu/packages/qt.scm
> > > +++ b/gnu/packages/qt.scm
> > > @@ -10,6 +10,7 @@
> > > ;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice <me@tobias.gr>
> > > ;;; Copyright © 2018 Nicolas Goaziou <mail@nicolasgoaziou.fr>
> > > ;;; Copyright © 2018 Hartmut Goebel <h.goebel@crazy-compilers.com>
> > > +;;; Copyright © 2018 Eric Bavier <bavier@member.fsf.org>
> > > ;;;
> > > ;;; This file is part of GNU Guix.
> > > ;;;
> > > @@ -2171,7 +2172,15 @@ different kinds of sliders, and much more.")
> > > #:configure-flags (list ;"-DENABLE_API_TESTS=TRUE"
> > > "-DPORT=Qt"
> > > "-DUSE_LIBHYPHEN=OFF"
> > > - "-DUSE_SYSTEM_MALLOC=ON")))
> > > + "-DUSE_SYSTEM_MALLOC=ON"
> > > + ;; XXX: relative dir installs to build dir?
> > > + (string-append "-DECM_MKSPECS_INSTALL_DIR="
> > > + %output "/lib/qt5/mkspecs/modules")
> > > + ;; Sacrifice a little speed in order to link
> > > + ;; libraries and test executables in a
> > > + ;; reasonable amount of memory.
> > > + "-DCMAKE_SHARED_LINKER_FLAGS=-Wl,--no-keep-memory"
> > > + "-DCMAKE_EXE_LINKER_FLAGS=-Wl,--no-keep-memory")))
> > > (home-page "https://www.webkit.org")
> > > (synopsis "Web browser engine and classes to render and interact with web
> > > content")
> >
> > I've tested this, and this fixed the qtwebkit build for me, which
> > currently doesn't work on master. So I'm all for merging it.
>
> Thanks for testing it. I assume it was the linker flags that fixed the
> build on your machine? For clarity, I suppose that change should be
> moved to a separate patch. WDYT?
I've split this patch in two and pushed as
0995a5692cb85418b2d5f21c24d46ee4aa9fb7c9 and
ebdb15bc3540b1901f223bc0689bae51a2f88fc4
`~Eric
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-11-27 2:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 4:17 [bug#33392] [PATCH 0/4] Add OpenShot ericbavier
2018-11-15 4:17 ` [bug#33390] [PATCH 1/4] qtwebkit: Fix pri install directory ericbavier
2018-11-19 22:22 ` Christopher Baines
2018-11-20 4:22 ` Eric Bavier
2018-11-20 17:48 ` Christopher Baines
2018-11-27 2:04 ` Eric Bavier [this message]
2018-11-15 4:17 ` [bug#33392] [PATCH 2/4] gnu: Add libopenshot-audio ericbavier
2018-11-27 2:05 ` bug#33392: " Eric Bavier
2018-11-15 4:17 ` [bug#33392] [PATCH 3/4] gnu: Add libopenshot ericbavier
2018-11-27 2:07 ` Eric Bavier
2018-11-15 4:17 ` [bug#33391] [PATCH 4/4] gnu: Add OpenShot ericbavier
2018-11-27 2:08 ` bug#33391: " Eric Bavier
2018-11-27 2:09 ` [bug#33392] closing: [PATCH 0/4] " Eric Bavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126200411.2d5c176e@centurylink.net \
--to=ericbavier@centurylink.net \
--cc=33390-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.