From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRSkM-0007JF-FR for guix-patches@gnu.org; Mon, 26 Nov 2018 21:05:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRSkJ-0005qE-9W for guix-patches@gnu.org; Mon, 26 Nov 2018 21:05:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:46030) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gRSkI-0005po-KF for guix-patches@gnu.org; Mon, 26 Nov 2018 21:05:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gRSkI-0002XC-Cj for guix-patches@gnu.org; Mon, 26 Nov 2018 21:05:02 -0500 Subject: bug#33390: [PATCH 1/4] qtwebkit: Fix pri install directory. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Mon, 26 Nov 2018 20:04:11 -0600 From: Eric Bavier Message-ID: <20181126200411.2d5c176e@centurylink.net> In-Reply-To: <20181119222244.26c47f9e@centurylink.net> References: <20181115041715.15993-1-ericbavier@centurylink.net> <20181115041715.15993-2-ericbavier@centurylink.net> <87h8gcso59.fsf@cbaines.net> <20181119222244.26c47f9e@centurylink.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/fUKP/Td1S6JilxKRktHl+nq"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Cc: 33390-done@debbugs.gnu.org --Sig_/fUKP/Td1S6JilxKRktHl+nq Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 19 Nov 2018 22:22:44 -0600 Eric Bavier wrote: > Hi Christopher, >=20 > On Mon, 19 Nov 2018 22:22:58 +0000 > Christopher Baines wrote: >=20 > > ericbavier@centurylink.net writes: > > =20 > > > From: Eric Bavier > > > > > > This lets qmake find qtwebkit components, allowing packages like pyth= on-pyqt > > > to find qtwebkit and enable support. > > > > > > * gnu/packages/qt.scm (qtwebkit)[arguments]: Add "ECM_MKSPECS_INSTALL= _DIR" > > > to #:configure-flags. Link with "--no-keep-memory". > > > --- > > > gnu/packages/qt.scm | 11 ++++++++++- > > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > > > diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm > > > index d48769982..36f8aef69 100644 > > > --- a/gnu/packages/qt.scm > > > +++ b/gnu/packages/qt.scm > > > @@ -10,6 +10,7 @@ > > > ;;; Copyright =C2=A9 2017, 2018 Tobias Geerinckx-Rice > > > ;;; Copyright =C2=A9 2018 Nicolas Goaziou > > > ;;; Copyright =C2=A9 2018 Hartmut Goebel > > > +;;; Copyright =C2=A9 2018 Eric Bavier > > > ;;; > > > ;;; This file is part of GNU Guix. > > > ;;; > > > @@ -2171,7 +2172,15 @@ different kinds of sliders, and much more.") > > > #:configure-flags (list ;"-DENABLE_API_TESTS=3DTRUE" > > > "-DPORT=3DQt" > > > "-DUSE_LIBHYPHEN=3DOFF" > > > - "-DUSE_SYSTEM_MALLOC=3DON"))) > > > + "-DUSE_SYSTEM_MALLOC=3DON" > > > + ;; XXX: relative dir installs to buil= d dir? > > > + (string-append "-DECM_MKSPECS_INSTALL= _DIR=3D" > > > + %output "/lib/qt5/mksp= ecs/modules") > > > + ;; Sacrifice a little speed in order = to link > > > + ;; libraries and test executables in a > > > + ;; reasonable amount of memory. > > > + "-DCMAKE_SHARED_LINKER_FLAGS=3D-Wl,--= no-keep-memory" > > > + "-DCMAKE_EXE_LINKER_FLAGS=3D-Wl,--no-= keep-memory"))) > > > (home-page "https://www.webkit.org") > > > (synopsis "Web browser engine and classes to render and interact= with web > > > content") =20 > >=20 > > I've tested this, and this fixed the qtwebkit build for me, which > > currently doesn't work on master. So I'm all for merging it. =20 >=20 > Thanks for testing it. I assume it was the linker flags that fixed the > build on your machine? For clarity, I suppose that change should be > moved to a separate patch. WDYT? I've split this patch in two and pushed as 0995a5692cb85418b2d5f21c24d46ee4aa9fb7c9 and ebdb15bc3540b1901f223bc0689bae51a2f88fc4 `~Eric --Sig_/fUKP/Td1S6JilxKRktHl+nq Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlv8phwACgkQ/XPKxxnT JWYKSQ/8D7N0qvuPXiFTvpxz+pEGji4wqYSKyOhyLbF0iFATSyIBVm1WIgRxXf6B 6I+ofDHt/YBkkFDmqXsNK9ryarygr76pjQUKjc5wDdT8hCZ2gUtGeZf/NnoB6qOK 5i48dmFheilQ/vXfrLLLTEYzbFcIel+0KSO0WM7055/4febIfp+pz+LOXBA0lA2Z SUZHBb81DxHfuta+dRSKmRZCWMlsjG++mOVhB7Em1sxv7h45DWMgABDqF3Q8iqvj Qgtr7l1+AG/jHqF3Q60AYx15MuwKjDFRngjI1hjr8N4ETHiKRRW1iRDntu5xsmAj yBA8bwFERy9zEMyuSdTyJHIUEdakU1jqI1CMDVh9Dw0iIDX0dTr4soOsuOMCvjP5 jb++oyhUEw5ZaD+GnH1tZ0FOd/9zW4X9ltcStWhMA33oAPfviIN4lA3ge1xh3m8q O2uWWvhLD5m8ibZwINmBhcu01zWNYTP1ZGSQyOqQk5bQzGuK1QNfzzYo6g4RN0S1 y03Asly2+x7e1Ijmg6PTd+VhWPEq2gGqzH9M05/k55y04GOm3Lql8r9cxU8Vk0Zn 6TInTuylIpfpddJd7BYKgnZCbXAy3pGDlD8bA27CEGvS4CXw4/GdwjDvRv6PJl40 NwspZ/HC1BSsTHRlZuuGjin9RwJkCgj5YZU4HjEZB9hyWd+3VKs= =aDPt -----END PGP SIGNATURE----- --Sig_/fUKP/Td1S6JilxKRktHl+nq--