From: Leo Famulari <leo@famulari.name>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: guix-devel@gnu.org
Subject: Re: Golang programs keeping references [gnu: go: Update default to 1.11.]
Date: Mon, 12 Nov 2018 12:48:20 -0500 [thread overview]
Message-ID: <20181112174820.GB12396@jasmine.lan> (raw)
In-Reply-To: <87efbqb3gy.fsf@ambrevar.xyz>
[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]
On Mon, Nov 12, 2018 at 06:38:53PM +0100, Pierre Neidhardt wrote:
> Yes, it should be statically linked. Isn't it the same issue as we recently had
> with go-1.11 itself?
>
> The fix was
>
> --8<---------------cut here---------------start------------->8---
> ;; Prevent installation of the build cache, which contains store
> ;; references to most of the tools used to build Go and would
> ;; unnecessarily increase the size of Go's closure if it was
> ;; installed.
> ;; TODO This should be moved into the 'install' phase when Go 1.9 is
> ;; removed.
> (add-before 'install 'delete-extraneous-files
> (lambda _
> (delete-file-recursively "../pkg/obj")
> #t))
Unfortunately, in this case, the references are within the executable
binaries, so it's not the same issue.
We could rewrite the references like we do for the errant compiler
references. This will be really expensive though — if there is no other
way, then it's time to finally move the Boyer-Moore implementation in
(guix grafts) to its own module so we can use it easily.
But ideally we could prevent these references from being created in the
first place.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-11-12 17:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181112093245.26230.94815@vcs0.savannah.gnu.org>
[not found] ` <20181112093246.AC1D620498@vcs0.savannah.gnu.org>
2018-11-12 17:29 ` Golang programs keeping references [gnu: go: Update default to 1.11.] Leo Famulari
2018-11-12 17:38 ` Pierre Neidhardt
2018-11-12 17:45 ` Leo Famulari
2018-11-12 17:48 ` Leo Famulari [this message]
2018-11-12 17:51 ` Leo Famulari
2018-12-09 18:46 ` Pierre Neidhardt
2018-12-14 9:15 ` Ludovic Courtès
2018-12-14 9:28 ` Pierre Neidhardt
2018-12-14 14:52 ` Ludovic Courtès
2018-12-14 15:20 ` Pierre Neidhardt
2018-12-15 18:10 ` Ludovic Courtès
2018-12-15 18:19 ` Pierre Neidhardt
2018-12-15 19:52 ` Leo Famulari
2018-12-15 19:57 ` Pierre Neidhardt
2018-12-15 19:55 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112174820.GB12396@jasmine.lan \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=mail@ambrevar.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.