From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: Golang programs keeping references [gnu: go: Update default to 1.11.] Date: Mon, 12 Nov 2018 12:48:20 -0500 Message-ID: <20181112174820.GB12396@jasmine.lan> References: <20181112093245.26230.94815@vcs0.savannah.gnu.org> <20181112093246.AC1D620498@vcs0.savannah.gnu.org> <20181112172925.GA8875@jasmine.lan> <87efbqb3gy.fsf@ambrevar.xyz> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+g7M9IMkV8truYOl" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMGQV-0002QK-In for guix-devel@gnu.org; Mon, 12 Nov 2018 12:55:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gMGKj-0003HR-6W for guix-devel@gnu.org; Mon, 12 Nov 2018 12:49:16 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:47187) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gMGKi-0002uS-W6 for guix-devel@gnu.org; Mon, 12 Nov 2018 12:49:09 -0500 Content-Disposition: inline In-Reply-To: <87efbqb3gy.fsf@ambrevar.xyz> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Pierre Neidhardt Cc: guix-devel@gnu.org --+g7M9IMkV8truYOl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 12, 2018 at 06:38:53PM +0100, Pierre Neidhardt wrote: > Yes, it should be statically linked. Isn't it the same issue as we recen= tly had > with go-1.11 itself? >=20 > The fix was >=20 > --8<---------------cut here---------------start------------->8--- > ;; Prevent installation of the build cache, which contains sto= re > ;; references to most of the tools used to build Go and would > ;; unnecessarily increase the size of Go's closure if it was > ;; installed. > ;; TODO This should be moved into the 'install' phase when Go = 1.9 is > ;; removed. > (add-before 'install 'delete-extraneous-files > (lambda _ > (delete-file-recursively "../pkg/obj") > #t)) Unfortunately, in this case, the references are within the executable binaries, so it's not the same issue. We could rewrite the references like we do for the errant compiler references. This will be really expensive though =E2=80=94 if there is no o= ther way, then it's time to finally move the Boyer-Moore implementation in (guix grafts) to its own module so we can use it easily. But ideally we could prevent these references from being created in the first place. --+g7M9IMkV8truYOl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlvpvOQACgkQJkb6MLrK fwgUDhAAoUOc8WYdHs16SIfjnqgdKW4Ed7dM0F0mXJXq7yIhzWv5nm/A5lnfMa3C 5zaaRpvlBpZ8J1mS0EbzU1vFGDBXDrb0YJwmNFiqw0J5DPtj6VhBBVP41yil2Avq xA6TCI7DrDjIfuLqCmGX32lrsJf9Lr07PsebRdKMcB8qojKYGZHvZG5SwSUaLD6g Go1MSu5QI3J/KeAxSBeul8AzllkO2XIJzEtG9q/rt88V8VqXHmMqVUggpLWQ14Dr 9+4qOKqvOoPFcqpaHlrHkQIm8My9QBo3zC3IluveRzm7C1OHli6gpAxhKTiE/iKK 6IIyB0zRAQi/CmL0A5y8UHAnpiAFO2OPjbK8k4LcbUCbJ7ACt9aCB3k8sXc04YYK Ff9o5TBhdGuFiTtAU1BZLbjZ3CspTNsxGYy/w1Yy/UExauINi1X0+dTvT0P9CQUm voUH/y5oDD/K4B8qUWLcSIu950m1UWdgxFeeyQWDnXD/UpgWFbIZHOI3jV5rTbre V55ihwEn9SWTcu8HBPeREPvER5k+gn8uDi2x0P2Q9+s/x3PKUAmUUe3+OvPeM0Bz PojwrmwJrmkO/gnzye8DeZgIG/8yGcFNHblBNBEttgE6dByNF6+fksxq6GX5cjuT Ou8IEr0tIQ09c2TxmwneHs6SpkFEtocMnPN2jqDt6GSdXaNR+Gs= =g8rh -----END PGP SIGNATURE----- --+g7M9IMkV8truYOl--