all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#33086] [PATCH] New package: python-ilinkedlist
@ 2018-10-18  6:24 Luther Thompson
  2018-10-21 21:50 ` bug#33086: " Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: Luther Thompson @ 2018-10-18  6:24 UTC (permalink / raw)
  To: 33086

I've written a Python module. Here is my package definition for it.
Please let me know if I can make any improvements.

---BEGIN---
diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 8261fefd9..59917feb7 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -14473,3 +14473,28 @@ extend common interfaces like NumPy, Pandas,
or Python iterators to larger-than-memory or distributed environments.
These parallel collections run on top of the dynamic task schedulers. ")
     (license license:bsd-3)))
+
+(define-public python-ilinkedlist
+  (package
+    (name "python-ilinkedlist")
+    (version "0.1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "ilinkedlist" version))
+       (sha256
+        (base32
+         "063c2gm4jkgkv0nsg7mrc8y0w82ms98l4xchmbrvr68cscglhk69"))))
+    (build-system python-build-system)
+    (native-inputs `(("python-pytest" ,python-pytest)))
+    (inputs `(("python" ,python)))
+    (home-page "https://github.com/luther9/ilinkedlist-py")
+    (synopsis "Immutable linked list library")
+    (description
+     "This is a implementation of immutable linked lists for Python.
It +contains @code{nil} (the empty linked list) and a @code{Pair} class
for nodes. +Since a linked list is treated as immutable, it is
hashable, and its length can +be retrieved in constant time.  Some of
the terminology is inspired by LISP.  It +is possible to create an
improper list by creating a @code{Pair} with a non-list +@code{cdr}.")
+    (license license:gpl3+)))
---END---

Regards,
Luther Thompson

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#33086: [PATCH] New package: python-ilinkedlist
  2018-10-18  6:24 [bug#33086] [PATCH] New package: python-ilinkedlist Luther Thompson
@ 2018-10-21 21:50 ` Ludovic Courtès
  2018-10-25 21:32   ` [bug#33086] " Luther Thompson
  0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2018-10-21 21:50 UTC (permalink / raw)
  To: Luther Thompson; +Cc: 33086-done

Hello Luther,

Luther Thompson <lutheroto@gmail.com> skribis:

> I've written a Python module. Here is my package definition for it.
> Please let me know if I can make any improvements.

It looks good to me!  I’ve applied it after adding a copyright line for
you and a commit log that follows our conventions.

In the future please send the patch as produced by ‘git format-patch’,
preferably as an attachment so that your email client doesn’t wrap
lines.  See
<https://gnu.org/software/guix/manual/en/html_node/Submitting-Patches.html>.

Thank you!

Ludo’.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#33086] [PATCH] New package: python-ilinkedlist
  2018-10-21 21:50 ` bug#33086: " Ludovic Courtès
@ 2018-10-25 21:32   ` Luther Thompson
  0 siblings, 0 replies; 3+ messages in thread
From: Luther Thompson @ 2018-10-25 21:32 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 33086-done

On Sun, 21 Oct 2018 23:50:10 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> Hello Luther,
> 
> Luther Thompson <lutheroto@gmail.com> skribis:
> 
> > I've written a Python module. Here is my package definition for it.
> > Please let me know if I can make any improvements.  
> 
> It looks good to me!  I’ve applied it after adding a copyright line
> for you and a commit log that follows our conventions.
> 
> In the future please send the patch as produced by ‘git format-patch’,
> preferably as an attachment so that your email client doesn’t wrap
> lines.  See
> <https://gnu.org/software/guix/manual/en/html_node/Submitting-Patches.html>.
> 
> Thank you!
> 
> Ludo’.

Awesome, thanks for the feedback.

Luther

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-10-25 21:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-18  6:24 [bug#33086] [PATCH] New package: python-ilinkedlist Luther Thompson
2018-10-21 21:50 ` bug#33086: " Ludovic Courtès
2018-10-25 21:32   ` [bug#33086] " Luther Thompson

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.