all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#31381] Drop libmad from MPD
@ 2018-05-07 23:03 Leo Famulari
  2018-05-07 23:08 ` [bug#31381] [PATCH] gnu: MPD: Remove unecessary dependency on libmad Leo Famulari
  0 siblings, 1 reply; 3+ messages in thread
From: Leo Famulari @ 2018-05-07 23:03 UTC (permalink / raw)
  To: 31381

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

Currently, MPD links to both LAME (via FFmpeg) and libmad for MP3
decoding. It works for me to drop the dependency on libmad and just use
LAME.

Does anyone else want to check if the change breaks their stereo?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#31381] [PATCH] gnu: MPD: Remove unecessary dependency on libmad.
  2018-05-07 23:03 [bug#31381] Drop libmad from MPD Leo Famulari
@ 2018-05-07 23:08 ` Leo Famulari
  2018-05-12 20:20   ` bug#31381: " Leo Famulari
  0 siblings, 1 reply; 3+ messages in thread
From: Leo Famulari @ 2018-05-07 23:08 UTC (permalink / raw)
  To: 31381

MPD already depends on FFmpeg, which uses LAME for MP3 decoding.

gnu/packages/mpd.scm (mpd)[inputs]: Remove LIBMAD.
---
 gnu/packages/mpd.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/mpd.scm b/gnu/packages/mpd.scm
index 188903549..6f2ff5d78 100644
--- a/gnu/packages/mpd.scm
+++ b/gnu/packages/mpd.scm
@@ -119,9 +119,10 @@ interfacing MPD in the C, C++ & Objective C languages.")
               ("flac" ,flac)
               ("glib" ,glib)
               ("icu4c" ,icu4c)
+              ;; The LAME decoder comes from FFmpeg, but is added here so that
+              ;; configure picks up the LAME encoder.
               ("lame" ,lame)
               ("libid3tag" ,libid3tag)
-              ("libmad" ,libmad)
               ("libmpdclient" ,libmpdclient)
               ("libsamplerate" ,libsamplerate)
               ("libsndfile" ,libsndfile)
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#31381: [PATCH] gnu: MPD: Remove unecessary dependency on libmad.
  2018-05-07 23:08 ` [bug#31381] [PATCH] gnu: MPD: Remove unecessary dependency on libmad Leo Famulari
@ 2018-05-12 20:20   ` Leo Famulari
  0 siblings, 0 replies; 3+ messages in thread
From: Leo Famulari @ 2018-05-12 20:20 UTC (permalink / raw)
  To: 31381-done

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

On Mon, May 07, 2018 at 07:08:22PM -0400, Leo Famulari wrote:
> MPD already depends on FFmpeg, which uses LAME for MP3 decoding.
> 
> gnu/packages/mpd.scm (mpd)[inputs]: Remove LIBMAD.

Pushed as 241caa62ca315177fd1dfc10a64621a9d29d26dd

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-12 20:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-07 23:03 [bug#31381] Drop libmad from MPD Leo Famulari
2018-05-07 23:08 ` [bug#31381] [PATCH] gnu: MPD: Remove unecessary dependency on libmad Leo Famulari
2018-05-12 20:20   ` bug#31381: " Leo Famulari

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.