all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: Charlie Ritter <chewzerita@posteo.net>
Cc: 31259@debbugs.gnu.org
Subject: [bug#31259] [PATCH] Add gnuradio
Date: Wed, 25 Apr 2018 13:36:27 +0200	[thread overview]
Message-ID: <20180425133627.35995620@scratchpost.org> (raw)
In-Reply-To: <cuczi1rbmkc.fsf@posteo.net>

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

Hi!

Thanks for the patch.

I have the following suggestions:

* Please unbundle volk.
* Please build the documentation (that needs doxygen, ghostscript and texlive-tiny).  After that, remove docs/doxygen/html/_formulas.log because it contains timestamps.
* Please add dependency to alsa-lib.
* Please add dependency to libusb.
* Why not fftwf?
* We should investigate whether grc actually needs the inputs to be propagated (later).
* Please add dependency to cppunit.
* Please add dependency to orc.
* Swig probably is not needed at runtime - isn't a native-input enough?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-04-25 11:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-25 10:35 [bug#31259] [PATCH] Add gnuradio Charlie Ritter
2018-04-25 11:36 ` Danny Milosavljevic [this message]
2018-05-25 12:03   ` Ludovic Courtès
2018-05-25 15:04     ` Charlie Ritter
2020-04-09 21:31 ` bug#31259: " Guillaume Le Vaillant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180425133627.35995620@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=31259@debbugs.gnu.org \
    --cc=chewzerita@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.