all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: pjotr.public12@thebird.nl
Cc: 30411@debbugs.gnu.org, Pjotr Prins <pjotr.public01@thebird.nl>
Subject: [bug#30411] [PATCH] gnu: ldc: Update to 1.7.0.
Date: Sun, 18 Feb 2018 13:34:49 +0100	[thread overview]
Message-ID: <20180218133449.0273e0b3@scratchpost.org> (raw)
In-Reply-To: <20180218060944.7608-1-pjotr.public12@thebird.nl>

Hi Pjotr,

On Sun, 18 Feb 2018 06:09:44 +0000
pjotr.public12@thebird.nl wrote:

>                 ;; FIXME: this test cannot be linked.
>                 (delete-file "tests/d2/dmd-testsuite/runnable/cppa.d")

Is there an upstream bugreport?

I wonder who added this line... yep, it was me.  Sigh :)

> +               ;; the following two tests fail on i686
> +               (for-each delete-file '("tests/ir/attributes.d" "tests/ir/align.d"))))

Is there an upstream bugreport?  What is the error message?

> +           (replace 'check
> +             ;; the ldc compiler does not use phobos, therefore no need to test in the bootstrap
> +             (lambda* (#:key inputs outputs #:allow-other-keys)
> +               (and
> +                (zero? (system* "ctest" "-j" (number->string (parallel-job-count)) "-V" "-R" "build-druntime-ldc-unittest"))
> +                (zero? (system* "ctest" "-j" (number->string (parallel-job-count)) "--output-on-failure" "-E" "dmd-testsuite|lit-tests|ldc2-unittest|llvm-ir-testsuite"))))))))

Please use invoke.

>        (description
> -       "LDC is a compiler for the D programming language.  It is based on the
> -latest DMD frontend and uses LLVM as backend.")
> +       "LDC is a compiler for the D programming language.  It is based on
> +the latest DMD compiler that was written in C and is used for
> +bootstrapping more recent compilers written in D.")

Nice!

> +           (replace 'check
> +                    (lambda* (#:key inputs outputs #:allow-other-keys)
> +                      ;; some tests call into gdb binary which needs SHELL and CC set
> +                      (setenv "SHELL" (which "sh"))
> +                      (setenv "CC" (string-append (assoc-ref inputs "gcc") "/bin/gcc"))
> +                      (zero? (system* "make" "test" "-j" (number->string (parallel-job-count))))))))

Use invoke.

> +     TestScript prog = "/gnu/store/42d5rjrdkln6nwvzwdc8dyd4w6iy3n5j-coreutils-8.27/bin/echo";

Uuuuuh store reference?  Isn't that a bad idea here?

  reply	other threads:[~2018-02-18 12:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-10 14:12 [bug#30411] [FIXME] Dlang ldc and dub packages fail on core-updates Pjotr Prins
2018-02-18  6:09 ` [bug#30411] [PATCH] gnu: ldc: Update to 1.7.0 pjotr.public12
2018-02-18 12:34   ` Danny Milosavljevic [this message]
2018-02-18 21:58     ` Pjotr Prins
     [not found]     ` <20180218214110.GB9488@thebird.nl>
2018-02-20  9:47       ` Danny Milosavljevic
2018-02-21  1:26         ` Pjotr Prins
2018-02-22  1:42           ` Pjotr Prins
2018-02-23 11:59             ` bug#30411: " Danny Milosavljevic
2018-02-23 17:10               ` [bug#30411] " Pjotr Prins
2018-02-23 17:31                 ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180218133449.0273e0b3@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=30411@debbugs.gnu.org \
    --cc=pjotr.public01@thebird.nl \
    --cc=pjotr.public12@thebird.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.