From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59409)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1enOBN-0004F0-5X
	for guix-patches@gnu.org; Sun, 18 Feb 2018 07:35:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1enOBJ-00045X-Vb
	for guix-patches@gnu.org; Sun, 18 Feb 2018 07:35:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:41093)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1enOBJ-00045T-S5
	for guix-patches@gnu.org; Sun, 18 Feb 2018 07:35:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1enOBJ-0003DI-MM
	for guix-patches@gnu.org; Sun, 18 Feb 2018 07:35:01 -0500
Subject: [bug#30411] [PATCH] gnu: ldc: Update to 1.7.0.
Resent-Message-ID: <handler.30411.B30411.151895729512337@debbugs.gnu.org>
Date: Sun, 18 Feb 2018 13:34:49 +0100
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20180218133449.0273e0b3@scratchpost.org>
In-Reply-To: <20180218060944.7608-1-pjotr.public12@thebird.nl>
References: <20180210141208.GA13051@thebird.nl>
	<20180218060944.7608-1-pjotr.public12@thebird.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: pjotr.public12@thebird.nl
Cc: 30411@debbugs.gnu.org, Pjotr Prins <pjotr.public01@thebird.nl>

Hi Pjotr,

On Sun, 18 Feb 2018 06:09:44 +0000
pjotr.public12@thebird.nl wrote:

>                 ;; FIXME: this test cannot be linked.
>                 (delete-file "tests/d2/dmd-testsuite/runnable/cppa.d")

Is there an upstream bugreport?

I wonder who added this line... yep, it was me.  Sigh :)

> +               ;; the following two tests fail on i686
> +               (for-each delete-file '("tests/ir/attributes.d" "tests/ir/align.d"))))

Is there an upstream bugreport?  What is the error message?

> +           (replace 'check
> +             ;; the ldc compiler does not use phobos, therefore no need to test in the bootstrap
> +             (lambda* (#:key inputs outputs #:allow-other-keys)
> +               (and
> +                (zero? (system* "ctest" "-j" (number->string (parallel-job-count)) "-V" "-R" "build-druntime-ldc-unittest"))
> +                (zero? (system* "ctest" "-j" (number->string (parallel-job-count)) "--output-on-failure" "-E" "dmd-testsuite|lit-tests|ldc2-unittest|llvm-ir-testsuite"))))))))

Please use invoke.

>        (description
> -       "LDC is a compiler for the D programming language.  It is based on the
> -latest DMD frontend and uses LLVM as backend.")
> +       "LDC is a compiler for the D programming language.  It is based on
> +the latest DMD compiler that was written in C and is used for
> +bootstrapping more recent compilers written in D.")

Nice!

> +           (replace 'check
> +                    (lambda* (#:key inputs outputs #:allow-other-keys)
> +                      ;; some tests call into gdb binary which needs SHELL and CC set
> +                      (setenv "SHELL" (which "sh"))
> +                      (setenv "CC" (string-append (assoc-ref inputs "gcc") "/bin/gcc"))
> +                      (zero? (system* "make" "test" "-j" (number->string (parallel-job-count))))))))

Use invoke.

> +     TestScript prog = "/gnu/store/42d5rjrdkln6nwvzwdc8dyd4w6iy3n5j-coreutils-8.27/bin/echo";

Uuuuuh store reference?  Isn't that a bad idea here?