* hardcoded $HOME/.guix-profile in kdevelop
@ 2017-09-04 19:17 Ricardo Wurmus
2017-09-05 6:47 ` Thomas Danckaert
2017-10-08 17:09 ` Thomas Danckaert
0 siblings, 2 replies; 3+ messages in thread
From: Ricardo Wurmus @ 2017-09-04 19:17 UTC (permalink / raw)
To: thomas.danckaert; +Cc: guix-devel
Hi,
I just stumbled upon commit 2f4d08ee7f897e254c6e533ad2d69c7fe4998f38
while looking for an example of a package that uses QT_PLUGIN_PATH. I
noticed that the above commit unconditionally adds “$HOME/.guix-profile”
to the XDG_DATA_DIRS.
I think we should not hardcode the default user profile directory in
application wrappers. Is it really necessary to add
“$HOME/.guix-profile” to XDG_DATA_DIRS in the wrapper? Will the package
fail to work when it is installed to a different profile?
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: hardcoded $HOME/.guix-profile in kdevelop
2017-09-04 19:17 hardcoded $HOME/.guix-profile in kdevelop Ricardo Wurmus
@ 2017-09-05 6:47 ` Thomas Danckaert
2017-10-08 17:09 ` Thomas Danckaert
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Danckaert @ 2017-09-05 6:47 UTC (permalink / raw)
To: rekado; +Cc: guix-devel
From: Ricardo Wurmus <rekado@elephly.net>
Subject: hardcoded $HOME/.guix-profile in kdevelop
Date: Mon, 04 Sep 2017 21:17:44 +0200
> I just stumbled upon commit 2f4d08ee7f897e254c6e533ad2d69c7fe4998f38
> while looking for an example of a package that uses QT_PLUGIN_PATH.
> I
> noticed that the above commit unconditionally adds
> “$HOME/.guix-profile”
> to the XDG_DATA_DIRS.
>
> I think we should not hardcode the default user profile directory in
> application wrappers. Is it really necessary to add
> “$HOME/.guix-profile” to XDG_DATA_DIRS in the wrapper? Will the
> package
> fail to work when it is installed to a different profile?
Hi,
some icons were missing from the interface, and adding
<profile>/share to XDG_DATA_DIRS improved that. But you're right
that this is not a proper solution (I was young and naive at the time
;-) ). Probably it can be solved just as well by installing the
icons in the proper directory (something like
<out>/share/icons/hicolor ?).
I'll try to improve this.
There's a similar problem with QT_PLUGIN_PATH, though perhaps that
will be fixed with the qt/kde install location patches people are
currently working on.
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: hardcoded $HOME/.guix-profile in kdevelop
2017-09-04 19:17 hardcoded $HOME/.guix-profile in kdevelop Ricardo Wurmus
2017-09-05 6:47 ` Thomas Danckaert
@ 2017-10-08 17:09 ` Thomas Danckaert
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Danckaert @ 2017-10-08 17:09 UTC (permalink / raw)
To: rekado; +Cc: guix-devel
From: Ricardo Wurmus <rekado@elephly.net>
Subject: hardcoded $HOME/.guix-profile in kdevelop
Date: Mon, 04 Sep 2017 21:17:44 +0200
> I think we should not hardcode the default user profile directory in
> application wrappers. Is it really necessary to add
> “$HOME/.guix-profile” to XDG_DATA_DIRS in the wrapper? Will the
> package
> fail to work when it is installed to a different profile?
Finally fixed this (commit 3ceb70e1e). Apologies for the delay: I
was trying to fix the tests at the same time, but that didn't work
out.
cheers,
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-08 17:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-04 19:17 hardcoded $HOME/.guix-profile in kdevelop Ricardo Wurmus
2017-09-05 6:47 ` Thomas Danckaert
2017-10-08 17:09 ` Thomas Danckaert
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.