From: Christopher Baines <mail@cbaines.net>
To: Hellseher <sharlatanus@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: Guix - installation script
Date: Sat, 2 Sep 2017 17:04:22 +0100 [thread overview]
Message-ID: <20170902170422.080d3e95@cbaines.net> (raw)
In-Reply-To: <20170827233617.50a21464@cbaines.net>
[-- Attachment #1: Type: text/plain, Size: 2236 bytes --]
On Sun, 27 Aug 2017 23:36:17 +0100
Christopher Baines <mail@cbaines.net> wrote:
> On Sat, 26 Aug 2017 21:51:12 +0100
> Hellseher <sharlatanus@gmail.com> wrote:
>
> > Hi,
> >
> > That's great, thank you!
> >
> > I'll go through all suggestions and make required changes as soon
> > as possible.
> >
> > Do you want to move that script to separate stand along repository
> > to make it easy for other to review it?
>
> What might work well is for you to send the whole script to guix-devel
> in an email. Then people can read through and review it.
>
> I'll try to make some time to review and test this in the coming week.
I've tried running this in a Debian VM, and I've nearly managed to get
Guix installed.
From my experience, I've got some suggestions for the script.
Firstly, I see this as installing GNU Guix, not GuixSD, as I understand
GuixSD to be an operating system, and this script won't install an OS,
just Guix within your existing operating system.
For the ascii art, I tweaked it by removing the SD, and adding some
separation between the i and x to make it more readable.
_____ _ _ _ _ _____ _
/ ____| \ | | | | | / ____| (_)
| | __| \| | | | | | | __ _ _ _ __ __
| | |_ | . ` | | | | | | |_ | | | | |\ \/ /
| |__| | |\ | |__| | | |__| | |_| | | > <
\_____|_| \_|\____/ \_____|\__,_|_|/_/\_\
Just requiring one of curl and wget would be good, either by removing
the need to use curl (it wasn't on the Debian system I was testing
with), or making it possible to use either would work.
I think the requirement on which could be removed by using the bash
builtin type.
Also, for checking dependencies, currently when it fails, the entire
script stops as command exits with a status of 1. Something like this
would work though:
if ! command -v "$c" &>/dev/null; then
warn+=("$c")
fi
I think running guix package -i at the end might be a bit too much.
Maybe it would be better to suggest running a less permanent command,
e.g. guix environment --ad-hoc hello -- hello, and directing them to
IRC or the mailing list if they have problems?
Thanks again for writing this :)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2017-09-02 16:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 22:49 Guix - installation script Sharlatan Hellseher
2017-08-01 10:55 ` ng0
2017-08-01 17:29 ` Sharlatan Hellseher
2017-08-25 18:33 ` Christopher Baines
2017-08-26 12:57 ` Ludovic Courtès
2017-08-26 20:51 ` Hellseher
2017-08-27 22:36 ` Christopher Baines
2017-09-02 16:04 ` Christopher Baines [this message]
2017-09-07 18:11 ` Hellseher
2017-09-07 18:25 ` Christopher Baines
2017-10-02 6:15 ` Pjotr Prins
2017-12-05 10:55 ` Catonano
2018-01-28 18:00 ` Ricardo Wurmus
2018-01-28 19:14 ` Catonano
2018-02-04 10:04 ` Hellseher
2018-02-05 11:05 ` Ludovic Courtès
2017-12-11 22:31 ` myglc2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170902170422.080d3e95@cbaines.net \
--to=mail@cbaines.net \
--cc=guix-devel@gnu.org \
--cc=sharlatanus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.