From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christopher Baines Subject: Re: Guix - installation script Date: Sat, 2 Sep 2017 17:04:22 +0100 Message-ID: <20170902170422.080d3e95@cbaines.net> References: <20170825193351.110a5221@cbaines.net> <878ti6a3lf.fsf@gnu.org> <20170827233617.50a21464@cbaines.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/oLAtxHRXooZ3JT6+ssq_s0F"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doAuQ-0007dH-Q0 for guix-devel@gnu.org; Sat, 02 Sep 2017 12:04:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1doAuM-00032x-2n for guix-devel@gnu.org; Sat, 02 Sep 2017 12:04:34 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:43622 helo=mira.cbaines.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1doAuL-00032j-Pp for guix-devel@gnu.org; Sat, 02 Sep 2017 12:04:30 -0400 In-Reply-To: <20170827233617.50a21464@cbaines.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Hellseher Cc: guix-devel@gnu.org --Sig_/oLAtxHRXooZ3JT6+ssq_s0F Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 27 Aug 2017 23:36:17 +0100 Christopher Baines wrote: > On Sat, 26 Aug 2017 21:51:12 +0100 > Hellseher wrote: >=20 > > Hi, > >=20 > > That's great, thank you! > >=20 > > I'll go through all suggestions and make required changes as soon > > as possible. > >=20 > > Do you want to move that script to separate stand along repository > > to make it easy for other to review it? =20 >=20 > What might work well is for you to send the whole script to guix-devel > in an email. Then people can read through and review it. >=20 > I'll try to make some time to review and test this in the coming week. I've tried running this in a Debian VM, and I've nearly managed to get Guix installed. =46rom my experience, I've got some suggestions for the script. Firstly, I see this as installing GNU Guix, not GuixSD, as I understand GuixSD to be an operating system, and this script won't install an OS, just Guix within your existing operating system. For the ascii art, I tweaked it by removing the SD, and adding some separation between the i and x to make it more readable. _____ _ _ _ _ _____ _ / ____| \ | | | | | / ____| (_) | | __| \| | | | | | | __ _ _ _ __ __ | | |_ | . ` | | | | | | |_ | | | | |\ \/ / | |__| | |\ | |__| | | |__| | |_| | | > < \_____|_| \_|\____/ \_____|\__,_|_|/_/\_\ Just requiring one of curl and wget would be good, either by removing the need to use curl (it wasn't on the Debian system I was testing with), or making it possible to use either would work. I think the requirement on which could be removed by using the bash builtin type. Also, for checking dependencies, currently when it fails, the entire script stops as command exits with a status of 1. Something like this would work though: if ! command -v "$c" &>/dev/null; then warn+=3D("$c") fi I think running guix package -i at the end might be a bit too much. Maybe it would be better to suggest running a less permanent command, e.g. guix environment --ad-hoc hello -- hello, and directing them to IRC or the mailing list if they have problems? Thanks again for writing this :) --Sig_/oLAtxHRXooZ3JT6+ssq_s0F Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmq1odfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfmSg/+K2SK+63YcVSZ1Q7tL7onFYC0q6aaEqQ0kRAwPkbbGvTOMVtB/2uka8iI uFwrem9pLZCUkQB6uTb1T7RHzb8RwCeSI1bz5f6NujO6ITYbLl289aVKv3kOUTJH zKw8qxmSEHcp3EP/D1Bkf/LPFbqd41kOigqwJBssgJQPBbhyash3kRPVqbPhzgWT 6PtcILmjw6q5JjUBMFbeu1exoV22Z9PEU2RPOwa3Yh6kzI0GIUFDoK5X9Qa8AC9/ wVggmL/liRXLRZe2spoOgHPPEAQgH449AFjyYgEeLrQrKdEeH7fjF3eZYGplyU7s NSiZt3nir90yoDMPtfVpARLHQBINeP9yJ4a962Mm8JWUGaUPdFqsjBCnqQn7b1/z bBpdnMoFZ6mUWhG+h8+NKwwDjX9uOmz8pClijBjT+WCg1hz5ODPPTtyxjgIS3ajN /haA9JFtFehojwx3qqW18v8qQdyZJ8BoP30UVTmt8FzYxJ9WjbtV4ZM8uJFbEOJ1 ktRmF4IpaQBT4UpgyZHQ1i3vI9U7VmP1O6hO9RChZKI+yJWv8TCt+AGC/TG2YA0U PHDzyeSthzKsp2nF99yEAXkkw2nzIWZGEGeC3/7wjToWBV0i7LfgIUj3chOSAEgc hK3VvwyBOChYI6/x1YeJLUWqMafUYZhvPxhz1QdkQ9fdZW3/CuY= =FcIV -----END PGP SIGNATURE----- --Sig_/oLAtxHRXooZ3JT6+ssq_s0F--